ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-01-21 17:24:03 -05:00
Code Issues Packages Projects Releases Wiki Activity

require confirmation when risks present (#1668)

Browse Source
This commit is contained in:
Alan Ren
2022-09-02 12:50:30 -07:00
committed by GitHub
parent 41556aea54
commit 7f675b884f
7 changed files with 41 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/Microsoft.SqlTools.ServiceLayer/TableDesigner/Contracts/Requests/GeneratePreviewReportRequest.cs
View File

@@ -12,29 +12,39 @@ namespace Microsoft.SqlTools.ServiceLayer.TableDesigner.Contracts
/// The service request to generate preview report describing the changes.
/// </summary>
public class GeneratePreviewReportResult
public class GeneratePreviewReportResult
{
/// <summary>
/// The report generated for publish preview
/// </summary>
public string Report;
public string? Report { get; set; }
/// <summary>
/// format (mimetype) of the string
/// </summary>
public string MimeType;
public string? MimeType { get; set; }
/// <summary>
/// Whether user confirmation is required.
/// </summary>
public bool RequireConfirmation { get; set; }
/// <summary>
/// The confirmation text.
/// </summary>
public string? ConfirmationText { get; set; }
/// <summary>
/// Metadata about the table
/// </summary>
public Dictionary<string, string> Metadata { get; set; }
public Dictionary<string, string>? Metadata { get; set; }
/// <summary>
/// The table schema validation error
/// </summary>
public string SchemaValidationError { get; set; }
public string? SchemaValidationError { get; set; }
}
/// <summary>
/// The service request to generate preview report describing the changes.
/// </summary>

4
src/Microsoft.SqlTools.ServiceLayer/TableDesigner/TableDesignerService.cs
View File

@@ -196,9 +196,11 @@ namespace Microsoft.SqlTools.ServiceLayer.TableDesigner
{
var table = this.GetTableDesigner(tableInfo);
var report = table.GenerateReport();
generatePreviewReportResult.Report = report;
generatePreviewReportResult.Report = report.Report;
generatePreviewReportResult.MimeType = "text/markdown";
generatePreviewReportResult.Metadata = this.GetMetadata(tableInfo);
generatePreviewReportResult.RequireConfirmation = report.RequireTableRecreation || report.PossibleDataLoss || report.HasWarnings;
generatePreviewReportResult.ConfirmationText = generatePreviewReportResult.RequireConfirmation ? SR.TableDesignerConfirmationText : null;
await requestContext.SendResult(generatePreviewReportResult);
}
catch (DesignerValidationException e)