Modify Get Connection String Request to use connection details (#1394)

* connection string accepts connectionInfo

* get connection string from disconnected scenarios

docs/guide/jsonrpc_protocol.md

@@ -532,7 +532,11 @@ Get a connection string for the provided connection.
         /// </summary>
         public string OwnerUri { get; set; }
 
+        /// Connection info of the connection
+        /// </summary>
+        public ConnectionDetails ConnectionDetails { get; set; }
         /// <summary>
+
         /// Indicates whether the password should be return in the connection string. Default is false.
         /// </summary>
         public bool IncludePassword { get; set; }

src/Microsoft.SqlTools.ServiceLayer/Connection/ConnectionService.cs

@@ -1317,12 +1317,20 @@ namespace Microsoft.SqlTools.ServiceLayer.Connection
             {
                 string connectionString = string.Empty;
                 ConnectionInfo info;
-                if (TryFindConnection(connStringParams.OwnerUri, out info))
+                SqlConnectionStringBuilder connStringBuilder;
-                {
                 try
                 {   
-                        SqlConnectionStringBuilder connStringBuilder = CreateConnectionStringBuilder(info.ConnectionDetails);
+                    // set connection string using connection uri if connection details are undefined
-
+                    if (connStringParams.ConnectionDetails == null)
+                    {
+                        TryFindConnection(connStringParams.OwnerUri, out info);
+                        connStringBuilder = CreateConnectionStringBuilder(info.ConnectionDetails);
+                    }
+                    // set connection string using connection details
+                    else
+                    {
+                        connStringBuilder = CreateConnectionStringBuilder(connStringParams.ConnectionDetails as ConnectionDetails);
+                    }
                     if (!connStringParams.IncludePassword)
                     {
                         connStringBuilder.Password = ConnectionService.PasswordPlaceholder;
@@ -1338,7 +1346,6 @@ namespace Microsoft.SqlTools.ServiceLayer.Connection
                 {
                     await requestContext.SendError(e.ToString());
                 }
-                }
 
                 await requestContext.SendResult(connectionString);
             });

src/Microsoft.SqlTools.ServiceLayer/Connection/Contracts/GetConnectionStringParams.cs

@@ -15,6 +15,11 @@ namespace Microsoft.SqlTools.ServiceLayer.Connection.Contracts
         /// </summary>
         public string OwnerUri { get; set; }
 
+        /// <summary>
+        /// Connection information of the connection
+        /// </summary>
+        public ConnectionDetails ConnectionDetails { get; set; }
+
         /// <summary>
         /// Indicates whether the password should be return in the connection string
         /// default is set to false

test/Microsoft.SqlTools.ServiceLayer.IntegrationTests/Connection/ConnectionServiceTests.cs

@@ -124,6 +124,7 @@ namespace Microsoft.SqlTools.ServiceLayer.IntegrationTests.Connection
             var requestParams = new GetConnectionStringParams()
             {
                 OwnerUri = result.ConnectionInfo.OwnerUri,
+                ConnectionDetails = null,
                 IncludePassword = false,
                 IncludeApplicationName = true
             };
@@ -159,6 +160,7 @@ namespace Microsoft.SqlTools.ServiceLayer.IntegrationTests.Connection
             var requestParams = new GetConnectionStringParams()
             {
                 OwnerUri = result.ConnectionInfo.OwnerUri,
+                ConnectionDetails = null,
                 IncludePassword = false,
                 IncludeApplicationName = false
             };
@@ -166,5 +168,32 @@ namespace Microsoft.SqlTools.ServiceLayer.IntegrationTests.Connection
             await service.HandleGetConnectionStringRequest(requestParams, requestContext.Object);
             requestContext.VerifyAll();
         }
+
+        /// <summary>
+        /// Test HandleGetConnectionStringRequest
+        /// Using connection details to build connection string
+        /// </summary>
+        [Test]
+        public async Task GetCurrentConnectionStringTestwithConnectionDetails()
+        {
+            // If we make a connection to a live database 
+            ConnectionService service = ConnectionService.Instance;
+            var result = LiveConnectionHelper.InitLiveConnectionInfo();
+            var resultConnectionDetails = result.ConnectionInfo.ConnectionDetails;
+            var requestContext = new Mock<SqlTools.Hosting.Protocol.RequestContext<string>>();
+
+            requestContext.Setup(x => x.SendResult(It.Is<string>((connectionString) => connectionString.Contains(resultConnectionDetails.ToString()))))
+                            .Returns(Task.FromResult(new object()));
+            var requestParams = new GetConnectionStringParams()
+            {
+                OwnerUri = null,
+                ConnectionDetails = {ServerName = "testServer", DatabaseName = "testDatabase", UserName = "sa", Password = "password", ApplicationName = "TestApp"},
+                IncludePassword = true,
+                IncludeApplicationName = true
+            };
+
+            await service.HandleGetConnectionStringRequest(requestParams, requestContext.Object);
+            requestContext.VerifyAll();
+        }
     }
 }