Convert most tools service tests to nunit (#1037)

* Remove xunit dependency from testdriver

* swap expected/actual as needed

* Convert Test.Common to nunit

* port hosting unit tests to nunit

* port batchparser integration tests to nunit

* port testdriver.tests to nunit

* fix target to copy dependency

* port servicelayer unittests to nunit

* more unit test fixes

* port integration tests to nunit

* fix test method type

* try using latest windows build for PRs

* reduce test memory use

test/Microsoft.SqlTools.ServiceLayer.IntegrationTests/QueryExecution/DataStorage/StorageDataReaderTests.cs

@@ -8,7 +8,7 @@ using System.Data.Common;
 using Microsoft.SqlTools.ServiceLayer.Connection;
 using Microsoft.SqlTools.ServiceLayer.IntegrationTests.Utility;
 using Microsoft.SqlTools.ServiceLayer.QueryExecution.DataStorage;
-using Xunit;
+using NUnit.Framework;
 
 namespace Microsoft.SqlTools.ServiceLayer.IntegrationTests.QueryExecution.DataStorage
 {
@@ -30,7 +30,7 @@ namespace Microsoft.SqlTools.ServiceLayer.IntegrationTests.QueryExecution.DataSt
         /// <summary>
         /// Validate GetBytesWithMaxCapacity
         /// </summary>
-        [Fact]
+        [Test]
         public void GetBytesWithMaxCapacityTest()
         {
             var storageReader = GetTestStorageDataReader(
@@ -47,7 +47,7 @@ namespace Microsoft.SqlTools.ServiceLayer.IntegrationTests.QueryExecution.DataSt
         /// <summary>
         /// Validate GetCharsWithMaxCapacity
         /// </summary>
-        [Fact]
+        [Test]
         public void GetCharsWithMaxCapacityTest()
         {
             var storageReader = GetTestStorageDataReader(
@@ -69,7 +69,7 @@ namespace Microsoft.SqlTools.ServiceLayer.IntegrationTests.QueryExecution.DataSt
         /// <summary>
         /// Validate GetXmlWithMaxCapacity
         /// </summary>
-        [Fact]
+        [Test]
         public void GetXmlWithMaxCapacityTest()
         {
             var storageReader = GetTestStorageDataReader(
@@ -86,7 +86,7 @@ namespace Microsoft.SqlTools.ServiceLayer.IntegrationTests.QueryExecution.DataSt
         /// <summary>
         /// Validate StringWriterWithMaxCapacity Write test
         /// </summary>
-        [Fact]
+        [Test]
         public void StringWriterWithMaxCapacityTest()
         {
             var writer = new StorageDataReader.StringWriterWithMaxCapacity(null, 4);

test/Microsoft.SqlTools.ServiceLayer.IntegrationTests/QueryExecution/ExecuteTests.cs

@@ -6,19 +6,20 @@
 using System;
 using System.Collections.Concurrent;
 using System.Data.Common;
+using System.Linq;
 using Microsoft.SqlTools.ServiceLayer.Connection;
 using Microsoft.SqlTools.ServiceLayer.IntegrationTests.Utility;
 using Microsoft.SqlTools.ServiceLayer.QueryExecution;
 using Microsoft.SqlTools.ServiceLayer.QueryExecution.DataStorage;
 using Microsoft.SqlTools.ServiceLayer.SqlContext;
 using Microsoft.SqlTools.ServiceLayer.Test.Common;
-using Xunit;
+using NUnit.Framework;
 
 namespace Microsoft.SqlTools.ServiceLayer.IntegrationTests.QueryExecution
 {
     public class ExecuteTests
     {
-        [Fact]
+        [Test]
         public void RollbackTransactionFailsWithoutBeginTransaction()
         {
             const string refactorText = "ROLLBACK TRANSACTION";
@@ -37,7 +38,7 @@ namespace Microsoft.SqlTools.ServiceLayer.IntegrationTests.QueryExecution
             Assert.True(query.Batches[0].HasError);
         }
 
-        [Fact]
+        [Test]
         public void TransactionsSucceedAcrossQueries()
         {
             const string beginText = "BEGIN TRANSACTION";
@@ -56,7 +57,7 @@ namespace Microsoft.SqlTools.ServiceLayer.IntegrationTests.QueryExecution
             Assert.False(rollbackQuery.Batches[0].HasError);
         }
 
-        [Fact]
+        [Test]
         public void TempTablesPersistAcrossQueries()
         {
             const string createTempText = "CREATE TABLE #someTempTable (id int)";
@@ -75,7 +76,7 @@ namespace Microsoft.SqlTools.ServiceLayer.IntegrationTests.QueryExecution
             Assert.False(insertTempQuery.Batches[0].HasError);
         }
 
-        [Fact]
+        [Test]
         public void DatabaseChangesWhenCallingUseDatabase()
         {
             const string master = "master";
@@ -92,27 +93,15 @@ namespace Microsoft.SqlTools.ServiceLayer.IntegrationTests.QueryExecution
 
             // If I use master, the current database should be master
             CreateAndExecuteQuery(string.Format(useQuery, master), connInfo, fileStreamFactory);
-            Assert.Equal(master, connInfo.ConnectionDetails.DatabaseName);
+            Assert.AreEqual(master, connInfo.ConnectionDetails.DatabaseName);
 
             // If I use tempdb, the current database should be tempdb
             CreateAndExecuteQuery(string.Format(useQuery, tempdb), connInfo, fileStreamFactory);
-            Assert.Equal(tempdb, connInfo.ConnectionDetails.DatabaseName);
+            Assert.AreEqual(tempdb, connInfo.ConnectionDetails.DatabaseName);
 
             // If I switch back to master, the current database should be master
             CreateAndExecuteQuery(string.Format(useQuery, master), connInfo, fileStreamFactory);
-            Assert.Equal(master, connInfo.ConnectionDetails.DatabaseName);
-        }
-
-        [Fact]
-        public void TestBatchExecutionTime() {
-            var result = LiveConnectionHelper.InitLiveConnectionInfo();
-            ConnectionInfo connInfo = result.ConnectionInfo;
-            var fileStreamFactory = MemoryFileSystem.GetFileStreamFactory();
-            Query query = CreateAndExecuteQuery("select * from sys.databases", connInfo, fileStreamFactory);
-            DateTime elapsedTime = Convert.ToDateTime(query.Batches[0].ExecutionElapsedTime);
-            Query mutipleQuery = CreateAndExecuteQuery("select * from sys.databases\r\nGO 15", connInfo, fileStreamFactory);
-            DateTime multipleElapsedTime =  Convert.ToDateTime(mutipleQuery.Batches[0].ExecutionElapsedTime);
-            Assert.True(multipleElapsedTime > elapsedTime);
+            Assert.AreEqual(master, connInfo.ConnectionDetails.DatabaseName);
         }
 
         public static Query CreateAndExecuteQuery(string queryText, ConnectionInfo connectionInfo, IFileStreamFactory fileStreamFactory, bool IsSqlCmd = false)

test/Microsoft.SqlTools.ServiceLayer.IntegrationTests/QueryExecution/SqlCmdExecutionTest.cs

@@ -9,13 +9,13 @@ using Microsoft.SqlTools.ServiceLayer.QueryExecution;
 using Microsoft.SqlTools.ServiceLayer.Test.Common;
 using System;
 using System.IO;
-using Xunit;
+using NUnit.Framework;
 
 namespace Microsoft.SqlTools.ServiceLayer.IntegrationTests.QueryExecution
 {
     public class SqlCmdExecutionTest
     {
-        [Fact]
+        [Test]
         public void TestConnectSqlCmdCommand()
         {
             var fileStreamFactory = MemoryFileSystem.GetFileStreamFactory();
@@ -41,7 +41,7 @@ GO";
             Assert.True(query.Batches[0].HasError, "Query should have error");
         }
 
-        [Fact]
+        [Test]
         public void TestOnErrorSqlCmdCommand()
         {
             var fileStreamFactory = MemoryFileSystem.GetFileStreamFactory();
@@ -73,7 +73,7 @@ GO";
             Assert.False(query.Batches[1].HasExecuted, "last batch should NOT be executed");
         }
 
-        [Fact]
+        [Test]
         public void TestIncludeSqlCmdCommand()
         {
             var fileStreamFactory = MemoryFileSystem.GetFileStreamFactory();