From 87e8eb9ef65eb1c2394fbf26e73c0746fb25eda9 Mon Sep 17 00:00:00 2001 From: Thomas Struller-Baumann Date: Thu, 29 Nov 2018 19:45:58 +0100 Subject: [PATCH] Removed unnecessary IErrorDetectionStrategy (#749) --- .../RetryPolicy.DataTransferDetectionErrorStrategy.cs | 2 +- .../RetryPolicy.NetworkConnectivityErrorStrategy.cs | 2 +- ...olicy.SqlAzureTemporaryAndIgnorableErrorDetectionStrategy.cs | 2 +- .../RetryPolicy.SqlAzureTemporaryErrorDetectionStrategy.cs | 2 +- .../RetryPolicy.DataTransferDetectionErrorStrategy.cs | 2 +- .../RetryPolicy.NetworkConnectivityErrorStrategy.cs | 2 +- ...olicy.SqlAzureTemporaryAndIgnorableErrorDetectionStrategy.cs | 2 +- .../RetryPolicy.SqlAzureTemporaryErrorDetectionStrategy.cs | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/Microsoft.SqlTools.CoreServices/Connection/ReliableConnection/RetryPolicy.DataTransferDetectionErrorStrategy.cs b/src/Microsoft.SqlTools.CoreServices/Connection/ReliableConnection/RetryPolicy.DataTransferDetectionErrorStrategy.cs index c9c562da..b60106d0 100644 --- a/src/Microsoft.SqlTools.CoreServices/Connection/ReliableConnection/RetryPolicy.DataTransferDetectionErrorStrategy.cs +++ b/src/Microsoft.SqlTools.CoreServices/Connection/ReliableConnection/RetryPolicy.DataTransferDetectionErrorStrategy.cs @@ -14,7 +14,7 @@ namespace Microsoft.SqlTools.CoreServices.Connection.ReliableConnection /// /// Provides the error detection logic for temporary faults that are commonly found during data transfer. /// - internal class DataTransferErrorDetectionStrategy : ErrorDetectionStrategyBase, IErrorDetectionStrategy + internal class DataTransferErrorDetectionStrategy : ErrorDetectionStrategyBase { private static readonly DataTransferErrorDetectionStrategy instance = new DataTransferErrorDetectionStrategy(); diff --git a/src/Microsoft.SqlTools.CoreServices/Connection/ReliableConnection/RetryPolicy.NetworkConnectivityErrorStrategy.cs b/src/Microsoft.SqlTools.CoreServices/Connection/ReliableConnection/RetryPolicy.NetworkConnectivityErrorStrategy.cs index 1439405a..2dec9c35 100644 --- a/src/Microsoft.SqlTools.CoreServices/Connection/ReliableConnection/RetryPolicy.NetworkConnectivityErrorStrategy.cs +++ b/src/Microsoft.SqlTools.CoreServices/Connection/ReliableConnection/RetryPolicy.NetworkConnectivityErrorStrategy.cs @@ -13,7 +13,7 @@ namespace Microsoft.SqlTools.CoreServices.Connection.ReliableConnection /// Provides the error detection logic for temporary faults that are commonly found in SQL Azure. /// The same errors CAN occur on premise also, but they are not seen as often. /// - internal sealed class NetworkConnectivityErrorDetectionStrategy : ErrorDetectionStrategyBase, IErrorDetectionStrategy + internal sealed class NetworkConnectivityErrorDetectionStrategy : ErrorDetectionStrategyBase { private static NetworkConnectivityErrorDetectionStrategy instance = new NetworkConnectivityErrorDetectionStrategy(); diff --git a/src/Microsoft.SqlTools.CoreServices/Connection/ReliableConnection/RetryPolicy.SqlAzureTemporaryAndIgnorableErrorDetectionStrategy.cs b/src/Microsoft.SqlTools.CoreServices/Connection/ReliableConnection/RetryPolicy.SqlAzureTemporaryAndIgnorableErrorDetectionStrategy.cs index 26b09015..b4dc9d90 100644 --- a/src/Microsoft.SqlTools.CoreServices/Connection/ReliableConnection/RetryPolicy.SqlAzureTemporaryAndIgnorableErrorDetectionStrategy.cs +++ b/src/Microsoft.SqlTools.CoreServices/Connection/ReliableConnection/RetryPolicy.SqlAzureTemporaryAndIgnorableErrorDetectionStrategy.cs @@ -18,7 +18,7 @@ namespace Microsoft.SqlTools.CoreServices.Connection.ReliableConnection /// want to consider this as passing since the first execution that has timed out (or failed for some other temporary error) /// might have managed to create the object. /// - internal class SqlAzureTemporaryAndIgnorableErrorDetectionStrategy : ErrorDetectionStrategyBase, IErrorDetectionStrategy + internal class SqlAzureTemporaryAndIgnorableErrorDetectionStrategy : ErrorDetectionStrategyBase { /// /// Azure error that can be ignored diff --git a/src/Microsoft.SqlTools.CoreServices/Connection/ReliableConnection/RetryPolicy.SqlAzureTemporaryErrorDetectionStrategy.cs b/src/Microsoft.SqlTools.CoreServices/Connection/ReliableConnection/RetryPolicy.SqlAzureTemporaryErrorDetectionStrategy.cs index fe45e77b..5362034c 100644 --- a/src/Microsoft.SqlTools.CoreServices/Connection/ReliableConnection/RetryPolicy.SqlAzureTemporaryErrorDetectionStrategy.cs +++ b/src/Microsoft.SqlTools.CoreServices/Connection/ReliableConnection/RetryPolicy.SqlAzureTemporaryErrorDetectionStrategy.cs @@ -13,7 +13,7 @@ namespace Microsoft.SqlTools.CoreServices.Connection.ReliableConnection /// Provides the error detection logic for temporary faults that are commonly found in SQL Azure. /// The same errors CAN occur on premise also, but they are not seen as often. /// - internal sealed class SqlAzureTemporaryErrorDetectionStrategy : ErrorDetectionStrategyBase, IErrorDetectionStrategy + internal sealed class SqlAzureTemporaryErrorDetectionStrategy : ErrorDetectionStrategyBase { private static SqlAzureTemporaryErrorDetectionStrategy instance = new SqlAzureTemporaryErrorDetectionStrategy(); diff --git a/src/Microsoft.SqlTools.ServiceLayer/Connection/ReliableConnection/RetryPolicy.DataTransferDetectionErrorStrategy.cs b/src/Microsoft.SqlTools.ServiceLayer/Connection/ReliableConnection/RetryPolicy.DataTransferDetectionErrorStrategy.cs index b271ab9b..5295effd 100644 --- a/src/Microsoft.SqlTools.ServiceLayer/Connection/ReliableConnection/RetryPolicy.DataTransferDetectionErrorStrategy.cs +++ b/src/Microsoft.SqlTools.ServiceLayer/Connection/ReliableConnection/RetryPolicy.DataTransferDetectionErrorStrategy.cs @@ -14,7 +14,7 @@ namespace Microsoft.SqlTools.ServiceLayer.Connection.ReliableConnection /// /// Provides the error detection logic for temporary faults that are commonly found during data transfer. /// - internal class DataTransferErrorDetectionStrategy : ErrorDetectionStrategyBase, IErrorDetectionStrategy + internal class DataTransferErrorDetectionStrategy : ErrorDetectionStrategyBase { private static readonly DataTransferErrorDetectionStrategy instance = new DataTransferErrorDetectionStrategy(); diff --git a/src/Microsoft.SqlTools.ServiceLayer/Connection/ReliableConnection/RetryPolicy.NetworkConnectivityErrorStrategy.cs b/src/Microsoft.SqlTools.ServiceLayer/Connection/ReliableConnection/RetryPolicy.NetworkConnectivityErrorStrategy.cs index 456426d1..bcdd5083 100644 --- a/src/Microsoft.SqlTools.ServiceLayer/Connection/ReliableConnection/RetryPolicy.NetworkConnectivityErrorStrategy.cs +++ b/src/Microsoft.SqlTools.ServiceLayer/Connection/ReliableConnection/RetryPolicy.NetworkConnectivityErrorStrategy.cs @@ -13,7 +13,7 @@ namespace Microsoft.SqlTools.ServiceLayer.Connection.ReliableConnection /// Provides the error detection logic for temporary faults that are commonly found in SQL Azure. /// The same errors CAN occur on premise also, but they are not seen as often. /// - internal sealed class NetworkConnectivityErrorDetectionStrategy : ErrorDetectionStrategyBase, IErrorDetectionStrategy + internal sealed class NetworkConnectivityErrorDetectionStrategy : ErrorDetectionStrategyBase { private static NetworkConnectivityErrorDetectionStrategy instance = new NetworkConnectivityErrorDetectionStrategy(); diff --git a/src/Microsoft.SqlTools.ServiceLayer/Connection/ReliableConnection/RetryPolicy.SqlAzureTemporaryAndIgnorableErrorDetectionStrategy.cs b/src/Microsoft.SqlTools.ServiceLayer/Connection/ReliableConnection/RetryPolicy.SqlAzureTemporaryAndIgnorableErrorDetectionStrategy.cs index e538f88b..65c35b96 100644 --- a/src/Microsoft.SqlTools.ServiceLayer/Connection/ReliableConnection/RetryPolicy.SqlAzureTemporaryAndIgnorableErrorDetectionStrategy.cs +++ b/src/Microsoft.SqlTools.ServiceLayer/Connection/ReliableConnection/RetryPolicy.SqlAzureTemporaryAndIgnorableErrorDetectionStrategy.cs @@ -18,7 +18,7 @@ namespace Microsoft.SqlTools.ServiceLayer.Connection.ReliableConnection /// want to consider this as passing since the first execution that has timed out (or failed for some other temporary error) /// might have managed to create the object. /// - internal class SqlAzureTemporaryAndIgnorableErrorDetectionStrategy : ErrorDetectionStrategyBase, IErrorDetectionStrategy + internal class SqlAzureTemporaryAndIgnorableErrorDetectionStrategy : ErrorDetectionStrategyBase { /// /// Azure error that can be ignored diff --git a/src/Microsoft.SqlTools.ServiceLayer/Connection/ReliableConnection/RetryPolicy.SqlAzureTemporaryErrorDetectionStrategy.cs b/src/Microsoft.SqlTools.ServiceLayer/Connection/ReliableConnection/RetryPolicy.SqlAzureTemporaryErrorDetectionStrategy.cs index 43233e85..bf64b144 100644 --- a/src/Microsoft.SqlTools.ServiceLayer/Connection/ReliableConnection/RetryPolicy.SqlAzureTemporaryErrorDetectionStrategy.cs +++ b/src/Microsoft.SqlTools.ServiceLayer/Connection/ReliableConnection/RetryPolicy.SqlAzureTemporaryErrorDetectionStrategy.cs @@ -13,7 +13,7 @@ namespace Microsoft.SqlTools.ServiceLayer.Connection.ReliableConnection /// Provides the error detection logic for temporary faults that are commonly found in SQL Azure. /// The same errors CAN occur on premise also, but they are not seen as often. /// - internal sealed class SqlAzureTemporaryErrorDetectionStrategy : ErrorDetectionStrategyBase, IErrorDetectionStrategy + internal sealed class SqlAzureTemporaryErrorDetectionStrategy : ErrorDetectionStrategyBase { private static SqlAzureTemporaryErrorDetectionStrategy instance = new SqlAzureTemporaryErrorDetectionStrategy();