ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-01-14 01:25:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Code Coverage: SaveAsExcel Contracts, EditData Initialization (#463)

Browse Source 
* Adding unit tests for save as excel

* Adding unit test for revert cell integration

* Adding unit test for edit session initialization

* Fixing issue where excel file factory wasn't being overridden
This commit is contained in:
Benjamin Russell
2017-09-20 15:09:29 -07:00
committed by GitHub
parent 5cf779fd23
commit 8867bd9059
4 changed files with 262 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Microsoft.SqlTools.ServiceLayer/Connection/ConnectionService.cs
View File

@@ -425,7 +425,7 @@ namespace Microsoft.SqlTools.ServiceLayer.Connection
/// This should be removed once the core issue is resolved and clone works as expected
/// </param>
/// <returns>A DB connection for the connection type requested</returns>
public async Task<DbConnection> GetOrOpenConnection(string ownerUri, string connectionType, bool alwaysPersistSecurity = false)
public virtual async Task<DbConnection> GetOrOpenConnection(string ownerUri, string connectionType, bool alwaysPersistSecurity = false)
{
Validate.IsNotNullOrEmptyString(nameof(ownerUri), ownerUri);
Validate.IsNotNullOrEmptyString(nameof(connectionType), connectionType);