ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-16 18:47:57 -05:00
Code Issues Packages Projects Releases Wiki Activity

send empty response for non-ms sql peekdef calls (#480)

Browse Source
This commit is contained in:
Praveen Barli
2017-10-06 15:32:11 -07:00
committed by GitHub
parent 2c4f2cf6b8
commit 8b86279c3d
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/Microsoft.SqlTools.ServiceLayer/LanguageServices/LanguageService.cs
View File

@@ -381,7 +381,7 @@ namespace Microsoft.SqlTools.ServiceLayer.LanguageServices
{ {
if (definitionResult.IsErrorResult) if (definitionResult.IsErrorResult)
{ {
await requestContext.SendError(definitionResult.Message); await requestContext.SendError(definitionResult.Message);
} }
else else
{ {
@@ -391,12 +391,17 @@ namespace Microsoft.SqlTools.ServiceLayer.LanguageServices
} }
else else
{ {
// Send an empty result so that processing does not hang // Send an empty result so that processing does not hang when peek def service called from non-mssql clients
await requestContext.SendResult(Array.Empty<Location>()); await requestContext.SendResult(Array.Empty<Location>());
} }
DocumentStatusHelper.SendTelemetryEvent(requestContext, CreatePeekTelemetryProps(succeeded, isConnected)); DocumentStatusHelper.SendTelemetryEvent(requestContext, CreatePeekTelemetryProps(succeeded, isConnected));
} }
else
{
// Send an empty result so that processing does not hang
await requestContext.SendResult(Array.Empty<Location>());
}
DocumentStatusHelper.SendStatusChange(requestContext, textDocumentPosition, DocumentStatusHelper.DefinitionRequestCompleted); DocumentStatusHelper.SendStatusChange(requestContext, textDocumentPosition, DocumentStatusHelper.DefinitionRequestCompleted);
} }