ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-15 18:47:43 -05:00
Code Issues Packages Projects Releases Wiki Activity

Adding recommendations to query plan (#1373)

Browse Source 
* Adding recommendations

* Adding raw graph type in execution plan graph contracts

* Fixing function name and concising string formatting

* Converting localized string to a function

* Using better names in contract props
Formatting names in a better way

* Getting rid of unnecessary getter, setters and private props

* Fixing localized strings, comments and imports

* Fixing some contracts

* Fixing csproj formatting

* Fixing var names

* Fixing xml comments
This commit is contained in:
Aasim Khan
2022-01-28 11:35:48 -08:00
committed by GitHub
parent a98c266791
commit 92a7248455
13 changed files with 2167 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/Microsoft.SqlTools.ServiceLayer/Localization/sr.cs
View File

@@ -8925,6 +8925,16 @@ namespace Microsoft.SqlTools.ServiceLayer
return Keys.GetString(Keys.ActualOfEstimated, actual, estimated, percent);
}
public static string MissingIndexFormat(string impact, string queryText)
{
return Keys.GetString(Keys.MissingIndexFormat, impact, queryText);
}
public static string MissingIndexDetailsTitle(string fileName, string impact)
{
return Keys.GetString(Keys.MissingIndexDetailsTitle, fileName, impact);
}
public static string TableNotInitializedException(string tableId)
{
return Keys.GetString(Keys.TableNotInitializedException, tableId);
@@ -12272,6 +12282,12 @@ namespace Microsoft.SqlTools.ServiceLayer
public const string ActualOfEstimated = "ActualOfEstimated";
public const string MissingIndexFormat = "MissingIndexFormat";
public const string MissingIndexDetailsTitle = "MissingIndexDetailsTitle";
public const string TableNotInitializedException = "TableNotInitializedException";

13
src/Microsoft.SqlTools.ServiceLayer/Localization/sr.resx
View File

@@ -4605,6 +4605,19 @@
{1} ({2}%)</value>
<comment>.
Parameters: 0 - actual (string), 1 - estimated (string), 2 - percent (decimal) </comment>
</data>
<data name="MissingIndexFormat" xml:space="preserve">
<value>Missing Index (Impact {0}): {1}</value>
<comment>&quot;Missing Index (Impact {0}): {1}&quot; format string for showplan.
Parameters: 0 - impact (string), 1 - queryText (string) </comment>
</data>
<data name="MissingIndexDetailsTitle" xml:space="preserve">
<value>/*
Missing Index Details from {0}
The Query Processor estimates that implementing the following index could improve the query cost by {1}%.
*/</value>
<comment>title of missing index details.
Parameters: 0 - fileName (string), 1 - impact (string) </comment>
</data>
<data name="TableNotInitializedException" xml:space="preserve">
<value>Initialization is not properly done for table with id &apos;{0}&apos;</value>

5
src/Microsoft.SqlTools.ServiceLayer/Localization/sr.strings
View File

@@ -2219,6 +2219,11 @@ SizeInTeraBytesFormat = {0} TB
OperatorDisplayCost(double cost, int percentage) = {0:0.#######} ({1}%)
#Would like to display actual rows and estimated rows in two lines: <number_actual_rows> of\n <number_estimated_rows> (xx%)
ActualOfEstimated(string actual, string estimated, decimal percent) = {0} of\n{1} ({2}%)
;"Missing Index (Impact {0}): {1}" format string for showplan
MissingIndexFormat(string impact, string queryText) = Missing Index (Impact {0}): {1}
;title of missing index details
MissingIndexDetailsTitle(string fileName, string impact) = /*\r\nMissing Index Details from {0}\r\nThe Query Processor estimates that implementing the following index could improve the query cost by {1}%.\r\n*/
############################################################################
# Table Designer

16
src/Microsoft.SqlTools.ServiceLayer/Localization/sr.xlf
View File

@@ -5742,6 +5742,22 @@
<target state="new">Columns</target>
<note></note>
</trans-unit>
<trans-unit id="MissingIndexFormat">
<source>Missing Index (Impact {0}): {1}</source>
<target state="new">Missing Index (Impact {0}): {1}</target>
<note>"Missing Index (Impact {0}): {1}" format string for showplan</note>
</trans-unit>
<trans-unit id="MissingIndexDetailsTitle">
<source>/*
Missing Index Details from {0}
The Query Processor estimates that implementing the following index could improve the query cost by {1}%.
*/</source>
<target state="new">/*
Missing Index Details from {0}
The Query Processor estimates that implementing the following index could improve the query cost by {1}%.
*/</target>
<note>title of missing index details</note>
</trans-unit>
</body>
</file>
</xliff>