ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-01-13 17:23:02 -05:00
Code Issues Packages Projects Releases Wiki Activity

add logging for export results operations (#2102)

Browse Source 
* add logging

* Update src/Microsoft.SqlTools.ServiceLayer/QueryExecution/ResultSet.cs

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
This commit is contained in:
Alan Ren
2023-06-14 10:40:50 -07:00
committed by GitHub
parent 98ed1534d5
commit a2f6b4b4df
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/Microsoft.SqlTools.ServiceLayer/QueryExecution/ResultSet.cs
View File

@@ -79,7 +79,7 @@ namespace Microsoft.SqlTools.ServiceLayer.QueryExecution
/// <summary> /// <summary>
/// Row count to use in special scenarios where we want to override the number of rows. /// Row count to use in special scenarios where we want to override the number of rows.
/// </summary> /// </summary>
private long? rowCountOverride=null; private long? rowCountOverride = null;
/// <summary> /// <summary>
/// The special action which applied to this result set /// The special action which applied to this result set
@@ -532,12 +532,20 @@ namespace Microsoft.SqlTools.ServiceLayer.QueryExecution
using (var fileReader = fileFactory.GetReader(outputFileName)) using (var fileReader = fileFactory.GetReader(outputFileName))
using (var fileWriter = fileFactory.GetWriter(saveParams.FilePath, Columns)) using (var fileWriter = fileFactory.GetWriter(saveParams.FilePath, Columns))
{ {
Logger.Verbose($"Started exporting {RowCount} rows to file: {outputFileName}");
var recentLogTime = DateTime.Now;
// Iterate over the rows that are in the selected row set // Iterate over the rows that are in the selected row set
for (long i = rowStartIndex; i < rowEndIndex; ++i) for (long i = rowStartIndex; i < rowEndIndex; ++i)
{ {
var row = fileReader.ReadRow(fileOffsets[i], i, Columns); var row = fileReader.ReadRow(fileOffsets[i], i, Columns);
fileWriter.WriteRow(row, Columns); fileWriter.WriteRow(row, Columns);
if (DateTime.Now.Subtract(recentLogTime).TotalSeconds > 1)
{
Logger.Verbose($"Export progress: {i - rowStartIndex + 1}/{RowCount}.");
recentLogTime = DateTime.Now;
}
} }
Logger.Verbose($"Exported {RowCount} rows to file: {outputFileName}");
if (successHandler != null) if (successHandler != null)
{ {
await successHandler(saveParams); await successHandler(saveParams);
@@ -622,7 +630,7 @@ namespace Microsoft.SqlTools.ServiceLayer.QueryExecution
/// Sends the ResultsUpdated message if the number of rows has changed since last send. /// Sends the ResultsUpdated message if the number of rows has changed since last send.
/// </summary> /// </summary>
/// <param name="stateInfo"></param> /// <param name="stateInfo"></param>
private void SendResultAvailableOrUpdated (object stateInfo = null) private void SendResultAvailableOrUpdated(object stateInfo = null)
{ {
// Make the call to send current results and synchronously wait for it to finish // Make the call to send current results and synchronously wait for it to finish
// //
@@ -638,7 +646,7 @@ namespace Microsoft.SqlTools.ServiceLayer.QueryExecution
// //
sendResultsSemphore.Wait(); sendResultsSemphore.Wait();
var currentResultSetSnapshot = (ResultSet) MemberwiseClone(); var currentResultSetSnapshot = (ResultSet)MemberwiseClone();
if (LastUpdatedSummary == null) // We need to send results available message. if (LastUpdatedSummary == null) // We need to send results available message.
{ {
// Fire off results Available task and await it // Fire off results Available task and await it