ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-01-30 09:35:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

add a flag to make message processing parallel (#1482)

Browse Source 
* add a flag to make message processing parallel

* use discard

* add comment
This commit is contained in:
Alan Ren
2022-05-05 14:44:58 -07:00
committed by GitHub
parent b7360ea17f
commit a7e6eca9e3
4 changed files with 51 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
src/Microsoft.SqlTools.Hosting/Hosting/Protocol/MessageDispatcher.cs
View File

@@ -57,6 +57,12 @@ namespace Microsoft.SqlTools.Hosting.Protocol
protected MessageWriter MessageWriter { get; private set; }
/// <summary>
/// Whether the message should be handled without blocking the main thread.
/// </summary>
public bool ParallelMessageProcessing { get; set; }
#endregion
#region Constructors
@@ -305,22 +311,39 @@ namespace Microsoft.SqlTools.Hosting.Protocol
if (handlerToAwait != null)
{
try
if (this.ParallelMessageProcessing)
{
await handlerToAwait;
}
catch (TaskCanceledException)
{
// Some tasks may be cancelled due to legitimate
// timeouts so don't let those exceptions go higher.
}
catch (Exception e)
{
if (!(e is AggregateException && ((AggregateException)e).InnerExceptions[0] is TaskCanceledException))
// Run the task in a separate thread so that the main
// thread is not blocked.
_ = Task.Run(() =>
{
// Log the error but don't rethrow it to prevent any errors in the handler from crashing the service
Logger.Write(TraceEventType.Error, string.Format("An unexpected error occured in the request handler: {0}", e.ToString()));
}
_ = RunTask(handlerToAwait);
});
}
else
{
await RunTask(handlerToAwait);
}
}
}
private async Task RunTask(Task task)
{
try
{
await task;
}
catch (TaskCanceledException)
{
// Some tasks may be cancelled due to legitimate
// timeouts so don't let those exceptions go higher.
}
catch (Exception e)
{
if (!(e is AggregateException && ((AggregateException)e).InnerExceptions[0] is TaskCanceledException))
{
// Log the error but don't rethrow it to prevent any errors in the handler from crashing the service
Logger.Write(TraceEventType.Error, string.Format("An unexpected error occured in the request handler: {0}", e.ToString()));
}
}
}