From b2120269a7112961bcb24f42ff36dd006aac68fc Mon Sep 17 00:00:00 2001
From: Alex Ma <alma1@microsoft.com>
Date: Thu, 21 Sep 2023 14:25:11 -0700
Subject: [PATCH] Added new test framework (test) (#2247)

* Added new test framework (test)

* added nunit import
---
 ...oft.SqlTools.ServiceLayer.PerfTests.csproj |  4 +++-
 .../Tests/ConnectionTests.cs                  |  8 +++----
 .../Tests/IntellisenseTests.cs                | 24 +++++++++----------
 .../Tests/ObjectExplorerTests.cs              | 14 +++++------
 .../Tests/QueryExecutionTests.cs              | 22 ++++++++---------
 .../Tests/SaveResultsTests.cs                 |  6 ++---
 .../Tests/ScriptinTests.cs                    |  6 ++---
 7 files changed, 43 insertions(+), 41 deletions(-)

diff --git a/test/Microsoft.SqlTools.ServiceLayer.PerfTests/Microsoft.SqlTools.ServiceLayer.PerfTests.csproj b/test/Microsoft.SqlTools.ServiceLayer.PerfTests/Microsoft.SqlTools.ServiceLayer.PerfTests.csproj
index 5a2a50ac..b51f35d3 100644
--- a/test/Microsoft.SqlTools.ServiceLayer.PerfTests/Microsoft.SqlTools.ServiceLayer.PerfTests.csproj
+++ b/test/Microsoft.SqlTools.ServiceLayer.PerfTests/Microsoft.SqlTools.ServiceLayer.PerfTests.csproj
@@ -21,7 +21,9 @@
 		<ProjectReference Include="../Microsoft.SqlTools.ServiceLayer.Test.Common/Microsoft.SqlTools.ServiceLayer.Test.Common.csproj" />
 	</ItemGroup>
 	<ItemGroup>
-		<PackageReference Include="xunit" />
+		<PackageReference Include="nunit" />
+		<PackageReference Include="nunit3testadapter" />
+		<PackageReference Include="nunit.console" />
 	</ItemGroup>
 	<ItemGroup>
 		<Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />
diff --git a/test/Microsoft.SqlTools.ServiceLayer.PerfTests/Tests/ConnectionTests.cs b/test/Microsoft.SqlTools.ServiceLayer.PerfTests/Tests/ConnectionTests.cs
index fdba32fc..8094f4b0 100644
--- a/test/Microsoft.SqlTools.ServiceLayer.PerfTests/Tests/ConnectionTests.cs
+++ b/test/Microsoft.SqlTools.ServiceLayer.PerfTests/Tests/ConnectionTests.cs
@@ -9,14 +9,14 @@ using System.Threading;
 using System.Threading.Tasks;
 using Microsoft.SqlTools.ServiceLayer.Test.Common;
 using Microsoft.SqlTools.ServiceLayer.Workspace.Contracts;
-using Xunit;
+using NUnit.Framework;
 
 namespace Microsoft.SqlTools.ServiceLayer.PerfTests
 {
     public class ConnectionTests
     {
 
-        [Fact]
+        [Test]
         [CreateTestDb(TestServerType.Azure)]
         public async Task ConnectAzureTest()
         {
@@ -53,7 +53,7 @@ namespace Microsoft.SqlTools.ServiceLayer.PerfTests
             });
         }
 
-        [Fact]
+        [Test]
         [CreateTestDb(TestServerType.OnPrem)]
         public async Task ConnectOnPremTest()
         {
@@ -91,7 +91,7 @@ namespace Microsoft.SqlTools.ServiceLayer.PerfTests
             });
         }
 
-        [Fact]
+        [Test]
         [CreateTestDb(TestServerType.OnPrem)]
         public async Task DisconnectTest()
         {
diff --git a/test/Microsoft.SqlTools.ServiceLayer.PerfTests/Tests/IntellisenseTests.cs b/test/Microsoft.SqlTools.ServiceLayer.PerfTests/Tests/IntellisenseTests.cs
index c141163a..b0cb02ac 100644
--- a/test/Microsoft.SqlTools.ServiceLayer.PerfTests/Tests/IntellisenseTests.cs
+++ b/test/Microsoft.SqlTools.ServiceLayer.PerfTests/Tests/IntellisenseTests.cs
@@ -13,14 +13,14 @@ using System.Threading.Tasks;
 using Microsoft.SqlTools.ServiceLayer.LanguageServices.Contracts;
 using Microsoft.SqlTools.ServiceLayer.Test.Common;
 using Microsoft.SqlTools.ServiceLayer.Workspace.Contracts;
-using Xunit;
+using NUnit.Framework;
 using Range = Microsoft.SqlTools.ServiceLayer.Workspace.Contracts.Range;
 
 namespace Microsoft.SqlTools.ServiceLayer.PerfTests
 {
     public class IntellisenseTests
     {
-        [Fact]
+        [Test]
         [CreateTestDb(TestServerType.OnPrem)]
         public async Task HoverTestOnPrem()
         {
@@ -40,7 +40,7 @@ namespace Microsoft.SqlTools.ServiceLayer.PerfTests
             });
         }
 
-        [Fact]
+        [Test]
         [CreateTestDb(TestServerType.OnPrem)]
         public async Task SuggestionsTest()
         {
@@ -59,7 +59,7 @@ namespace Microsoft.SqlTools.ServiceLayer.PerfTests
             });
         }
 
-        [Fact]
+        [Test]
         [CreateTestDb(TestServerType.OnPrem)]
         public async Task DiagnosticsTests()
         {
@@ -114,7 +114,7 @@ namespace Microsoft.SqlTools.ServiceLayer.PerfTests
             });
         }
 
-        [Fact]
+        [Test]
         [CreateTestDb(TestServerType.Azure)]
         public async Task BindingCacheColdAzureSimpleQuery()
         {
@@ -128,7 +128,7 @@ namespace Microsoft.SqlTools.ServiceLayer.PerfTests
             });
         }
 
-        [Fact]
+        [Test]
         [CreateTestDb(TestServerType.OnPrem)]
         public async Task BindingCacheColdOnPremSimpleQuery()
         {
@@ -143,7 +143,7 @@ namespace Microsoft.SqlTools.ServiceLayer.PerfTests
             
         }
 
-        [Fact]
+        [Test]
         [CreateTestDb(TestServerType.Azure)]
         public async Task BindingCacheWarmAzureSimpleQuery()
         {
@@ -159,7 +159,7 @@ namespace Microsoft.SqlTools.ServiceLayer.PerfTests
             });
         }
 
-        [Fact]
+        [Test]
         [CreateTestDb(TestServerType.OnPrem)]
         public async Task BindingCacheWarmOnPremSimpleQuery()
         {
@@ -176,7 +176,7 @@ namespace Microsoft.SqlTools.ServiceLayer.PerfTests
             });
         }
 
-        [Fact]
+        [Test]
         [CreateTestDb(TestServerType.Azure)]
         public async Task BindingCacheColdAzureComplexQuery()
         {
@@ -191,7 +191,7 @@ namespace Microsoft.SqlTools.ServiceLayer.PerfTests
             });
         }
 
-        [Fact]
+        [Test]
         [CreateTestDb(TestServerType.OnPrem)]
         public async Task BindingCacheColdOnPremComplexQuery()
         {
@@ -205,7 +205,7 @@ namespace Microsoft.SqlTools.ServiceLayer.PerfTests
             });
         }
 
-        [Fact]
+        [Test]
         [CreateTestDb(TestServerType.Azure)]
         public async Task BindingCacheWarmAzureComplexQuery()
         {
@@ -221,7 +221,7 @@ namespace Microsoft.SqlTools.ServiceLayer.PerfTests
             });
         }
 
-        [Fact]
+        [Test]
         [CreateTestDb(TestServerType.OnPrem)]
         public async Task BindingCacheWarmOnPremComplexQuery()
         {
diff --git a/test/Microsoft.SqlTools.ServiceLayer.PerfTests/Tests/ObjectExplorerTests.cs b/test/Microsoft.SqlTools.ServiceLayer.PerfTests/Tests/ObjectExplorerTests.cs
index 495bf683..b59a971f 100644
--- a/test/Microsoft.SqlTools.ServiceLayer.PerfTests/Tests/ObjectExplorerTests.cs
+++ b/test/Microsoft.SqlTools.ServiceLayer.PerfTests/Tests/ObjectExplorerTests.cs
@@ -11,13 +11,13 @@ using System.Threading.Tasks;
 using Microsoft.SqlTools.ServiceLayer.Connection.Contracts;
 using Microsoft.SqlTools.ServiceLayer.ObjectExplorer.Contracts;
 using Microsoft.SqlTools.ServiceLayer.Test.Common;
-using Xunit;
+using NUnit.Framework;
 
 namespace Microsoft.SqlTools.ServiceLayer.PerfTests
 {
     public class ObjectExplorerTests
     {
-        [Fact]
+        [Test]
         [CreateTestDb(TestServerType.Azure)]
         public async Task CreateSessionAzure()
         {
@@ -25,7 +25,7 @@ namespace Microsoft.SqlTools.ServiceLayer.PerfTests
             await VerifyCreateSession(serverType);
         }
 
-        [Fact]
+        [Test]
         [CreateTestDb(TestServerType.OnPrem)]
         public async Task CreateSessionOnPrem()
         {
@@ -33,7 +33,7 @@ namespace Microsoft.SqlTools.ServiceLayer.PerfTests
             await VerifyCreateSession(serverType);
         }
 
-        [Fact]
+        [Test]
         [CreateTestDb(TestServerType.OnPrem)]
         public async Task ExpandDatabasesOnPrem()
         {
@@ -41,7 +41,7 @@ namespace Microsoft.SqlTools.ServiceLayer.PerfTests
             await VerifyExpand(serverType, SqlTestDb.MasterDatabaseName);
         }
 
-        [Fact]
+        [Test]
         [CreateTestDb(TestServerType.OnPrem)]
         public async Task ExpandOneDatabaseOnPrem()
         {
@@ -49,7 +49,7 @@ namespace Microsoft.SqlTools.ServiceLayer.PerfTests
             await VerifyExpand(serverType, Common.PerfTestDatabaseName);
         }
 
-        [Fact]
+        [Test]
         [CreateTestDb(TestServerType.Azure)]
         public async Task ExpandDatabasesAzure()
         {
@@ -57,7 +57,7 @@ namespace Microsoft.SqlTools.ServiceLayer.PerfTests
             await VerifyExpand(serverType, SqlTestDb.MasterDatabaseName);
         }
 
-        [Fact]
+        [Test]
         [CreateTestDb(TestServerType.Azure)]
         public async Task ExpandOneDatabaseAzure()
         {
diff --git a/test/Microsoft.SqlTools.ServiceLayer.PerfTests/Tests/QueryExecutionTests.cs b/test/Microsoft.SqlTools.ServiceLayer.PerfTests/Tests/QueryExecutionTests.cs
index 5ac2d3a3..c2bf81b3 100644
--- a/test/Microsoft.SqlTools.ServiceLayer.PerfTests/Tests/QueryExecutionTests.cs
+++ b/test/Microsoft.SqlTools.ServiceLayer.PerfTests/Tests/QueryExecutionTests.cs
@@ -11,61 +11,61 @@ using System.Runtime.CompilerServices;
 using System.Threading.Tasks;
 using Microsoft.SqlTools.ServiceLayer.QueryExecution.Contracts.ExecuteRequests;
 using Microsoft.SqlTools.ServiceLayer.Test.Common;
-using Xunit;
+using NUnit.Framework;
 
 namespace Microsoft.SqlTools.ServiceLayer.PerfTests
 {
     public class QueryExecutionTests
     {
-        [Fact]
+        [Test]
         public async Task QueryResultSummaryOnPremTest()
         {
             await QueryResultSummaryOnPremTestCore(TestServerType.OnPrem, Scripts.MasterBasicQuery);
         }
 
-        [Fact]
+        [Test]
         public async Task QueryResultFirstOnPremTest()
         {
             await QueryResultFirstOnPremTestCore(TestServerType.OnPrem, Scripts.MasterBasicQuery);
         }
 
-        [Fact]
+        [Test]
         public async Task LongQueryResultSummaryOnPremTest()
         {
             await QueryResultSummaryOnPremTestCore(TestServerType.OnPrem, Scripts.MasterLongQuery);
         }
 
-        [Fact]
+        [Test]
         public async Task LongQueryResultFirstOnPremTest()
         {
             await QueryResultFirstOnPremTestCore(TestServerType.OnPrem, Scripts.MasterLongQuery);
         }
 
-        [Fact]
+        [Test]
         public async Task QueryResultSummaryOnAzureTest()
         {
             await QueryResultSummaryOnPremTestCore(TestServerType.Azure, Scripts.MasterBasicQuery);
         }
 
-        [Fact]
+        [Test]
         public async Task QueryResultFirstOnAzureTest()
         {
             await QueryResultFirstOnPremTestCore(TestServerType.Azure, Scripts.MasterBasicQuery);
         }
 
-        [Fact]
+        [Test]
         public async Task LongQueryResultSummaryOnAzureTest()
         {
             await QueryResultSummaryOnPremTestCore(TestServerType.Azure, Scripts.MasterLongQuery);
         }
 
-        [Fact]
+        [Test]
         public async Task LongQueryResultFirstOnAzureTest()
         {
             await QueryResultFirstOnPremTestCore(TestServerType.Azure, Scripts.MasterLongQuery);
         }
 
-        [Fact]
+        [Test]
         [CreateTestDb(TestServerType.OnPrem)]
         public async Task CancelQueryOnPremTest()
         {
@@ -96,7 +96,7 @@ namespace Microsoft.SqlTools.ServiceLayer.PerfTests
                     }
                     else
                     {
-                        Assert.True(false, "Failed to run the query");
+                        Assert.Fail("Failed to run the query");
 
                         await testService.Disconnect(queryTempFile.FilePath);
                     }
diff --git a/test/Microsoft.SqlTools.ServiceLayer.PerfTests/Tests/SaveResultsTests.cs b/test/Microsoft.SqlTools.ServiceLayer.PerfTests/Tests/SaveResultsTests.cs
index c86cfad9..cf55158b 100644
--- a/test/Microsoft.SqlTools.ServiceLayer.PerfTests/Tests/SaveResultsTests.cs
+++ b/test/Microsoft.SqlTools.ServiceLayer.PerfTests/Tests/SaveResultsTests.cs
@@ -7,13 +7,13 @@
 
 using System.Threading.Tasks;
 using Microsoft.SqlTools.ServiceLayer.Test.Common;
-using Xunit;
+using NUnit.Framework;
 
 namespace Microsoft.SqlTools.ServiceLayer.PerfTests
 {
     public class SaveResultsTests
     {
-        [Fact]
+        [Test]
         public async Task TestSaveResultsToCsvTest()
         {
             await TestServiceDriverProvider.RunTestIterations(async (timer) =>
@@ -35,7 +35,7 @@ namespace Microsoft.SqlTools.ServiceLayer.PerfTests
             });
         }
 
-        [Fact]
+        [Test]
         public async Task TestSaveResultsToJsonTest()
         {
             await TestServiceDriverProvider.RunTestIterations(async (timer) =>
diff --git a/test/Microsoft.SqlTools.ServiceLayer.PerfTests/Tests/ScriptinTests.cs b/test/Microsoft.SqlTools.ServiceLayer.PerfTests/Tests/ScriptinTests.cs
index 463d8ee0..be4a09ee 100644
--- a/test/Microsoft.SqlTools.ServiceLayer.PerfTests/Tests/ScriptinTests.cs
+++ b/test/Microsoft.SqlTools.ServiceLayer.PerfTests/Tests/ScriptinTests.cs
@@ -11,13 +11,13 @@ using System.Threading.Tasks;
 using Microsoft.SqlTools.ServiceLayer.Test.Common;
 using Microsoft.SqlTools.SqlCore.Scripting;
 using Microsoft.SqlTools.SqlCore.Scripting.Contracts;
-using Xunit;
+using NUnit.Framework;
 
 namespace Microsoft.SqlTools.ServiceLayer.PerfTests
 {
     public class ScriptingTests
     {
-        [Fact]
+        [Test]
         [CreateTestDb(TestServerType.Azure)]
         public async Task ScripTableAzure()
         {
@@ -25,7 +25,7 @@ namespace Microsoft.SqlTools.ServiceLayer.PerfTests
             await VerifyScriptTable(serverType);
         }
 
-        [Fact]
+        [Test]
         [CreateTestDb(TestServerType.OnPrem)]
         public async Task ScripTableOnPrem()
         {