Fix issues in file browser service (#469)

* fix file browser service bug

* modify filebrowser service

* change filebrowser contract

* fix contract

* fix file browser add/expand event contracts

* remove commented code

src/Microsoft.SqlTools.ServiceLayer/FileBrowser/Contracts/FileBrowserExpandedNotification.cs

@@ -9,8 +9,13 @@ namespace Microsoft.SqlTools.ServiceLayer.FileBrowser.Contracts
     /// <summary>
     /// Event params for expanding a node
     /// </summary>
-    public class FileBrowserExpandCompleteParams
+    public class FileBrowserExpandedParams
     {
+        /// <summary>
+        /// Connection uri
+        /// </summary>
+        public string OwnerUri;
+
         /// <summary>
         /// Expanded node 
         /// </summary>
@@ -30,11 +35,11 @@ namespace Microsoft.SqlTools.ServiceLayer.FileBrowser.Contracts
     /// <summary>
     /// Notification for expand completion
     /// </summary>
-    public class FileBrowserExpandCompleteNotification
+    public class FileBrowserExpandedNotification
     {
         public static readonly
-            EventType<FileBrowserExpandCompleteParams> Type =
-            EventType<FileBrowserExpandCompleteParams>.Create("filebrowser/expandcomplete");
+            EventType<FileBrowserExpandedParams> Type =
+            EventType<FileBrowserExpandedParams>.Create("filebrowser/expandcomplete");
     }
 
 }

src/Microsoft.SqlTools.ServiceLayer/FileBrowser/Contracts/FileBrowserOpenedNotification.cs

@@ -11,8 +11,13 @@ namespace Microsoft.SqlTools.ServiceLayer.FileBrowser.Contracts
     /// Event params for opening a file browser
     /// Returns full directory structure on the server side
     /// </summary>
-    public class FileBrowserOpenCompleteParams
+    public class FileBrowserOpenedParams
     {
+        /// <summary>
+        /// Connection uri
+        /// </summary>
+        public string OwnerUri;
+
         /// <summary>
         /// Entire file/folder tree 
         /// </summary>
@@ -32,11 +37,11 @@ namespace Microsoft.SqlTools.ServiceLayer.FileBrowser.Contracts
     /// <summary>
     /// Notification for completing file browser opening
     /// </summary>
-    public class FileBrowserOpenCompleteNotification
+    public class FileBrowserOpenedNotification
     {
         public static readonly
-            EventType<FileBrowserOpenCompleteParams> Type =
-            EventType<FileBrowserOpenCompleteParams>.Create("filebrowser/opencomplete");
+            EventType<FileBrowserOpenedParams> Type =
+            EventType<FileBrowserOpenedParams>.Create("filebrowser/opencomplete");
     }
 
 }

src/Microsoft.SqlTools.ServiceLayer/FileBrowser/Contracts/FileBrowserValidatedNotification.cs

@@ -9,7 +9,7 @@ namespace Microsoft.SqlTools.ServiceLayer.FileBrowser.Contracts
     /// <summary>
     /// Event params for validation completion
     /// </summary>
-    public class FileBrowserValidateCompleteParams
+    public class FileBrowserValidatedParams
     {
         /// <summary>
         /// Result of the operation
@@ -25,11 +25,11 @@ namespace Microsoft.SqlTools.ServiceLayer.FileBrowser.Contracts
     /// <summary>
     /// Notification for validation completion
     /// </summary>
-    public class FileBrowserValidateCompleteNotification
+    public class FileBrowserValidatedNotification
     {
         public static readonly
-            EventType<FileBrowserValidateCompleteParams> Type =
-            EventType<FileBrowserValidateCompleteParams>.Create("filebrowser/validatecomplete");
+            EventType<FileBrowserValidatedParams> Type =
+            EventType<FileBrowserValidatedParams>.Create("filebrowser/validatecomplete");
     }
 
 }

src/Microsoft.SqlTools.ServiceLayer/FileBrowser/Contracts/FileTreeNode.cs

@@ -20,11 +20,6 @@ namespace Microsoft.SqlTools.ServiceLayer.FileBrowser.Contracts
             this.Children = new List<FileTreeNode>();
         }
 
-        /// <summary>
-        /// Parent node
-        /// </summary>
-        public FileTreeNode Parent { get; private set; }
-
         /// <summary>
         /// List of children nodes
         /// </summary>
@@ -48,7 +43,6 @@ namespace Microsoft.SqlTools.ServiceLayer.FileBrowser.Contracts
 
         public void AddChildNode(FileTreeNode item)
         {
-            item.Parent = this;
             this.Children.Add(item);
         }
     }