ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-14 18:47:44 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fixing a handful of warnings that showed up since the upgrade to .NET Core 2 (#411)

Browse Source
This commit is contained in:
Benjamin Russell
2017-07-14 09:53:26 -07:00
committed by GitHub
parent cfa78bbc3b
commit b49fa89be9
5 changed files with 7 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Microsoft.SqlTools.Hosting/Hosting/IHostedService.cs
View File

@@ -67,13 +67,13 @@ namespace Microsoft.SqlTools.Hosting
}
}
protected async Task<T> HandleRequestAsync<T>(Func<Task<T>> handler, RequestContext<T> requestContext, string requestType)
protected async Task<THandler> HandleRequestAsync<THandler>(Func<Task<THandler>> handler, RequestContext<THandler> requestContext, string requestType)
{
Logger.Write(LogLevel.Verbose, requestType);
try
{
T result = await handler();
THandler result = await handler();
await requestContext.SendResult(result);
return result;
}
@@ -81,7 +81,7 @@ namespace Microsoft.SqlTools.Hosting
{
await requestContext.SendError(ex.ToString());
}
return default(T);
return default(THandler);
}
public abstract void InitializeService(IProtocolEndpoint serviceHost);

2
src/Microsoft.SqlTools.Hosting/Hosting/ServiceHostBase.cs
View File

@@ -12,7 +12,6 @@ namespace Microsoft.SqlTools.Hosting
{
public abstract class ServiceHostBase : ProtocolEndpoint
{
private bool isStarted;
private TaskCompletionSource<bool> serverExitedTask;
protected ServiceHostBase(ChannelBase serverChannel) :
@@ -25,6 +24,7 @@ namespace Microsoft.SqlTools.Hosting
// Register handlers for server lifetime messages
this.SetEventHandler(ExitNotification.Type, this.HandleExitNotification);
this.serverExitedTask = new TaskCompletionSource<bool>();
return Task.FromResult(true);
}