From b71f4fec27f5205293972203ec17ed1f1d631f87 Mon Sep 17 00:00:00 2001 From: Aditya Bist Date: Tue, 26 Jun 2018 19:11:18 -0700 Subject: [PATCH] Feature/new step (#645) * added support for t-sql parse * added syntax parse to language service instead * fixed misleading error * code review comments * fixed run state logic --- .../Agent/Common/AgentUtilities.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Microsoft.SqlTools.ServiceLayer/Agent/Common/AgentUtilities.cs b/src/Microsoft.SqlTools.ServiceLayer/Agent/Common/AgentUtilities.cs index acf9343b..10008fe7 100644 --- a/src/Microsoft.SqlTools.ServiceLayer/Agent/Common/AgentUtilities.cs +++ b/src/Microsoft.SqlTools.ServiceLayer/Agent/Common/AgentUtilities.cs @@ -63,7 +63,7 @@ namespace Microsoft.SqlTools.ServiceLayer.Agent string stepName = entry.StepName; string message = entry.Message; DateTime runDate = logEntry.PointInTime; - int runStatus = Convert.ToInt32(jobRow[UrnRunStatus], System.Globalization.CultureInfo.InvariantCulture); + int runStatus = logEntry.Severity == SeverityClass.Success ? 1 : 0; AgentJobStep step = new AgentJobStep(); step.StepId = stepId; step.StepName = stepName; @@ -82,9 +82,9 @@ namespace Microsoft.SqlTools.ServiceLayer.Agent // Make a new AgentJobHistoryInfo object var jobHistoryInfo = new AgentJobHistoryInfo(); jobHistoryInfo.InstanceId = Convert.ToInt32(jobRow[UrnInstanceID], System.Globalization.CultureInfo.InvariantCulture); - jobHistoryInfo.RunStatus = Convert.ToInt32(jobRow[UrnRunStatus], System.Globalization.CultureInfo.InvariantCulture); jobHistoryInfo.JobId = (Guid) jobRow[UrnJobId]; var logEntry = entry as LogSourceJobHistory.LogEntryJobHistory; + jobHistoryInfo.RunStatus = entry.Severity == SeverityClass.Error ? 0 : 1; jobHistoryInfo.SqlMessageId = logEntry.SqlMessageID; jobHistoryInfo.Message = logEntry.Message; jobHistoryInfo.StepId = logEntry.StepID;