ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-08 17:25:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

Error on unused private properties (#2008)

Browse Source 
* Error on unused private properties

* Remove nullable

* Delete some commented out code

* Fix compile
This commit is contained in:
Charles Gagnon
2023-04-17 13:27:13 -07:00
committed by GitHub
parent efc8d8f0be
commit c15108808f
8 changed files with 399 additions and 988 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Microsoft.SqlTools.ServiceLayer/ExecutionPlan/ShowPlan/Node.cs
View File

@@ -394,7 +394,7 @@ namespace Microsoft.SqlTools.ServiceLayer.ExecutionPlan.ShowPlan
/// <param name="nodeToCompare"></param>
/// <param name="ignoreDatabaseName"></param>
/// <returns></returns>
///
///
public bool IsLogicallyEquivalentTo(Node nodeToCompare, bool ignoreDatabaseName)
{
// same exact node
@@ -416,7 +416,7 @@ namespace Microsoft.SqlTools.ServiceLayer.ExecutionPlan.ShowPlan
ExpandableObjectWrapper objectProp1 = (ExpandableObjectWrapper)this[objectProperty];
ExpandableObjectWrapper objectProp2 = (ExpandableObjectWrapper)nodeToCompare[objectProperty];
// object property doesn't match
// by default, we ignore DB name
// by default, we ignore DB name
// for ex: "[master].[sys].[sysobjvalues].[clst] [e]" and "[master_copy].[sys].[sysobjvalues].[clst] [e]" would be same
if (ignoreDatabaseName)
{
@@ -742,8 +742,6 @@ namespace Microsoft.SqlTools.ServiceLayer.ExecutionPlan.ShowPlan
private ShowPlanGraph graph;
private Edge parentEdge;
private List<Edge> childrenEdges;
private string nodeType;
private Node root;
/// <summary>

4
src/Microsoft.SqlTools.ServiceLayer/ExecutionPlan/ShowPlan/Operation.cs
View File

@@ -30,7 +30,7 @@ namespace Microsoft.SqlTools.ServiceLayer.ExecutionPlan.ShowPlan
}
/// <summary>
///
///
/// </summary>
/// <param name="name">Operator name</param>
/// <param name="displayNameKey">Display name resource ID</param>
@@ -118,8 +118,6 @@ namespace Microsoft.SqlTools.ServiceLayer.ExecutionPlan.ShowPlan
private string displayNameKey;
private string descriptionKey;
private string imageName;
private string helpKeyword;
private Type displayNodeType;
private string image;
private string displayName;