ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-16 18:47:57 -05:00
Code Issues Packages Projects Releases Wiki Activity

Removed catch block around ExecuteQueryAsync to allow exception to bubble up and be returned to ADS. (#1169)

Browse Source
This commit is contained in:
Justin M
2021-03-04 11:12:21 -08:00
committed by GitHub
parent fa2f5039e2
commit c204cd7848
1 changed files with 8 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/Microsoft.Kusto.ServiceLayer/DataSource/KustoClient.cs
View File

@@ -198,21 +198,17 @@ namespace Microsoft.Kusto.ServiceLayer.DataSource
/// Executes a query. /// Executes a query.
/// </summary> /// </summary>
/// <param name="query">The query.</param> /// <param name="query">The query.</param>
/// <param name="cancellationToken"></param>
/// <param name="databaseName"></param>
/// <returns>The results.</returns> /// <returns>The results.</returns>
public async Task<IEnumerable<T>> ExecuteQueryAsync<T>(string query, CancellationToken cancellationToken, string databaseName = null) public async Task<IEnumerable<T>> ExecuteQueryAsync<T>(string query, CancellationToken cancellationToken,
{ string databaseName = null)
try
{ {
var resultReader = ExecuteQuery(query, cancellationToken, databaseName); var resultReader = ExecuteQuery(query, cancellationToken, databaseName);
var results = KustoDataReaderParser.ParseV1(resultReader, null); var results = KustoDataReaderParser.ParseV1(resultReader, null);
var tableReader = results[WellKnownDataSet.PrimaryResult].Single().TableData.CreateDataReader(); var tableReader = results[WellKnownDataSet.PrimaryResult].Single().TableData.CreateDataReader();
return await Task.FromResult(new ObjectReader<T>(tableReader)); return await Task.FromResult(new ObjectReader<T>(tableReader));
} }
catch (Exception)
{
return null;
}
}
private void CancelQuery(string clientRequestId) private void CancelQuery(string clientRequestId)
{ {