ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-01-14 17:23:27 -05:00
Code Issues Packages Projects Releases Wiki Activity

Small tweaks to query execution

Browse Source 
* Adding comments where missing
* Adding "# rows affected" only if there was 0 or more
This commit is contained in:
Benjamin Russell
2016-08-11 17:41:18 -07:00
parent 9890e828bd
commit c596a0db7a
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/Microsoft.SqlTools.ServiceLayer/QueryExecution/Query.cs
View File

@@ -34,6 +34,9 @@ namespace Microsoft.SqlTools.ServiceLayer.QueryExecution
/// </summary>
public ConnectionInfo EditorConnection { get; set; }
/// <summary>
/// Whether or not the query has an error
/// </summary>
public bool HasError { get; set; }
/// <summary>
@@ -120,7 +123,6 @@ namespace Microsoft.SqlTools.ServiceLayer.QueryExecution
using (conn = EditorConnection.Factory.CreateSqlConnection(connectionString))
{
// If we have the message listener, bind to it
// TODO: This doesn't allow testing via mocking
SqlConnection sqlConn = conn as SqlConnection;
if (sqlConn != null)
{
@@ -141,7 +143,10 @@ namespace Microsoft.SqlTools.ServiceLayer.QueryExecution
do
{
// Create a message with the number of affected rows
ResultMessages.Add(String.Format("({0} row(s) affected)", reader.RecordsAffected));
if (reader.RecordsAffected >= 0)
{
ResultMessages.Add(String.Format("({0} row(s) affected)", reader.RecordsAffected));
}
if (!reader.HasRows && reader.FieldCount == 0)
{