Feat/notebookendpoints (#862)

* Added endpoint for fetching all notebook jobs

* Refractored NotebookJobInfo to AgentNotebookInfo to make it more consistent with the rest of the codebase

* Added Notebook History endpoint in contracts.

* Added Create, Update, Delete notebook endpoints. Also added separate fetch template, materialized notebook endpoints. This will make the Notebook Request and Notebook History responses lighter.

* AgentNotebookInfo is now derived from AgentJobInfo

* added fetch noteook history endpoint

* Added fetching materialized notebook endpoint

* Added code for cleaning up the directory

* Added create notebook api

* Added Update and delete notebook job

* Fixed notebook history API

* Added last run info to the script and template folder

* Added execute database feature for notebook Jobs

* SQL commands are now using sqlparameters to prevent
any injection attacks

* Changed rundate and runtime to string to preserve
leading zeros

* integration test for agentnotebooks api

* Made some changes mentioned in PR

* Refactored the code, removed enpoint logic from the notebook handler and
wrote test cases

* changes select statements, fixed a bug in the test job cleanup
and fixed other stuff mentioned in the PR.

* added notebook_error column in notebook history select statement

* Added get template notebook endpoint

* Added renaming and pinning notebook runs

* made tables names caps to handle servers with case sensitive queries

* made some changes to the enpoint points paths

* Added delete materialized notebooks endpoints

* Fixed a bug in delete, rename and pin apis where
requests from multiple clients with materializedID = 0
could have resulted in multiple rows getting created
on notebooks.nb_materialized table.

* fixed a merge conflict

* Made some changes mentioned in the PR

* modified a query to handle space sensitive databases

* Made some changes mentioned in the PR

* fixed a small query bug
This commit is contained in:
Aasim Khan
2019-09-06 16:54:37 -07:00
committed by GitHub
parent 1d1eb00b3b
commit c6631cf67c
3 changed files with 15 additions and 18 deletions

View File

@@ -199,8 +199,6 @@ namespace Microsoft.SqlTools.ServiceLayer.Agent
connInfo,
notebook.JobId,
notebook.TargetDatabase);
}
internal static async Task UpdateNotebook(
@@ -241,7 +239,6 @@ namespace Microsoft.SqlTools.ServiceLayer.Agent
templatePath,
notebook.ExecuteDatabase,
notebook.TargetDatabase);
}
/// <summary>
@@ -269,7 +266,7 @@ namespace Microsoft.SqlTools.ServiceLayer.Agent
is_deleted
FROM
notebooks.nb_materialized
WHERE JOB_ID = @jobId";
WHERE job_id = @jobId";
List<SqlParameter> getNotebookHistoryQueryParams = new List<SqlParameter>();
getNotebookHistoryQueryParams.Add(new SqlParameter("jobId", JobId));
DataSet notebookHistoriesDataSet =
@@ -672,7 +669,7 @@ namespace Microsoft.SqlTools.ServiceLayer.Agent
UPDATE notebooks.nb_materialized
SET is_deleted = 1,
notebook = '',
notebook_error = '',
notebook_error = ''
WHERE
job_id = @jobId AND run_time = @startTime AND run_date = @startDate
END