ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

[SQL Migration] Show correct recommendation when viewing issues in assessment results (#1441)

Browse Source
This commit is contained in:
Raymond Truong
2022-03-23 17:17:44 -07:00
committed by GitHub
parent 553b9af36e
commit c8ba317980
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/Microsoft.SqlTools.ServiceLayer/Migration/MigrationService.cs
View File

@@ -504,21 +504,22 @@ namespace Microsoft.SqlTools.ServiceLayer.Migration
{ {
return assessmentResults.Select(r => return assessmentResults.Select(r =>
{ {
var check = (Microsoft.SqlServer.Management.Assessment.Checks.Check)r.Check;
return new MigrationAssessmentInfo() return new MigrationAssessmentInfo()
{ {
CheckId = r.Check.Id, CheckId = check.Id,
Description = r.Check.Description, Description = check.Description,
DisplayName = r.Check.DisplayName, DisplayName = r.Message,
HelpLink = r.Check.HelpLink, HelpLink = check.HelpLink,
Level = r.Check.Level.ToString(), Level = check.Level.ToString(),
TargetType = r.TargetType.ToString(), TargetType = r.TargetType.ToString(),
DatabaseName = r.DatabaseName, DatabaseName = r.DatabaseName,
ServerName = r.ServerName, ServerName = r.ServerName,
Tags = r.Check.Tags.ToArray(), Tags = check.Tags.ToArray(),
RulesetName = Engine.Configuration.DefaultRuleset.Name, RulesetName = Engine.Configuration.DefaultRuleset.Name,
RulesetVersion = Engine.Configuration.DefaultRuleset.Version.ToString(), RulesetVersion = Engine.Configuration.DefaultRuleset.Version.ToString(),
RuleId = r.FeatureId.ToString(), RuleId = r.FeatureId.ToString(),
Message = r.Message, Message = check.Message,
AppliesToMigrationTargetPlatform = r.AppliesToMigrationTargetPlatform.ToString(), AppliesToMigrationTargetPlatform = r.AppliesToMigrationTargetPlatform.ToString(),
IssueCategory = r.IssueCategory.ToString(), IssueCategory = r.IssueCategory.ToString(),
ImpactedObjects = ParseImpactedObjects(r.ImpactedObjects), ImpactedObjects = ParseImpactedObjects(r.ImpactedObjects),