3278 Kusto Unit Tests - Part 2 (#1063)

* 3278 Added unit tests in MetadataFactoryTests and Microsoft.Kusto.ServiceLayer.UnitTests project

* 3278 Removed todo and changed unit test to validate megabytes

* 3278 Added file and unit tests in AutoCompleteHelperTests.cs

* 3278 Removed unused functions from Kusto > ScriptAsScriptingOperation

* 3278 Added unit tests for DataSourceFactory

* 3278 Refactored AdminService to pass in ConnectionService rather than through instance variable. Added unit test for AdminServiceTests

* 3278 Refactored DataSourceFactory to not have static functions for future unit tests

* 3278 Re-added properties that were flagged as unused but are being used by ADS in ReliableDataSourceConnection.cs

* 3278 Re-added properties that were flagged as unused but are being used by ADS in ReliableDataSourceConnection.cs

* adding pipeline to execute tests (#1062)

* 3278 Converted GetDefaultAutoComplete and GetDefaultSemanticMarkers to static functions in DataSourceFactory. Removed unused constructor in ScriptFile. Added positive unit tests for both functions

* undoing release version bump

* adding additional configs

* 3278 Minor refactors in ConnectionInfo, BindingQueue, DiagnosticsHelper, MetadataService, and HostLoader. Changed AssemblyInfo to only allow Kusto Unit Tests for internal access. Added lots of unit tests.

* 3278 Commented out bindingContext.IsConnected in AddConnectionContext_Sets_BindingContext

* 3278 Reversed order of unit tests in ConnectedBindingQueueTests and added throw to Catch block.

* 3278 Reverted change to ConnectedBindingQueue. Removed unit test from AddConnectionContext for NeedsMetaData True

Co-authored-by: Jorge Berumen <52225468+joberume@users.noreply.github.com>
Co-authored-by: joberume <jberumen3@miners.utep.edu>

test/Microsoft.Kusto.ServiceLayer.UnitTests/Connection/ConnectionInfoTests.cs

@@ -0,0 +1,89 @@
+using System;
+using Microsoft.Kusto.ServiceLayer.Connection;
+using Microsoft.Kusto.ServiceLayer.Connection.Contracts;
+using Microsoft.Kusto.ServiceLayer.DataSource;
+using Microsoft.SqlTools.ServiceLayer.Connection.ReliableConnection;
+using Moq;
+using NUnit.Framework;
+
+namespace Microsoft.Kusto.ServiceLayer.UnitTests.Connection
+{
+    public class ConnectionInfoTests
+    {
+        [TestCase("")]
+        [TestCase(null)]
+        public void AddConnection_Throws_Exception_For_Invalid_ConnectionType(string connectionType)
+        {
+            var datasourceFactoryMock = new Mock<IDataSourceConnectionFactory>();
+            var connectionInfo = new ConnectionInfo(datasourceFactoryMock.Object, "", new ConnectionDetails());
+            Assert.Throws<ArgumentException>(() => connectionInfo.AddConnection(connectionType, null));
+        }
+
+        [TestCase("")]
+        [TestCase(null)]
+        public void GetConnection_Throws_Exception_For_Invalid_ConnectionType(string connectionType)
+        {
+            var datasourceFactoryMock = new Mock<IDataSourceConnectionFactory>();
+            var connectionInfo = new ConnectionInfo(datasourceFactoryMock.Object, "", new ConnectionDetails());
+            Assert.Throws<ArgumentException>(() => connectionInfo.TryGetConnection(connectionType, out var connection));
+        }
+
+        [Test]
+        public void AddConnection_And_GetConnection_AddAndGet()
+        {
+            var connectionFactoryMock = new Mock<IDataSourceConnectionFactory>();
+            var connectionInfo = new ConnectionInfo(connectionFactoryMock.Object, "", new ConnectionDetails());
+
+            var dataSourceFactoryMock = new Mock<IDataSourceFactory>();
+            var reliableDataSource = new ReliableDataSourceConnection("", RetryPolicyFactory.NoRetryPolicy,
+                RetryPolicyFactory.NoRetryPolicy, "", dataSourceFactoryMock.Object);
+            connectionInfo.AddConnection("ConnectionType", reliableDataSource);
+
+            connectionInfo.TryGetConnection("ConnectionType", out var connection);
+            Assert.AreEqual(reliableDataSource, connection);
+        }
+
+        [TestCase("")]
+        [TestCase(null)]
+        public void RemoveConnection_Throws_Exception_For_Invalid_ConnectionType(string connectionType)
+        {
+            var datasourceFactoryMock = new Mock<IDataSourceConnectionFactory>();
+            var connectionInfo = new ConnectionInfo(datasourceFactoryMock.Object, "", new ConnectionDetails());
+            Assert.Throws<ArgumentException>(() => connectionInfo.RemoveConnection(connectionType));
+        }
+
+        [Test]
+        public void RemoveConnection_Removes_Connection()
+        {
+            var connectionFactoryMock = new Mock<IDataSourceConnectionFactory>();
+            var connectionInfo = new ConnectionInfo(connectionFactoryMock.Object, "", new ConnectionDetails());
+
+            var dataSourceFactoryMock = new Mock<IDataSourceFactory>();
+            var reliableDataSource = new ReliableDataSourceConnection("", RetryPolicyFactory.NoRetryPolicy,
+                RetryPolicyFactory.NoRetryPolicy, "", dataSourceFactoryMock.Object);
+            connectionInfo.AddConnection("ConnectionType", reliableDataSource);
+
+            connectionInfo.RemoveConnection("ConnectionType");
+
+            connectionInfo.TryGetConnection("ConnectionType", out var connection);
+            Assert.IsNull(connection);
+        }
+
+        [Test]
+        public void RemoveAllConnections_RemovesAllConnections()
+        {
+            var connectionFactoryMock = new Mock<IDataSourceConnectionFactory>();
+            var connectionInfo = new ConnectionInfo(connectionFactoryMock.Object, "", new ConnectionDetails());
+
+            var dataSourceFactoryMock = new Mock<IDataSourceFactory>();
+            var reliableDataSource = new ReliableDataSourceConnection("", RetryPolicyFactory.NoRetryPolicy,
+                RetryPolicyFactory.NoRetryPolicy, "", dataSourceFactoryMock.Object);
+            connectionInfo.AddConnection("ConnectionType", reliableDataSource);
+
+            connectionInfo.RemoveAllConnections();
+
+            connectionInfo.TryGetConnection("ConnectionType", out var connection);
+            Assert.IsNull(connection);
+        }
+    }
+}

test/Microsoft.Kusto.ServiceLayer.UnitTests/Connection/ConnectionProviderOptionsHelperTests.cs

@@ -0,0 +1,15 @@
+using Microsoft.Kusto.ServiceLayer.Connection;
+using NUnit.Framework;
+
+namespace Microsoft.Kusto.ServiceLayer.UnitTests.Connection
+{
+    public class ConnectionProviderOptionsHelperTests
+    {
+        [Test]
+        public void BuildConnectionProviderOptions_Returns_31_Options()
+        {
+            var providerOptions = ConnectionProviderOptionsHelper.BuildConnectionProviderOptions();
+            Assert.AreEqual(31, providerOptions.Options.Length);
+        }
+    }
+}

test/Microsoft.Kusto.ServiceLayer.UnitTests/Connection/DataSourceConnectionFactoryTests.cs

@@ -0,0 +1,20 @@
+using Microsoft.Kusto.ServiceLayer.Connection;
+using Microsoft.Kusto.ServiceLayer.DataSource;
+using Moq;
+using NUnit.Framework;
+
+namespace Microsoft.Kusto.ServiceLayer.UnitTests.Connection
+{
+    public class DataSourceConnectionFactoryTests
+    {
+        [Test]
+        public void CreateDataSourceConnection_Returns_Connection()
+        {
+            var dataSourceFactoryMock = new Mock<IDataSourceFactory>(); 
+            var connectionFactory = new DataSourceConnectionFactory(dataSourceFactoryMock.Object);
+            var connection = connectionFactory.CreateDataSourceConnection("", "");
+            
+            Assert.IsNotNull(connection);
+        }
+    }
+}