Should await result of requestcontext.sendresult in case it errors (#520)

- Refactored to use pattern where we wait on the binding queue action to complete, then send the result / error outside of that.

src/Microsoft.SqlTools.ServiceLayer/Localization/sr.cs

@@ -2405,6 +2405,14 @@ namespace Microsoft.SqlTools.ServiceLayer
             }
         }
 
+        public static string ScriptingUnexpectedError
+        {
+            get
+            {
+                return Keys.GetString(Keys.ScriptingUnexpectedError);
+            }
+        }
+
         public static string unavailable
         {
             get
@@ -4600,6 +4608,9 @@ namespace Microsoft.SqlTools.ServiceLayer
             public const string ScriptingListObjectsCompleteParams_ConnectionString_Property_Invalid = "ScriptingListObjectsCompleteParams_ConnectionString_Property_Invalid";
 
 
+            public const string ScriptingUnexpectedError = "ScriptingUnexpectedError";
+
+
             public const string unavailable = "unavailable";
 
 

src/Microsoft.SqlTools.ServiceLayer/Localization/sr.resx

@@ -1380,6 +1380,10 @@
     <value>Error parsing ScriptingListObjectsCompleteParams.ConnectionString property.</value>
     <comment></comment>
   </data>
+  <data name="ScriptingUnexpectedError" xml:space="preserve">
+    <value>Unexpected error while scripting: no result returned from script operation.</value>
+    <comment></comment>
+  </data>
   <data name="unavailable" xml:space="preserve">
     <value>Unavailable</value>
     <comment></comment>

src/Microsoft.SqlTools.ServiceLayer/Localization/sr.strings

@@ -690,6 +690,8 @@ ScriptingParams_FilePath_Property_Invalid = Invalid directory specified by the S
 
 ScriptingListObjectsCompleteParams_ConnectionString_Property_Invalid = Error parsing ScriptingListObjectsCompleteParams.ConnectionString property.
 
+ScriptingUnexpectedError = Unexpected error while scripting: no result returned from script operation.
+
 
 
 

src/Microsoft.SqlTools.ServiceLayer/Localization/sr.xlf

@@ -2311,6 +2311,11 @@
         <note>.
  Parameters: 0 - value (string), 1 - columnType (string) </note>
       </trans-unit>
+      <trans-unit id="ScriptingUnexpectedError">
+        <source>Unexpected error while scripting: no result returned from script operation.</source>
+        <target state="new">Unexpected error while scripting: no result returned from script operation.</target>
+        <note></note>
+      </trans-unit>
     </body>
   </file>
 </xliff>