ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-10 10:12:39 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix file browser cancel/connetion issues (#528)

Browse Source 
* clean bindingqueue after cancel

* fileborwser fixes

* code cleanup

* re-initialize filetree whenever filter is changed

* fix test issues

* address pr comments
This commit is contained in:
Kate Shin
2017-10-26 10:54:22 -07:00
committed by Karl Burtram
parent 4d04bff810
commit cc9beed835
8 changed files with 195 additions and 125 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/Microsoft.SqlTools.ServiceLayer.IntegrationTests/FileBrowser/FileBrowserServiceTests.cs
View File

@@ -91,9 +91,7 @@ namespace Microsoft.SqlTools.ServiceLayer.IntegrationTests.FileBrowser
};
await service.HandleFileBrowserCloseRequest(inputParams, requestContext.Object);
// Result should return false since it's trying to close a filebrowser that was never opened
requestContext.Verify(x => x.SendResult(It.Is<FileBrowserCloseResponse>(p => p.Succeeded == false)));
requestContext.Verify(x => x.SendResult(It.Is<FileBrowserCloseResponse>(p => p.Succeeded == true)));
}
#endregion

4
test/Microsoft.SqlTools.ServiceLayer.UnitTests/FileBrowser/FileBrowserTests.cs
View File

@@ -28,7 +28,7 @@ namespace Microsoft.SqlTools.ServiceLayer.UnitTests.FileBrowser
[Fact]
public void FilterFilesTest()
{
FileBrowserOperation operation = new FileBrowserOperation();
FileBrowserOperation operation = new FileBrowserOperation(null, "", null);
string[] supportedFilePaths = new string[] {"te\\s/t1.txt", "te!s.t2.bak" };
string[] unsupportedFilePaths = new string[] { "te.s*/t3.jpg", "t_est4.trn" };
string[] filters = new string[] { "*.txt", "*.bak"};
@@ -47,7 +47,7 @@ namespace Microsoft.SqlTools.ServiceLayer.UnitTests.FileBrowser
[Fact]
public void ExpandNodeShouldThrowExceptionForInvalidPath()
{
FileBrowserOperation operation = new FileBrowserOperation();
FileBrowserOperation operation = new FileBrowserOperation(null, "", null);
Exception exception = null;
try