Agent Proxy and Credential request handlers (#637)

* Agent Proxy account WIP

* Fixup Credential create\update\delete handlers

* Use current user for test credential

* Cleanup and delete code

* Convert tabs to spaces

test/Microsoft.SqlTools.ServiceLayer.IntegrationTests/Security/CredentialTests.cs

@@ -0,0 +1,92 @@
+//
+// Copyright (c) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+//
+
+using System.Collections.Generic;
+using System.Threading;
+using System.Threading.Tasks;
+using Microsoft.SqlTools.Hosting.Protocol;
+using Microsoft.SqlTools.ServiceLayer.Connection;
+using Microsoft.SqlTools.ServiceLayer.IntegrationTests.Utility;
+using Microsoft.SqlTools.ServiceLayer.Security;
+using Microsoft.SqlTools.ServiceLayer.Security.Contracts;
+using Microsoft.SqlTools.ServiceLayer.Test.Common;
+using Microsoft.SqlTools.ServiceLayer.Workspace.Contracts;
+using Moq;
+using Xunit;
+using static Microsoft.SqlTools.ServiceLayer.IntegrationTests.Utility.LiveConnectionHelper;
+
+namespace Microsoft.SqlTools.ServiceLayer.IntegrationTests.Security
+{
+    /// <summary>
+    /// Tests for the Credential management component
+    /// </summary>
+    public class CredentialTests
+    {
+        /// <summary>
+        /// TestHandleCreateCredentialRequest
+        /// </summary>
+        [Fact]
+        public async Task TestHandleCreateCredentialRequest()
+        {
+            using (SelfCleaningTempFile queryTempFile = new SelfCleaningTempFile())
+            {
+                // setup
+                var connectionResult = await LiveConnectionHelper.InitLiveConnectionInfoAsync("master", queryTempFile.FilePath);
+                var service = new SecurityService();
+                var credential = SecurityTestUtils.GetTestCredentialInfo();
+                await SecurityTestUtils.DeleteCredential(service, connectionResult, credential);
+
+                // test
+                await SecurityTestUtils.CreateCredential(service, connectionResult, credential);
+
+                // cleanup
+                await SecurityTestUtils.DeleteCredential(service, connectionResult, credential);
+            }
+        }
+
+        /// <summary>
+        /// TestHandleUpdateCredentialRequest
+        /// </summary>
+        [Fact]
+        public async Task TestHandleUpdateCredentialRequest()
+        {
+            using (SelfCleaningTempFile queryTempFile = new SelfCleaningTempFile())
+            {
+                // setup
+                var connectionResult = await LiveConnectionHelper.InitLiveConnectionInfoAsync("master", queryTempFile.FilePath);
+                var service = new SecurityService();
+                var credential = SecurityTestUtils.GetTestCredentialInfo();
+                await SecurityTestUtils.DeleteCredential(service, connectionResult, credential);
+                await SecurityTestUtils.CreateCredential(service, connectionResult, credential);
+
+                // test
+                await SecurityTestUtils.UpdateCredential(service, connectionResult, credential);
+
+                // cleanup
+                await SecurityTestUtils.DeleteCredential(service, connectionResult, credential);
+            }
+        }
+
+        /// <summary>
+        /// TestHandleDeleteCredentialRequest
+        /// </summary>
+        [Fact]
+        public async Task TestHandleDeleteCredentialRequest()
+        {
+            using (SelfCleaningTempFile queryTempFile = new SelfCleaningTempFile())
+            {
+                // setup
+                var connectionResult = await LiveConnectionHelper.InitLiveConnectionInfoAsync("master", queryTempFile.FilePath);
+                var service = new SecurityService();
+                var credential = SecurityTestUtils.GetTestCredentialInfo();
+                await SecurityTestUtils.DeleteCredential(service, connectionResult, credential);
+                await SecurityTestUtils.CreateCredential(service, connectionResult, credential);
+
+                // test
+                await SecurityTestUtils.DeleteCredential(service, connectionResult, credential);
+            }
+        }
+    }
+}

test/Microsoft.SqlTools.ServiceLayer.IntegrationTests/Security/SecurityServiceTests.cs

@@ -1,54 +0,0 @@
-//
-// Copyright (c) Microsoft. All rights reserved.
-// Licensed under the MIT license. See LICENSE file in the project root for full license information.
-//
-
-using Microsoft.SqlTools.Hosting.Protocol;
-using Microsoft.SqlTools.ServiceLayer.Connection;
-using Microsoft.SqlTools.ServiceLayer.IntegrationTests.Utility;
-using Microsoft.SqlTools.ServiceLayer.Security;
-using Microsoft.SqlTools.ServiceLayer.Security.Contracts;
-using Microsoft.SqlTools.ServiceLayer.Test.Common;
-using Microsoft.SqlTools.ServiceLayer.Workspace.Contracts;
-using Moq;
-using System.Collections.Generic;
-using System.Linq;
-using System.Threading;
-using System.Threading.Tasks;
-using Xunit;
-using static Microsoft.SqlTools.ServiceLayer.IntegrationTests.Utility.LiveConnectionHelper;
-
-namespace Microsoft.SqlTools.ServiceLayer.IntegrationTests.Security
-{
-    /// <summary>
-    /// Tests for the security service component
-    /// </summary>
-    public class SecuritygServiceTests
-    {
-        /// <summary>
-        /// Verify the script object request
-        /// </summary>
-        [Fact]
-        public async Task TestHandleCreateCredentialRequest()
-        {
-            using (SelfCleaningTempFile queryTempFile = new SelfCleaningTempFile())
-            {
-                var createContext = new Mock<RequestContext<CreateCredentialResult>>();
-                var connectionResult = await LiveConnectionHelper.InitLiveConnectionInfoAsync("master", queryTempFile.FilePath);
-
-                var service = new SecurityService();
-                var credential = new CredentialInfo()
-                {                
-                };
-
-                await service.HandleCreateCredentialRequest(new CreateCredentialParams
-                {
-                    OwnerUri = connectionResult.ConnectionInfo.OwnerUri,
-                    Credential = credential
-                }, createContext.Object);
-
-                createContext.VerifyAll();
-            }
-        }  
-    }
-}

test/Microsoft.SqlTools.ServiceLayer.IntegrationTests/Security/SecurityTestUtils.cs

@@ -0,0 +1,95 @@
+//
+// Copyright (c) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+//
+
+using System;
+using System.Threading.Tasks;
+using Microsoft.SqlTools.Hosting.Protocol;
+using Microsoft.SqlTools.ServiceLayer.Connection;
+using Microsoft.SqlTools.ServiceLayer.Security;
+using Microsoft.SqlTools.ServiceLayer.Security.Contracts;
+using Microsoft.SqlTools.ServiceLayer.Utility;
+using Moq;
+using static Microsoft.SqlTools.ServiceLayer.IntegrationTests.Utility.LiveConnectionHelper;
+
+namespace Microsoft.SqlTools.ServiceLayer.IntegrationTests.Security
+{
+    public static class SecurityTestUtils
+    {
+        public static string TestCredentialName = "Current User";
+
+        internal static string GetCurrentUserIdentity()
+        {               
+            return string.Format(@"{0}\{1}", Environment.UserDomainName, Environment.UserName);
+        }
+
+        internal static CredentialInfo GetTestCredentialInfo()
+        {
+            return new CredentialInfo()
+            {
+                Identity = GetCurrentUserIdentity(),
+                Name = TestCredentialName
+            };
+        }
+
+        internal static async Task CreateCredential(
+            SecurityService service, 
+            TestConnectionResult connectionResult,
+            CredentialInfo credential)
+        {
+            var context = new Mock<RequestContext<CredentialResult>>();
+            await service.HandleCreateCredentialRequest(new CreateCredentialParams
+            {
+                OwnerUri = connectionResult.ConnectionInfo.OwnerUri,
+                Credential = credential
+            }, context.Object);
+            context.VerifyAll();
+        }
+
+        internal static async Task UpdateCredential(
+            SecurityService service, 
+            TestConnectionResult connectionResult,
+            CredentialInfo credential)
+        {
+            var context = new Mock<RequestContext<CredentialResult>>();
+            await service.HandleUpdateCredentialRequest(new UpdateCredentialParams
+            {
+                OwnerUri = connectionResult.ConnectionInfo.OwnerUri,
+                Credential = credential
+            }, context.Object);
+            context.VerifyAll();
+        }
+
+        internal static async Task DeleteCredential(
+            SecurityService service, 
+            TestConnectionResult connectionResult, 
+            CredentialInfo credential)
+        {
+            var context = new Mock<RequestContext<ResultStatus>>();
+            await service.HandleDeleteCredentialRequest(new DeleteCredentialParams
+            {
+                OwnerUri = connectionResult.ConnectionInfo.OwnerUri,
+                Credential = credential
+            }, context.Object);
+            context.VerifyAll();
+        }
+
+        public static async Task<CredentialInfo> SetupCredential(TestConnectionResult connectionResult)
+        {
+            var service = new SecurityService();
+            var credential = SecurityTestUtils.GetTestCredentialInfo();
+            await SecurityTestUtils.DeleteCredential(service, connectionResult, credential);
+            await SecurityTestUtils.CreateCredential(service, connectionResult, credential);
+            return credential;
+        }
+
+        public static async Task CleanupCredential(
+            TestConnectionResult connectionResult,
+            CredentialInfo credential)
+        {
+            var service = new SecurityService();
+            await SecurityTestUtils.DeleteCredential(service, connectionResult, credential);
+        }
+    }
+}