Fix invalid dacpac version crashing sqltoolsservice (#789)

* fix invalid dacpac version crashing sqltoolsservice
This commit is contained in:
kisantia
2019-04-03 17:30:10 -07:00
committed by GitHub
parent 49cecaf72a
commit dc5ab60df5
9 changed files with 68 additions and 8 deletions

View File

@@ -2869,6 +2869,14 @@ namespace Microsoft.SqlTools.ServiceLayer
}
}
public static string ExtractInvalidVersion
{
get
{
return Keys.GetString(Keys.ExtractInvalidVersion);
}
}
public static string ConnectionServiceListDbErrorNotConnected(string uri)
{
return Keys.GetString(Keys.ConnectionServiceListDbErrorNotConnected, uri);
@@ -4182,6 +4190,9 @@ namespace Microsoft.SqlTools.ServiceLayer
public const string Error_ExistingDirectoryName = "Error_ExistingDirectoryName";
public const string ExtractInvalidVersion = "ExtractInvalidVersion";
private Keys()
{ }

View File

@@ -1687,4 +1687,8 @@
<value>For directory {0} a file with name {1} already exist</value>
<comment></comment>
</data>
<data name="ExtractInvalidVersion" xml:space="preserve">
<value>Invalid version '{0}' passed. Version must be in the format x.x.x.x where x is a number.</value>
<comment></comment>
</data>
</root>

View File

@@ -782,4 +782,8 @@ JobServerIsNotAvailable = Job server is not available
NeverBackedUp = Never
Error_InvalidDirectoryName = Path {0} is not a valid directory
Error_ExistingDirectoryName = For directory {0} a file with name {1} already exist
Error_ExistingDirectoryName = For directory {0} a file with name {1} already exist
############################################################################
# DacFx
ExtractInvalidVersion = Invalid version '{0}' passed. Version must be in the format x.x.x.x where x is a number.

View File

@@ -1956,6 +1956,11 @@
<target state="new">Batch parser wrapper execution: {0} found... at line {1}: {2} Description: {3}</target>
<note></note>
</trans-unit>
<trans-unit id="ExtractInvalidVersion">
<source>Invalid version '{0}' passed. Version must be in the format x.x.x.x where x is a number.</source>
<target state="new">Invalid version '{0}' passed. Version must be in the format x.x.x.x where x is a number.</target>
<note></note>
</trans-unit>
</body>
</file>
</xliff>