ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-04 01:25:43 -05:00
Code Issues Packages Projects Releases Wiki Activity

Enabling Database scoped configurations tab to DB Properties (#2147)

Browse Source 
* sending dsc values to ADS

* modifying dsc method with unsupportable property IsValuedefault

* getting the options and added a bool flag to maintian checkbox for secondary to save

* sending data to ads

* Ready for PR with minimal changes of loading UI as expected, TODO:saving logic

* Excluding maxdop and resumable options from primary value conversion for 1/0's

* Adding Id to the info, as we cannot depend on names, as names can be altered in future

* saving successfully, todo-diff servers, script (secondary - primary compare and dont update),test, send null for unsupported

* adding nullable dsc for unsupported servers

* fixing script generation for some properties that are not touched. the generated script is unharmed but unnecessary here

* adding test conditions for database scoped configurations

* adding switch case method to get the values

* Removing Loc string for the TSQL options

* removing unnecessary using statement

* Adding test case and fixing createDatabase issue

* Update src/Microsoft.SqlTools.ServiceLayer/Admin/Database/DatabasePrototype130.cs

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* comment update

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
This commit is contained in:
Sai Avishkar Sreerama
2023-08-15 11:58:35 -05:00
committed by GitHub
parent 7c0da6b6b1
commit e4db70fb39
15 changed files with 281 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/Microsoft.SqlTools.ServiceLayer/Localization/sr.cs
View File

@@ -12301,14 +12301,6 @@ namespace Microsoft.SqlTools.ServiceLayer
}
}
public static string prototype_db_prop_databasescopedconfig_value_primary
{
get
{
return Keys.GetString(Keys.prototype_db_prop_databasescopedconfig_value_primary);
}
}
public static string error_db_prop_invalidleadingColumns
{
get
@@ -17828,9 +17820,6 @@ namespace Microsoft.SqlTools.ServiceLayer
public const string prototype_db_prop_databasescopedconfig_value_on = "prototype_db_prop_databasescopedconfig_value_on";
public const string prototype_db_prop_databasescopedconfig_value_primary = "prototype_db_prop_databasescopedconfig_value_primary";
public const string error_db_prop_invalidleadingColumns = "error_db_prop_invalidleadingColumns";

4
src/Microsoft.SqlTools.ServiceLayer/Localization/sr.resx
View File

@@ -6702,10 +6702,6 @@ The Query Processor estimates that implementing the following index could improv
<value>ON</value>
<comment></comment>
</data>
<data name="prototype_db_prop_databasescopedconfig_value_primary" xml:space="preserve">
<value>PRIMARY</value>
<comment></comment>
</data>
<data name="error_db_prop_invalidleadingColumns" xml:space="preserve">
<value>For the distribution policy HASH, the number of leading hash columns is optional but should be from 1 to 16 columns</value>
<comment></comment>

1
src/Microsoft.SqlTools.ServiceLayer/Localization/sr.strings
View File

@@ -2786,7 +2786,6 @@ prototype_db_prop_varDecimalEnabled = VarDecimal Storage Format Enabled
prototype_db_prop_encryptionEnabled = Encryption Enabled
prototype_db_prop_databasescopedconfig_value_off = OFF
prototype_db_prop_databasescopedconfig_value_on = ON
prototype_db_prop_databasescopedconfig_value_primary = PRIMARY
error_db_prop_invalidleadingColumns = For the distribution policy HASH, the number of leading hash columns is optional but should be from 1 to 16 columns
compatibilityLevel_sphinx = SQL Server 7.0 (70)
compatibilityLevel_shiloh = SQL Server 2000 (80)

5
src/Microsoft.SqlTools.ServiceLayer/Localization/sr.xlf
View File

@@ -8216,11 +8216,6 @@ The Query Processor estimates that implementing the following index could improv
<target state="new">ON</target>
<note></note>
</trans-unit>
<trans-unit id="prototype_db_prop_databasescopedconfig_value_primary">
<source>PRIMARY</source>
<target state="new">PRIMARY</target>
<note></note>
</trans-unit>
<trans-unit id="error_db_prop_invalidleadingColumns">
<source>For the distribution policy HASH, the number of leading hash columns is optional but should be from 1 to 16 columns</source>
<target state="new">For the distribution policy HASH, the number of leading hash columns is optional but should be from 1 to 16 columns</target>