Remove Peek Definition error popup (#786)

* Remove Peek Definition error popup

* Fix broken test case

* Fix bug
This commit is contained in:
Karl Burtram
2019-03-22 16:52:45 -07:00
committed by GitHub
parent 57727409c1
commit eaaff8b8a1
2 changed files with 6 additions and 13 deletions

View File

@@ -415,17 +415,10 @@ namespace Microsoft.SqlTools.ServiceLayer.LanguageServices
definitionResult = GetDefinition(textDocumentPosition, scriptFile, connInfo);
}
if (definitionResult != null)
if (definitionResult != null && !definitionResult.IsErrorResult)
{
if (definitionResult.IsErrorResult)
{
await requestContext.SendError(definitionResult.Message);
}
else
{
await requestContext.SendResult(definitionResult.Locations);
succeeded = true;
}
await requestContext.SendResult(definitionResult.Locations);
succeeded = true;
}
else
{