ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove dropped ledger columns from Edit Data columns (#1691)

Browse Source 
* remove dropped ledger columns from Edit Data columns

* moving dropped ledger filtering to column retrieval from SMO

* fix clear and initialize placement and retrieve DefaultConstraintName
This commit is contained in:
Jordan Hays
2022-09-19 16:22:54 -07:00
committed by GitHub
parent 5274d3a604
commit ec1bb0e9ec
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Microsoft.SqlTools.ServiceLayer/EditData/SmoEditMetadataFactory.cs
View File

@@ -93,6 +93,10 @@ namespace Microsoft.SqlTools.ServiceLayer.EditData
throw new ArgumentOutOfRangeException(nameof(objectNamedParts), SR.EditDataObjectNotFound); throw new ArgumentOutOfRangeException(nameof(objectNamedParts), SR.EditDataObjectNotFound);
} }
// Filter out dropped ledger columns from the list of columns to be returned
// and grab the specific column properties checked below
smoResult.Columns.ClearAndInitialize("[(@IsDroppedLedgerColumn=0)]", new [] { nameof(Column.DataType), nameof(Column.DefaultConstraintName) });
// Generate the edit column metadata // Generate the edit column metadata
List<EditColumnMetadata> editColumns = new List<EditColumnMetadata>(); List<EditColumnMetadata> editColumns = new List<EditColumnMetadata>();
for (int i = 0; i < smoResult.Columns.Count; i++) for (int i = 0; i < smoResult.Columns.Count; i++)
@@ -103,7 +107,7 @@ namespace Microsoft.SqlTools.ServiceLayer.EditData
try try
{ {
// The default value may be escaped // The default value may be escaped
defaultValue = smoColumn.DefaultConstraint == null defaultValue = string.IsNullOrEmpty(smoColumn.DefaultConstraintName)
? null ? null
: FromSqlScript.UnwrapLiteral(smoColumn.DefaultConstraint.Text); : FromSqlScript.UnwrapLiteral(smoColumn.DefaultConstraint.Text);
} }