ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-01-18 17:23:52 -05:00
Code Issues Packages Projects Releases Wiki Activity

NULL column validation when updating cells (#274)

Browse Source 
* Adding validation that NULL is allowed when setting cell values

* Adding unit tests
This commit is contained in:
Benjamin Russell
2017-03-09 16:14:25 -08:00
committed by GitHub
parent 8f3e83b519
commit f2afa07a93
6 changed files with 50 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/Microsoft.SqlTools.ServiceLayer/EditData/UpdateManagement/CellUpdate.cs
View File

@@ -38,8 +38,7 @@ namespace Microsoft.SqlTools.ServiceLayer.EditData.UpdateManagement
// Check for null
if (valueAsString == NullString)
{
Value = DBNull.Value;
ValueAsString = valueAsString;
ProcessNullValue();
}
else if (columnType == typeof(byte[]))
{
@@ -197,6 +196,18 @@ namespace Microsoft.SqlTools.ServiceLayer.EditData.UpdateManagement
ValueAsString = Value.ToString();
}
private void ProcessNullValue()
{
// Make sure that nulls are allowed if we set it to null
if (!Column.AllowDBNull.HasTrue())
{
throw new InvalidOperationException(SR.EditDataNullNotAllowed);
}
Value = DBNull.Value;
ValueAsString = NullString;
}
#endregion
}
}