ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-04 17:24:56 -05:00
Code Issues Packages Projects Releases Wiki Activity

Changes to sqltoolsservice to allow empty password for SqlLogin (#333)

Browse Source 
* Initial changes to allow empty passwords

* Added in empty password test

* Modifying test to work after my changes.
This commit is contained in:
Henry Phan
2017-05-02 10:17:44 -07:00
committed by GitHub
parent fb239ac956
commit f50f30b493
3 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Microsoft.SqlTools.ServiceLayer/Connection/Contracts/ConnectParamsExtensions.cs
View File

@@ -35,15 +35,11 @@ namespace Microsoft.SqlTools.ServiceLayer.Connection.Contracts
}
else if (string.IsNullOrEmpty(parameters.Connection.AuthenticationType) || parameters.Connection.AuthenticationType == "SqlLogin")
{
// For SqlLogin, username/password cannot be empty
// For SqlLogin, username cannot be empty
if (string.IsNullOrEmpty(parameters.Connection.UserName))
{
errorMessage = SR.ConnectionParamsValidateNullSqlAuth("UserName");
}
else if( string.IsNullOrEmpty(parameters.Connection.Password))
{
errorMessage = SR.ConnectionParamsValidateNullSqlAuth("Password");
}
}
return string.IsNullOrEmpty(errorMessage);