Changes to sqltoolsservice to allow empty password for SqlLogin (#333)

* Initial changes to allow empty passwords

* Added in empty password test

* Modifying test to work after my changes.
This commit is contained in:
Henry Phan
2017-05-02 10:17:44 -07:00
committed by GitHub
parent fb239ac956
commit f50f30b493
3 changed files with 12 additions and 8 deletions

View File

@@ -91,9 +91,9 @@ namespace Microsoft.SqlTools.ServiceLayer.UnitTests.Credentials
await service.HandleSaveCredentialRequest(new Credential(CredentialId), contextMock.Object);
TestUtils.VerifyErrorSent(contextMock);
Assert.Contains("ArgumentException", errorResponse);
Assert.True(errorResponse.Contains("ArgumentException") || errorResponse.Contains("ArgumentNullException"));
}
[Fact]
public async Task SaveCredentialWorksForSingleCredential()
{
@@ -102,6 +102,14 @@ namespace Microsoft.SqlTools.ServiceLayer.UnitTests.Credentials
verify: Assert.True);
}
[Fact]
public async Task SaveCredentialWorksForEmptyPassword()
{
await TestUtils.RunAndVerify<bool>(
test: (requestContext) => service.HandleSaveCredentialRequest(new Credential(CredentialId, ""), requestContext),
verify: Assert.True);
}
[Fact]
public async Task SaveCredentialSupportsSavingCredentialMultipleTimes()
{