ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-17 02:51:45 -05:00
Code Issues Packages Projects Releases Wiki Activity

Changes to sqltoolsservice to allow empty password for SqlLogin (#333)

Browse Source 
* Initial changes to allow empty passwords

* Added in empty password test

* Modifying test to work after my changes.
This commit is contained in:
Henry Phan
2017-05-02 10:17:44 -07:00
committed by GitHub
parent fb239ac956
commit f50f30b493
3 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Microsoft.SqlTools.Credentials/Credentials/Contracts/Credential.cs
View File

@@ -78,7 +78,7 @@ namespace Microsoft.SqlTools.Credentials.Contracts
public static void ValidateForSave(Credential credential) public static void ValidateForSave(Credential credential)
{ {
ValidateForLookup(credential); ValidateForLookup(credential);
Validate.IsNotNullOrEmptyString("credential.Password", credential.Password); Validate.IsNotNull("credential.Password", credential.Password);
} }
} }

6
src/Microsoft.SqlTools.ServiceLayer/Connection/Contracts/ConnectParamsExtensions.cs
View File

@@ -35,15 +35,11 @@ namespace Microsoft.SqlTools.ServiceLayer.Connection.Contracts
} }
else if (string.IsNullOrEmpty(parameters.Connection.AuthenticationType) || parameters.Connection.AuthenticationType == "SqlLogin") else if (string.IsNullOrEmpty(parameters.Connection.AuthenticationType) || parameters.Connection.AuthenticationType == "SqlLogin")
{ {
// For SqlLogin, username/password cannot be empty // For SqlLogin, username cannot be empty
if (string.IsNullOrEmpty(parameters.Connection.UserName)) if (string.IsNullOrEmpty(parameters.Connection.UserName))
{ {
errorMessage = SR.ConnectionParamsValidateNullSqlAuth("UserName"); errorMessage = SR.ConnectionParamsValidateNullSqlAuth("UserName");
} }
else if( string.IsNullOrEmpty(parameters.Connection.Password))
{
errorMessage = SR.ConnectionParamsValidateNullSqlAuth("Password");
}
} }
return string.IsNullOrEmpty(errorMessage); return string.IsNullOrEmpty(errorMessage);

10
test/Microsoft.SqlTools.ServiceLayer.UnitTests/Credentials/CredentialServiceTests.cs
View File

@@ -91,7 +91,7 @@ namespace Microsoft.SqlTools.ServiceLayer.UnitTests.Credentials
await service.HandleSaveCredentialRequest(new Credential(CredentialId), contextMock.Object); await service.HandleSaveCredentialRequest(new Credential(CredentialId), contextMock.Object);
TestUtils.VerifyErrorSent(contextMock); TestUtils.VerifyErrorSent(contextMock);
Assert.Contains("ArgumentException", errorResponse); Assert.True(errorResponse.Contains("ArgumentException") || errorResponse.Contains("ArgumentNullException"));
} }
[Fact] [Fact]
@@ -102,6 +102,14 @@ namespace Microsoft.SqlTools.ServiceLayer.UnitTests.Credentials
verify: Assert.True); verify: Assert.True);
} }
[Fact]
public async Task SaveCredentialWorksForEmptyPassword()
{
await TestUtils.RunAndVerify<bool>(
test: (requestContext) => service.HandleSaveCredentialRequest(new Credential(CredentialId, ""), requestContext),
verify: Assert.True);
}
[Fact] [Fact]
public async Task SaveCredentialSupportsSavingCredentialMultipleTimes() public async Task SaveCredentialSupportsSavingCredentialMultipleTimes()
{ {