mirror of
https://github.com/ckaczor/sqltoolsservice.git
synced 2026-02-04 09:35:37 -05:00
Adding decoding of multipart identifiers, default schema workaround (#295)
This change adds a couple things _Multipart Identifier Decoding_ The ability to decode a multipart identifier (with or without escaping) has been added to the SqlScriptFormatter utility class. This code is utilized to split a table name provided to the edit/initialize request into schema and table name. _Default Schema Workaround_ The code that retrieves the SMO metadata objects originally used the `[]` operator to access the objects. Due to a bug(?) in SMO, this results in problems when loading tables without a default schema (in our case if you're logged in as SA). Using the metadata object constructors gets around this issue, we are explicitly using them. * Adding decoding of multipart identifiers Adding code fix for default schema issue * Adding some more localizable strings for errors when loading metadata * Adding localization files... again? * Changes as per pull request comments
This commit is contained in:
@@ -382,6 +382,14 @@
|
||||
<value>Table metadata does not have extended properties</value>
|
||||
<comment></comment>
|
||||
</data>
|
||||
<data name="EditDataMetadataObjectNameRequired" xml:space="preserve">
|
||||
<value>A object name must be provided</value>
|
||||
<comment></comment>
|
||||
</data>
|
||||
<data name="EditDataMetadataTooManyIdentifiers" xml:space="preserve">
|
||||
<value>Explicitly specifying server or database is not supported</value>
|
||||
<comment></comment>
|
||||
</data>
|
||||
<data name="EditDataFilteringNegativeLimit" xml:space="preserve">
|
||||
<value>Result limit cannot be negative</value>
|
||||
<comment></comment>
|
||||
@@ -603,4 +611,8 @@
|
||||
<value>Decimal column is missing numeric precision or numeric scale</value>
|
||||
<comment></comment>
|
||||
</data>
|
||||
<data name="SqlScriptFormatterMultipartDecodeFail" xml:space="preserve">
|
||||
<value>Multipart identifier is incorrectly formatted</value>
|
||||
<comment></comment>
|
||||
</data>
|
||||
</root>
|
||||
|
||||
Reference in New Issue
Block a user