Fixing GetServerSystemInfo for Azure DBs (#1231)

* Not throwing errors when we try to fetch SQL server properties like server count and physical mem.

* Fixed comment

* Renaming get server cpu count

* Adding more detailed comment over here

* Making properties cpu count and physical memory to nullable<int> so they are defaulted to null.

* Fixing rest of the properties to nullable.
This commit is contained in:
Aasim Khan
2021-08-09 17:24:04 -07:00
committed by GitHub
parent 71b87055f1
commit f8664641cf
2 changed files with 13 additions and 9 deletions

View File

@@ -3,6 +3,7 @@
// Licensed under the MIT license. See LICENSE file in the project root for full license information.
//
using System;
using System.Collections.Generic;
namespace Microsoft.SqlTools.ServiceLayer.Connection.Contracts
@@ -70,12 +71,12 @@ namespace Microsoft.SqlTools.ServiceLayer.Connection.Contracts
/// <summary>
/// The CPU count of the host running the server.
/// </summary>
public int CpuCount;
public Nullable<int> CpuCount;
/// <summary>
/// The physical memory of the host running the server in MBs.
/// </summary>
public int PhysicalMemoryInMB;
public Nullable<int> PhysicalMemoryInMB;
/// <summary>
/// Server options