2084 Commits

Author SHA1 Message Date
Leila Lali
ebfc5c57a5 Fixing some issues, added documents 2016-08-22 15:32:41 -07:00
Leila Lali
3f1d3cb9db Added a new request handler to return back the service version 2016-08-22 15:08:44 -07:00
benrr101
48c7bbaa9f Changing SqlParser version to a version with internals visible 2016-08-22 13:41:41 -07:00
benrr101
51defc1032 Adding correct line numbers for errors 2016-08-22 13:04:12 -07:00
benrr101
91ed9aea59 Cleanup for comments/copyright 2016-08-22 12:04:43 -07:00
Mitchell Sternke
4631f2083e Merge pull request #23 from Microsoft/bug/intellisenseCacheTestFix
Fixed bug in intellisense cache test
2016-08-22 10:25:25 -07:00
benrr101
943c7b9569 Wrapping up batch separation
Adding unit tests
Fixing things that got brought up from the unit tests
2016-08-19 18:24:20 -07:00
Mitchell Sternke
a5992997e1 Removed factory from AutoCompleteService 2016-08-19 17:53:49 -07:00
benrr101
c719ed4598 Moving to official moq version 2016-08-19 15:42:05 -07:00
benrr101
1360fe7bde Merge branch 'dev' into feature/queryBatchProcessing 2016-08-19 15:31:02 -07:00
Benjamin Russell
22a2e113e5 Merge pull request #22 from Microsoft/feature/queryExecuteServerMessages
Bug fix: Messages not returned on SELECT queries
2016-08-19 15:23:00 -07:00
benrr101
f72ae9ac07 WIP adding unit tests for batch processing 2016-08-19 15:22:10 -07:00
benrr101
7202a7ed65 WIP update to support batch processing 2016-08-18 17:49:16 -07:00
Karl Burtram
1c90add7e0 Merge pull request #24 from Microsoft/feature/updatesqlparserversion
Update Microsoft.SqlServer.SqlParser nuget package version
2016-08-18 15:51:44 -07:00
Karl Burtram
cd2488e148 Update Microsoft.SqlServer.SqlParser nuget package version 2016-08-18 15:30:11 -07:00
Mitchell Sternke
b928516f58 Fixed bug in intellisense cache test 2016-08-18 15:24:04 -07:00
benrr101
8a8104b4cf Fixing bug where select returns no messages 2016-08-18 15:14:38 -07:00
benrr101
45daa6b2d7 Merge branch 'dev' into feature/queryExecuteServerMessages 2016-08-18 14:43:37 -07:00
Karl Burtram
a37d9babc9 Merge pull request #21 from Microsoft/feature/fixmacbuild
Update nuget.config to private nuget server
2016-08-17 22:35:11 -07:00
Karl Burtram
150e61a5a6 Update nuget.config to private nuget server 2016-08-17 22:31:04 -07:00
benrr101
dee490341d Stubbing out query execution settings
Adding a setting for batch separator.
Very small refactor to WorkspaceService that will create the basic
settings upon construction of the object.
2016-08-17 18:24:20 -07:00
Benjamin Russell
e9814435d8 Merge pull request #18 from Microsoft/feature/queryCancellation
Adding support for query cancellation
2016-08-16 16:15:13 -07:00
benrr101
709123eaaf Final iteration, fixing a couple mistakes for query exceptions 2016-08-16 16:14:27 -07:00
Mitchell Sternke
91b28127ce Merge pull request #19 from Microsoft/dev_intellisenseCacheTests
Added initial tests for the connection manager's intellisense cache
2016-08-16 15:55:24 -07:00
Mitchell Sternke
41172f0d0a Merge branch 'dev_intellisenseCacheTests' of https://github.com/Microsoft/sqltoolsservice into dev_intellisenseCacheTests 2016-08-16 15:54:14 -07:00
Mitchell Sternke
e33df61dc3 Addressing code review feedback 2016-08-16 15:53:00 -07:00
Mitchell Sternke
c80a90331d Added initial tests for the connection manager's intellisense cache 2016-08-16 15:32:36 -07:00
Mitchell Sternke
3ba4a93463 Merge pull request #20 from Microsoft/feature/connectionCleanup
Cleaned up connection management code
2016-08-16 15:29:27 -07:00
Mitchell Sternke
6ffdf644ba Addressing code review feedback 2016-08-16 15:27:26 -07:00
Mitchell Sternke
a6cc14d31f Cleaned up connection management code 2016-08-16 13:48:36 -07:00
Benjamin Russell
c38ca5f6b8 Merge pull request #17 from Microsoft/bug/exceptionLoop
Fix: Infinite Exception Loop, Plaintext Password Logging, Ever-expanding Message Buffer
2016-08-16 12:36:03 -07:00
benrr101
71d852ba07 Renaming the hosting error method 2016-08-16 12:35:39 -07:00
benrr101
981c144bfe Merge branch 'dev' into bug/exceptionLoop 2016-08-16 12:29:02 -07:00
benrr101
9fa183ea6d Fixing String.Format to string.Format 2016-08-16 12:28:52 -07:00
Mitchell Sternke
b7f88084c0 Added initial tests for the connection manager's intellisense cache 2016-08-16 12:21:42 -07:00
Benjamin Russell
062c40368d Adding support for query cancellation
Query cancellation support is added via CancellationToken mechanisms that
were implemented previously. This change adds a new request type
"query/cancel" that will issue the cancellation token. Unit tests were
also added.
2016-08-15 15:23:07 -07:00
Benjamin Russell
3981b1d544 Merge pull request #16 from Microsoft/feature/queryExecuteServerMessages
Server Message Support for Query Execution
2016-08-15 14:18:09 -07:00
Benjamin Russell
1acc8c9122 Fixing up error logging
Fixing issue where plaintext passwords could be written to logs
Fixing up todo issues where error events needed to be passed back from the
service layer when the hosting component fails.
2016-08-12 17:38:41 -07:00
Benjamin Russell
ba144bd5d0 Unit tests for the message reader 2016-08-12 17:37:07 -07:00
Benjamin Russell
fe79f6e85c Fixing infinite exception loop bug
Fixing issue where submitting a malformed JSON RPC request results in the
message reader entering into an infinite loop of throwing and catching
exceptions without reading anything from the input stream.

At the same time, this change also fixes a potential memory leak where the
message read buffer is never reinstantiated or shrunk. This issue is fixed
by shifting buffer contents after a message was read successfully, or if
an error occurs during parsing.
2016-08-12 15:37:16 -07:00
Benjamin Russell
c596a0db7a Small tweaks to query execution
* Adding comments where missing
* Adding "# rows affected" only if there was 0 or more
2016-08-11 17:41:18 -07:00
Benjamin Russell
9890e828bd Adding unit tests to the updated message mechanism 2016-08-11 16:39:33 -07:00
Benjamin Russell
1be4daf41d Adding enhanced support for messages from server
* Adding error flag for Query class
* Adding message capture for messages from server (using SqlConnection
cast)
* Adding better handling of SELECT queries with 0 results
* Adding affected row count message
* Adding SqlError unwrapping (using SqlException cast)
* Removing DbException handling from QueryExecutionService and into Query
class
2016-08-11 15:45:59 -07:00
Benjamin Russell
a2983539a7 Merge branch 'feature/queryExecutionV1' into dev 2016-08-10 16:55:22 -07:00
Benjamin Russell
793ad383c1 Small bug fix for unit tests 2016-08-10 16:54:56 -07:00
Benjamin Russell
20e465c528 Merge pull request #15 from Microsoft/feature/queryExecutionV1
Query Execution v1
2016-08-10 16:44:34 -07:00
Benjamin Russell
68c25f506e Adding changes as requested for code review 2016-08-10 16:40:36 -07:00
Benjamin Russell
8167330e16 Finishing up unit tests 2016-08-10 15:14:56 -07:00
Benjamin Russell
430860dd5d Merge branch 'dev' into feature/queryExecutionV1 2016-08-09 11:15:22 -07:00
Benjamin Russell
d783fd505b Second batch of unit tests
Making slight changes to RequestContext to make it easier to mock
2016-08-09 11:10:54 -07:00