Fixing issue where plaintext passwords could be written to logs
Fixing up todo issues where error events needed to be passed back from the
service layer when the hosting component fails.
Fixing issue where submitting a malformed JSON RPC request results in the
message reader entering into an infinite loop of throwing and catching
exceptions without reading anything from the input stream.
At the same time, this change also fixes a potential memory leak where the
message read buffer is never reinstantiated or shrunk. This issue is fixed
by shifting buffer contents after a message was read successfully, or if
an error occurs during parsing.
* Adding error flag for Query class
* Adding message capture for messages from server (using SqlConnection
cast)
* Adding better handling of SELECT queries with 0 results
* Adding affected row count message
* Adding SqlError unwrapping (using SqlException cast)
* Removing DbException handling from QueryExecutionService and into Query
class
- Basic plumbing to support connections for a URI rather than global connections. Typical use case is editor requests to connect, but this isn't the only possible use
- Tests pass but need updating to cover new functionality, and re-enable AutoCompleteService test once there is a ServiceDiscovery component that registers and returns services. This is necessary as .Instance won't allow for dependency injection and proper testing.
This is a fairly minor change that will save tons of time as we develop
this service. The DbConnection and associated Db* abstract classes
ask for synchronous versions of the code and allow the addition of async
code. The SqlClient implementation already implements Db* abstract
classes, so we can piggy back off that for our dependency injection layer.
Tests and existing code has been updated to handle the change, as well
For whatever reason, Visual Studio throws a fit if a referenced project has a name
and the folder name (which is used to reference the project) is different than that name.
To solve this issue, I've renamed all the projects and folders to match their project
names as stated in the project.json.
- Handles errors when connecting
- Adds method to capture the settings so the connection service can use these. Expect to read settings from here (and possible connections) in the future
- Minor rename to the test namespace to be consistent with refactor
* Removing unused OutputType and OutputWrittenEventArgs classes
* Adding class comment blocks
* Tweaking a couple comment blocks as per @kcunanne comments
* Merge master to dev (#4)
* Misc. clean-ups related to removing unneeded PowerShell Language Service code.
* Remove unneeded files and clean up remaining code.
* Enable file change tracking with Workspace and EditorSession.
* Setup standard src, test folder structure. Add unit test project.
* Actually stage the deletes. Update .gitignore
* Integrate SqlParser into the onchange diagnostics to provide error messages.
* Add tests for the language service diagnostics
* Initial implementation for autocomplete.
* Switch to using sys.tables for autocomplete
Move some code into a better class
* Delete unused csproj file.
* Add nuget.config to pickup SQL Parser nuget package
