Commit Graph

837 Commits

Author SHA1 Message Date
Alex Ma
4ae9534ac8 Added retry policy for sleeping serverless error for SqlConnections (#2155) 2023-08-16 13:17:40 -07:00
Sai Avishkar Sreerama
e4db70fb39 Enabling Database scoped configurations tab to DB Properties (#2147)
* sending dsc values to ADS

* modifying dsc method with unsupportable property IsValuedefault

* getting the options and added a bool flag to maintian checkbox for secondary to save

* sending data to ads

* Ready for PR with minimal changes of loading UI as expected, TODO:saving logic

* Excluding maxdop and resumable options from primary value conversion for 1/0's

* Adding Id to the info, as we cannot depend on names, as names can be altered in future

* saving successfully, todo-diff servers, script (secondary - primary compare and dont update),test, send null for unsupported

* adding nullable dsc for unsupported servers

* fixing script generation for some properties that are not touched. the generated script is unharmed but unnecessary here

* adding test conditions for database scoped configurations

* adding switch case method to get the values

* Removing Loc string for the TSQL options

* removing unnecessary using statement

* Adding test case and fixing createDatabase issue

* Update src/Microsoft.SqlTools.ServiceLayer/Admin/Database/DatabasePrototype130.cs

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* comment update

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-08-15 11:58:35 -05:00
Cory Rivera
7c0da6b6b1 Add extra delete database functionality to DatabaseHandler (#2168)
* Also fixed connections not being properly closed in Detach operations
* Fixed errors being thrown in InitializeObjectView because certain db property fields are not supported against Azure
2023-08-11 13:06:35 -07:00
Cheena Malhotra
0820d9796a Convert Async to sync (SqlClient apis) and cleanup async usage (#2167) 2023-08-09 15:03:02 -07:00
Charles Gagnon
969ac0ed8c Use Logger overloads (#2163) 2023-08-02 13:25:21 -07:00
Cory Rivera
46fa477717 Provide default indexes for database option values instead of reordering options lists (#2156)
* Also re-add <default> to owners list for new database dialog
2023-07-27 16:11:49 -07:00
Cheena Malhotra
8a898837dc Fix app name and connection string defaults to match extension defaults (#2132) 2023-07-10 15:02:52 -07:00
Barbara Valdez
e14828e0d4 Send min and max values for server properties (#2130) 2023-07-07 13:03:25 -07:00
Barbara Valdez
8dfd50ff50 disable test (#2131) 2023-07-07 08:45:20 -07:00
Barbara Valdez
4c4d6584b3 Update memory settings and implement ServerPrototype (#2126) 2023-07-06 17:25:45 -07:00
Sai Avishkar Sreerama
11f632aaa9 Sai/db properties options tab (#2121)
* Sending values to ADS, including the arrays, need refactor and tests

* adjusting dd options as per ssms

* sending back the updated options properties to smo

* saving changes

* pulling correct database name changes

* Refactoring

* saving is working fine

* Added genral tab section options for the option tab

* modifying userAccess and pageVerify props types

* fix for database name being master for always for existing database

* Managed Instance save error fixed

* added new assertions to the test case

* server engine edition conditions handling from ADS side

* Adding unsupported options approach to the properties, so that these nullable options can be excluded from UI

* modifying the props name

* modified empty string to null

* Test case update
2023-07-06 13:48:11 -04:00
Barbara Valdez
c2d53a3215 Get server general properties (#2117)
* add server handler

* get server general properties
2023-06-28 16:39:37 -07:00
Aasim Khan
6b251bd24a Adding like filter and removing contains to OE filtering (#2105)
* Adding startswith and like filter

* Adding ends with

* Adding tests

* Remove null and not null

* Fixing string

* Update test/Microsoft.SqlTools.ServiceLayer.UnitTests/ObjectExplorer/NodeFilterTests.cs

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update test/Microsoft.SqlTools.ServiceLayer.UnitTests/ObjectExplorer/NodeFilterTests.cs

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Adding back contains, starts with and ends with

* Properly escaping chars for like based filters

* Adding some comments regarding escape characters

* Using generated regex

* removing additional class

* Adding extra auth type that was causing the tests to error out

* Fixing regex

* Adding integration tests

* Fixing unit tests

* Making fluent assertions

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-06-28 16:17:20 -07:00
Sakshi Sharma
4334d79d76 Add "Open XEL file" support to profiler in sqltoolsservice (#2091)
* Open XEL file changes

* placeholders for openxel

* add observable xe reader

* md format tweaks

* implement localfile as a new session type

* add ErrorMessage to session stopped notice

* fix flaky test

* handle already running session

* fix stopped session event send on file completion

* fix flaky unit test

* Update XElite and dependent versions

* Fix errors after merge and remove failing tests for now

* Fix main merge mess-up.
Address comments.
Add one more relevant test.

* Remove extra namespace.

* Remove unnecessary import

* Fix build error

* Address comments.

* Remove disabiling JSON002 compiler warning

* Address comments and update json handling

* Fix build error

* Fix integration test (emerged due to Main merge mess up)

* Clean up code (no functional changes)

---------

Co-authored-by: Karl Burtram <karlb@microsoft.com>
Co-authored-by: shueybubbles <david.shiflet@microsoft.com>
2023-06-27 14:25:18 -07:00
Kim Santiago
95a094438e Fix for schema compare dropping constraints (#2120)
* fix for scripts that are displayed in schema compare drop constraints bug

* update DacFx version

* add more comments
2023-06-26 14:01:28 -10:00
Charles Gagnon
9034b397ac Error on CS8600 (#2112)
* Error on CS8600

* couple more
2023-06-26 08:52:51 -07:00
Cory Rivera
9d0d4b0cae Enable Detach Database in database handler (#2110) 2023-06-22 17:28:41 -07:00
Sai Avishkar Sreerama
5c7dae40e6 Enabling database properties general tab with real time values from SMO (#2093)
* initial commit with all required db handler and props, also getting the data from ADS

* database properties view updated

* Delete Microsoft.SqlTools.ServiceLayer.sln

This file should be ignored

* Removed unwanted file

* Using DatabaseHandler for properties as one handler per object

* removed unused and unnecessary changes

* minimal updates

* moving type conversion to UI side, properties with original types.

* conversion number fixed

* Adding Localized strings

* using existing objectUrn logic to get the smo object

* Adding Integration tests for database properties verification

* refactoring

* updating test
2023-06-21 19:41:18 -05:00
Alan Ren
7f6b357eb0 fix delay in query execution (#2109)
* fix delay in query execution

* fix test case
2023-06-19 16:31:47 -07:00
Alex Ma
6fe0b300e5 Restore new connection string for multiple similar connections (#2067) 2023-06-15 23:31:40 -07:00
Cory Rivera
c92bc71454 Exclude Data Warehouse as an option when creating an Azure database (#2100) 2023-06-13 16:04:23 -07:00
Cory Rivera
808172bc20 Retrieve Azure SLO details in Database Handler (#2094) 2023-06-12 11:44:17 -07:00
Cory Rivera
0ad169781e Replace <default> values in Owner and Collation fields for Create Database dialog (#2086) 2023-06-02 16:19:00 -07:00
Kim Santiago
a12244f3d0 Add support for adding system db references as PackageReference (#2078)
* Expose adding system db references as PackageReference

* update nuget
2023-06-01 11:38:28 -07:00
Cory Rivera
0a5a7b4cc5 Address remaining comments for Object Management Database Handler (#2081) 2023-06-01 11:02:59 -07:00
Cory Rivera
d5cfc52ca7 Add object management handler for creating a database (#2071) 2023-05-31 12:55:12 -07:00
Cheena Malhotra
b4f7bd01af Fix email extraction from username (#2075) 2023-05-30 14:46:18 -07:00
Cory Rivera
97988661ec Load TrustServerCertificate value from connection settings when running integration tests. (#2074) 2023-05-22 17:18:19 -07:00
Hai Cao
d525e88672 Add securable search and permission setting to User Management (#2052) 2023-05-10 18:20:06 -07:00
Aasim Khan
46e6b484a3 Adding filtering support to OE (#2039)
* Init push

* Fixing filters

* Fixing more filters

* Fixing display strings

* Fixing boolean filter

* Adding comments

* Fixing function name

* Making nullables

* Separating filter parsing logic

* Adding tests

* Update src/Microsoft.SqlTools.ServiceLayer/ObjectExplorer/ObjectExplorerUtils.cs

Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>

* Update src/Microsoft.SqlTools.ServiceLayer/ObjectExplorer/ObjectExplorerUtils.cs

Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>

* Update src/Microsoft.SqlTools.ServiceLayer/ObjectExplorer/Contracts/NodeInfo.cs

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update src/Microsoft.SqlTools.ServiceLayer/ObjectExplorer/Contracts/NodeInfo.cs

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update src/Microsoft.SqlTools.ServiceLayer/ObjectExplorer/Nodes/TreeNode.cs

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Adding comments

* Fixing whitespace

* Adding more  comments and changing to IEnumerable

* Fixing code comments

* Fixing tests adding more filters

---------

Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-05-06 01:52:42 +05:30
Cheena Malhotra
1b5f774741 Reverting Connection URI related changes for stable release (#2042) 2023-05-05 10:11:54 -07:00
Benjin Dubishar
c21203c5c2 Adding ability to only load properties and metadata for a SqlProject (#2040)
* Adding property quick-loading

* Remove whitespace
2023-05-03 18:44:17 -07:00
Alan Ren
5dbed25c40 change user type implementation (#2036)
* change user type implementation

* fix build errors
2023-05-01 10:27:00 -07:00
Sakshi Sharma
3e0135b907 Update STS changes to be backward compatible with scmpOpen (#2031)
* Update STS changes to be backward compatible with scmpOpen

* Update cleanup code

* Fix test.
2023-04-24 16:58:06 -07:00
Benjin Dubishar
c5cdc4712a Adding move and exclude folder to SqlProjectService (#2027)
* Adding move and exclude folder

* Fixing cross-plat path bug in test
2023-04-21 11:46:11 -07:00
Simon Sabin
96c5ec81e2 Enable empty passwords (#2021) 2023-04-20 08:49:47 -07:00
Benjin Dubishar
006488340c Updating DacFx.Projects to 162.0.28 (#2019) 2023-04-19 20:12:56 -07:00
Alan Ren
e314f839d8 Simplify Object Management APIs (#2015)
* unify requests-wip

* wip

* unify api

* fix test

* add credential handler

* fix credential handler issue.

* generic type update

* fix scripting for user
2023-04-19 15:43:01 -07:00
Cheena Malhotra
648d7dbd3c Address warnings and (some) nullables (#2013) 2023-04-18 20:57:13 -07:00
Alex Ma
add216cc1e Add more specific URI strings to Object Explorer (#1881)
* Added all non null properties to URI generator

* Added all options to URI for session

* added documentation comments

* added generated nodeTypes file

* added updated uri to connection store

* Added debug message for integrated test failure

* Revert "Added debug message for integrated test failure"

This reverts commit 026c53d1ed3fb16b0f37b7b6e0775402a2ef9281.

* added advanced options to table designer table

* removed connectionName from uri generation

* Revert "removed connectionName from uri generation"

This reverts commit 88eedbbc593a0279872edc6d4cbd1b7ca3d72ad0.

* added connectionname to connection details

* added connection name to near front of key
2023-04-17 14:24:12 -07:00
Kim Santiago
13672c1d05 Add support for nupkg database references in sql projects (#2006)
* add support for nupkg database references in sql projects

* update DacFx.Projects
2023-04-14 16:18:06 -07:00
Karl Burtram
948ae3903e Support scripting for Users (#2002)
* WIP 1

* WIP2

* Fix merge break

* Support alter existing object
2023-04-13 11:52:37 -07:00
Sakshi Sharma
9aa84f517c Send deploymentOptions to DacFx to save in the publish profile xml file (#1997)
* Send deploymentOptions to DacFx to save in the publish profile xml file

* Update Packages.prop with latest DacFx nuget version.

* Update Dacfx version after merge from main.

* Address comments

* Update method name
2023-04-10 17:31:39 -07:00
Karl Burtram
83b58a27a4 Move Login handlers to separate file (#1995)
* Move login handlers

* Move Login handlers to seperate file
2023-04-06 16:07:45 -07:00
Sakshi Sharma
098cf3be35 Update openScmp to read file structure (#1952)
* Update openScmp to read file structure (and dsp) information from the scmp file.

* Address comments
2023-04-04 11:05:36 -07:00
Cheena Malhotra
463fc60330 Move back 'Shared' content to 'Hosting' assembly (#1967) 2023-03-24 15:07:02 -07:00
Chris LaFreniere
cccdbf0bef Address CA1829 (Avoiding Count LINQ method calls when equivalent + more efficient properties exist) (#1961)
* Address CA1829 (Avoid Count LINQ Method Calls)

* Remove other change

* CA1829 removal

* CA1829 (remove whitespace)
2023-03-23 21:06:49 -07:00
Cheena Malhotra
3ef3a0f022 Secure enclave touch ups (#1964) 2023-03-23 20:59:38 -07:00
Karl Burtram
c3444e5cf5 Support creating & editing additional user types (#1962)
* WIP

* Fix contained user password handling

* More user related bug fixes
2023-03-23 18:01:55 -07:00
Karl Burtram
a104251885 Enable support for Windows users (#1957)
* WIP

* Update for Windows user
2023-03-21 19:00:11 -07:00