Commit Graph

913 Commits

Author SHA1 Message Date
Justin M
516553f72a Default Kusto database name (#1187)
* Added check to set the databaseName to the first database on the cluster when no database is provided

* Changed kusto query for loading databases to follow best practices

* Fixed failing unit test

* Optimized query for getting first database
2021-04-13 00:00:56 -07:00
Justin M
c483cea88c Renamed RefreshAzureToken to RefreshAuthToken. Changed provider value to authenticationType. (#1183) 2021-03-29 15:08:09 -07:00
Christopher Suh
2badd8e728 Fix Sql Auth for Migration Assessments (#1182)
* pass connection string to dma engine

* cleanup

* remove optional parameter

* modified query
2021-03-26 15:59:07 -07:00
Aasim Khan
5a8cfab8fa Sending assessment errors to ads (#1180) 2021-03-22 09:14:02 -07:00
Christopher Suh
0a1ee88a12 Bumped Migration Assessment Version (#1179)
* bump migration assessment nuget

* upgraded migration version
2021-03-19 22:46:51 -07:00
Christopher Suh
0f4767aa6c Added Server Name (#1176)
* added DatabaseName field

* added servername
2021-03-16 18:40:14 -04:00
Justin M
c204cd7848 Removed catch block around ExecuteQueryAsync to allow exception to bubble up and be returned to ADS. (#1169) 2021-03-04 11:12:21 -08:00
Christopher Suh
8fb6474cf0 added DatabaseName field (#1166) 2021-02-23 21:32:02 -05:00
Justin M
13a7d4aa2b Kusto NoAuth authentication (#1161)
* Added username and password to DataSourceConnectionDetails. Refactored KustoClient>GetKustoConnectionStringBuilder to accept no username or password for no credentials authentication.

* Removed invalid Unit Test and added 2 unit tests for testing authentication type.

* Added validation for dstsAuth and AzureMFA in DataSourceFactory. Added unit test for validation.
2021-02-23 17:29:09 -08:00
Alan Ren
f75be77138 add visualization option support (#1160)
* add visualization option support

* add comments
2021-02-11 15:40:29 -08:00
Charles Gagnon
326488b1f7 Update resx with latest changes (#1159) 2021-02-03 14:34:38 -08:00
Karl Burtram
9fc5dfa647 Add thirdpartynotices.txt file to package (#1152)
* Add thirdpartynotices.txt file to package

* Update Notice.txt file per feedback
2021-01-29 11:46:58 -08:00
Justin M
6f22dcf241 Kusto Auth Refactor Tests (#1148)
* Refactored Kusto.ServiceLayer to pass ConnectionDetails to DataSourceFactory instead of connection string. Created KustoConnectionDetails to map needed details to KustoClient.

* Removed unused ScriptingScriptOperation from KustoServiceLayer.

* Created DstsAuthenticationManager and moved logic for getting DstsToken. Updated error message for failing to create KustoConnection.

* Removed DstsAuthenticationManager.cs. Refactored DataSourceFactory to retrieve UserToken from ConnectionDetails.

* Renamed AzureAccountToken in ConnectionDetails to AccountToken. Changed mapping to KustoConnectionDetails based on the AccountToken.

* Removed Kusto.Data reference from ConnectionService and ScriptingListObjectsOperation. Moved creation of KustoConnectionStringBuilder to DataSourceFactory

* Added accountToken validation to DataSourceFactory Create.

* Renamed KustoConnectionDetails to DataSourceConnectionDetails. Renamed AzureToken to AuthToken.

* Refactored SchemaState and intellisense out of KustoClient to KustoIntellisenseClient. Added IIntellisenseClient. Added unit tests for KustoIntellisenseClient and KustoClient.

* Removed unused property dataSourceFactory from LanguageService > InitializeService. Moved KustoIntellisense functions from KustoIntellisenseHelper to KustoIntellisenseClient and made SchemaState private. Added IIntellisenseClient to IDataSource.

* Renamed directory from DataSourceIntellisense to Intellisense and updated namespace. Fixed namespace in ScriptDocumentInfo.
2021-01-29 11:25:23 -08:00
khoiph1
eb0b774f39 updated localized files (#1150) 2021-01-21 15:19:17 -08:00
csigs
6d7be6c019 LEGO: check in for main to temporary branch. (#1149) 2021-01-20 21:33:52 -08:00
Leila Lali
01d0f03262 Added service for model management for machine learning extension (#1138)
* Added service for model management for ml extension
2021-01-19 11:33:55 -08:00
Justin M
f0a5e11d51 dSTS Authentication (#1125)
* Refactored Kusto.ServiceLayer to pass ConnectionDetails to DataSourceFactory instead of connection string. Created KustoConnectionDetails to map needed details to KustoClient.

* Removed unused ScriptingScriptOperation from KustoServiceLayer.

* Created DstsAuthenticationManager and moved logic for getting DstsToken. Updated error message for failing to create KustoConnection.

* Removed DstsAuthenticationManager.cs. Refactored DataSourceFactory to retrieve UserToken from ConnectionDetails.

* Renamed AzureAccountToken in ConnectionDetails to AccountToken. Changed mapping to KustoConnectionDetails based on the AccountToken.

* Removed Kusto.Data reference from ConnectionService and ScriptingListObjectsOperation. Moved creation of KustoConnectionStringBuilder to DataSourceFactory

* Added accountToken validation to DataSourceFactory Create.

* Renamed KustoConnectionDetails to DataSourceConnectionDetails. Renamed AzureToken to AuthToken.
2021-01-14 13:49:09 -08:00
Charles Gagnon
822ffb2908 Remove invalid SET option for SqlOnDemand (#1147) 2021-01-11 09:08:50 -08:00
khoiph1
72fa41ca15 new loc files (#1136) 2021-01-06 10:44:36 -08:00
Charles Gagnon
5c7211e82a Include singleline comments outside batch for nb convert (#1139)
* Include singleline comments outside batch for nb convert

* Remove extra space
2020-12-14 15:16:07 -08:00
Alex Ma
fefcab1c04 Added new String Resource Tool to fix issue (#1129) 2020-12-01 11:49:31 -08:00
Benjin Dubishar
0954502033 Renamed file (#1127) 2020-11-25 15:01:15 -08:00
Benjin Dubishar
25c542319e Splitting out default DacFx options for Publish and Schema Compare (#1126)
* Splitting out schema comp and publish defaults

* Added test

* Correcting comments, changing scope

* Moving DeploymentOptions to DacFx folder due to dependency hierarchy between DacFx and SchemaCompare
2020-11-25 14:44:34 -08:00
Justin M
fd84367008 4094 Kusto AAD Authentication Refactor (#1115)
* 4094 Upgraded Kusto.Data and Kusto.Language to 9.0.3. Refactored KustoServiceLayer to use KustoConnectionStringBuilder instead of Sql.

* 4094 Refactored KustoClient>Initialize to take connectionString as optional. Removed unused properties from ConnectionService>ParseConnectionString

* 4094 Updated Kusto.Data and Kusto.Language nuget packages to 9.0.4. Removed IsDedicatedAdminConnection function in ConnectionService.

* 4094 Fixed unit tests
2020-11-20 11:54:40 -08:00
Justin M
67c7e20c13 13159 Created SetDatabaseName in KustoClient to take database name from ( ). Changed ListDatabases in Kusto ConnnectionService to set DatabaseNames in a different format when the PrettyName doesn't match the name. (#1123) 2020-11-19 14:18:58 -08:00
Justin M
30d600e423 Kusto Client Cleanup (#1102)
* Cleaned up KustoClient with formatting and switched logic between ExecuteCommandAsync and ExecuteQueryAsync to match their respective names.

* Refactored ExecuteControlCommandAsync to call ExecuteControlCommandAsync in KustoAdminProvider. Fixed spacing in GetClientRequestProperties

* Refactored ExecuteQueryAsync to not use Task.Run
2020-11-17 10:26:09 -08:00
Charles Gagnon
32d7a63d7c Send error result if parse error occurs during convert (#1121) 2020-11-16 13:48:30 -08:00
Aleksei Guzev
11960fd904 Fix handling some SQL Assessment warnings (#1114)
* Some new SQL Assessment warnings may have Check property set to null. Handle the warnings with no exception.
* Make names of SQL Assessment test methods more informative.
2020-11-04 22:13:46 +03:00
Justin M
954df47ec9 13159 Kusto Aria Fix (#1112)
* 13159 Changed NodeValue in TreeNode to PrettyName instead of Name. In KustoDataSource, changed Exists to run different query for Aria. Changed GetClusterDiagnostics to return empty DiagnosticsInfo for Aria. Changed SetDatabaseMetadata to not includeSizeDetails for Aria connections.

* 13159 Fixed unit test Refresh_Returns_Children
2020-11-02 15:35:37 -08:00
Benjin Dubishar
65c4fc01aa Adding External Streaming Job I/O validation to DacFxService (#1106)
* checkpoint

* Not having cake, nor eating it

* Working

* Swapping external dll for nupkg

* Extracting statement out of full TSQL

* Improving error message

* Fixing filename capitalization

* Reverting csproj changes

* Adding updated sr.cs file

* VS lost tracking on strings file?

* PR feedback

* resx additions

* More updated string files

* Swapped nuget for dll

* Revert "Swapped nuget for dll"

This reverts commit 6013f3fadf58ebc7e3590a46811d9fd9fc3eaa4a.

* Bumped netcore version to pull in support for extern aliasing nugets
2020-11-02 12:03:14 -08:00
Christopher Suh
d94e691b07 Fix logic for result (#1113)
* commented subscription caching

* added additional code path if user.UniqueId not set

* fixed failing unit tests

* updated logic
2020-11-02 09:44:30 -05:00
Benjin Dubishar
271a0f5733 Updated loc build outputs (#1110) 2020-10-30 14:04:56 -07:00
Christopher Suh
71a98eacf4 Add handling of user.UniqueId if not set (#1109)
* commented subscription caching

* added additional code path if user.UniqueId not set

* fixed failing unit tests
2020-10-30 13:25:07 -04:00
Charles Gagnon
b3bd1f8f99 Revert "Added additional code path if user.UniqueId not set (#1105)" (#1108)
This reverts commit 2354dfc4c7.
2020-10-30 09:17:06 -07:00
BranislavGrbicMDCS
4ce9416219 removing server roles for sql od (#1107) 2020-10-30 08:15:29 -07:00
Christopher Suh
2354dfc4c7 Added additional code path if user.UniqueId not set (#1105)
* commented subscription caching

* added additional code path if user.UniqueId not set
2020-10-29 18:43:19 -04:00
Cory Rivera
8c805a72a9 Add a parent process ID argument to ServiceLayer so that we can exit gracefully if the parent process exits. (#1103) 2020-10-29 13:00:23 -07:00
BranislavGrbicMDCS
3e98a2f17b [brgrbic] SqlOD changes for cloud Server Type and minor bug fixes (#1092)
* The ServerType of SQL OD in SMO is being changed to cloud. This is a minimal set of changes needed in sqltoolservice in order to keep everything working within ADS.

* SMO version update
2020-10-23 18:48:33 +02:00
Monica Gupta
dbfcf4ad61 Fix for queries with comments separated by new lines (#1101)
* Fix for queries with comments separated by new lines

* Mimic Kusto behaviour for comments ran as query

* extra check

* address comment

Co-authored-by: Monica Gupta <mogupt@microsoft.com>
2020-10-20 13:53:34 -07:00
Charles Gagnon
9b9325b43e Split sql batches into separate code cells for convert (#1100)
* Split sql batches into separate code cells for convert

* remove unneeded sort
2020-10-16 16:31:40 -07:00
Karl Burtram
b9e1618260 Revert "Rollback migration changes" (#1099)
* Revert "Revert "Initial migration service changes for assessment support (#1093)" (#1098)"

This reverts commit e96c0064ad.

* Move SQL Tools Service last in Main project list
2020-10-16 16:29:22 -07:00
Charles Gagnon
e96c0064ad Revert "Initial migration service changes for assessment support (#1093)" (#1098)
This reverts commit 1a0388c8cb.
2020-10-16 13:35:59 -07:00
Charles Gagnon
b64d5a3146 Fix Notebook Convert namespace (#1097) 2020-10-16 12:27:54 -07:00
Karl Burtram
1a0388c8cb Initial migration service changes for assessment support (#1093)
* Migration service WIP 1

* Assessment DLLs

* WIP

* WIP 2

* Add migration nuget package

* WIP2

* Fix up assessment handler

* WIP

* Fix build scripts

* WIP

* Update Assessment references

* Fix metadata copy to work with publish
2020-10-13 11:02:29 -07:00
Monica Gupta
1ee0c1d09a Make Kusto control commands work (#1094)
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
2020-10-08 17:51:08 -07:00
Justin M
a94ab9d8b4 Changed logic to use database name provided by connectionString (#1091) 2020-10-06 20:45:54 -07:00
Justin M
f2eb590d97 3490 Kusto Connection Refresh Fix (#1085)
* 3490 Injected OwnerUri into KustClient to store for token refreshing. Removed UpdateAzureToken from IDataSource, DataSourceBase, and KustoDataSource. Removed logic for retrying queries related to Unauthorized datasource in Batch and Query. Changed ScriptingService, ScriptingScriptOperation, and ScriptAsScriptingOperation to take DataSource in the constructor instead of datasourcefactory. Changed ScriptingService to inject ConnectionService through InitializeService function.

* 3490 Removed Catch block for DataSourceUnauthorizedException in ExecuteControlCommandAsync

* 3490 Removed OwnerUri from KustoClient and used azureAccountToken to refresh token in ConnectionService.

* 3490 Reverted unneeded changes.

* 3490 Split ExecuteQuery in KustoClient to execute first query then remaining queries after

* 3490 Passed OwnerUri down into KustoClient to refresh token.

* 3490 Removed DataSourceUnauthorizedException. Refactored ExecuteQuery to catch aggregate exception. Added RefreshAzureToken logic to ExecuteControlCommand

* 3490 Added logic to update ReliableDataSourceConnection azure token within ConnectionInfo.

* 3490 Add retry logic to ExecuteQuery and ExecuteControlCommand in KustoClient
2020-10-06 17:20:13 -07:00
Justin M
2b022d2e48 3326 Kusto HTTPS url fix (#1086)
* 3326 Removed sqlConnection.Open from CreateSqlConnection in ConnectionService.

* 3326 Removed unused variables and functions from ConnectedBindingContext, ConnectedBindingQueue, IBindingContext, and IConnectedBindingQueue

* 3326 Removed unused constant SqlAzureEdition and unused functions CreateSqlConnection and CreateServerConnection from ConnectionService. Removed ServerConnection, MetadataDisplayInfoProvider, Binder, and SmoMetaDataProvider from ConnectedBindingContext. Deleted SqlConnectionOpener and ISqlConnectionOpener.
2020-10-05 00:56:40 -07:00
Monica Gupta
164ca951da Fix for multiple queries separated by space for Kusto (#1089)
* Fix for multiple queries separated by space

* Addressed comments

Co-authored-by: Monica Gupta <mogupt@microsoft.com>
2020-10-04 19:12:33 -07:00
Charles Gagnon
725d4ba5db Fix Notebook->Sql convert to correctly handle multiline comments within a batch (#1087) 2020-10-02 08:27:57 -07:00