Commit Graph

837 Commits

Author SHA1 Message Date
Aasim Khan
6f5cac4cb5 Adding a flag for migration blocker flag in sql assessment and switching to new APIs (#1242)
* Adding a flag for migration blocker in sql assessment and switching to new APIs

* Fixing var names
2021-09-08 15:15:56 -07:00
Alex Ma
93728df53d update for resx with latest changes (#1240) 2021-09-01 11:06:43 -07:00
Christopher C
4bb89819bb Merge branch 'main' into v-chrcan/issue392 2021-08-30 13:29:11 -07:00
Alex Ma
431e4cfbf1 Add changeConnectionUri action for query (#1227)
* added wip rename query

* added first rename test

* added missing query handling and two new tests

* removed ServiceDispose

* added change to owneruri.

* made fields private, used accessor methods

* added readonly flag back

* added didSave to sqltools.servicelayer

* fix for docsavecallbacks

* removed tryremove

* test disconnect in queryExecutionService

* removed debug message working query.

* added comment to handlerenamerequest

* added uri replacement function

* removed duplicate removemap function

* added minor fixes

* changed connectionOwnerUri to getter setter

* removed handledidsave and added setters

* removed additional save parts

* fixed space issues

* more fixes for spaces

* restored spaces

* fixed workspaceservice

* Update TextDocument.cs

* changed renameRequest into notification WIP

* restored textdocument

* restored textdocument.cs

* added rightwards arrow

* renamed rename to ChangeConnectionUri

* added more renames

* rename changeconnectionuri to changeuri

* renamed file names

* Revert "renamed file names"

This reverts commit 55228e65025b5179b15ae9a0adc095d95538723d.

* Revert "rename changeconnectionuri to changeuri"

This reverts commit 23f3813f609e3947f103e057f7c0919184075bdc.

* removed logging message and other small changes

* renamed class and method
2021-08-30 11:06:07 -07:00
Karl Burtram
5d5debbad6 Enable scripting for subobjects such as triggers (#1237)
* WIP 1

* Cleanups

* Change how schema is appended in to urn

* Add comment and fix incorrect condition

* Add parent type name to support Views, etc.
2021-08-26 13:06:15 -07:00
Christopher C
1ac3cabe9b Merge branch 'main' into v-chrcan/issue392 2021-08-18 21:38:44 -07:00
Christopher C
6eb5b7668c updates to thread through maxCharsToStore 2021-08-18 21:38:12 -07:00
Kim Santiago
c20af4f777 Get Azure functions operation (#1228)
* add GetAzureFunctions

* add tests

* cleanup

* check for quotes

* address other comments

* add logging and let error result get sent

* rename file
2021-08-18 17:05:27 -07:00
Aasim Khan
f8664641cf Fixing GetServerSystemInfo for Azure DBs (#1231)
* Not throwing errors when we try to fetch SQL server properties like server count and physical mem.

* Fixed comment

* Renaming get server cpu count

* Adding more detailed comment over here

* Making properties cpu count and physical memory to nullable<int> so they are defaulted to null.

* Fixing rest of the properties to nullable.
2021-08-09 17:24:04 -07:00
csigs
71b87055f1 LEGO: check in for main to temporary branch. (#1230) 2021-08-09 11:17:12 -07:00
Aasim Khan
c5cbcf02a2 Removing unused code (#1229)
and adding a null check
2021-08-06 20:11:58 -07:00
Kim Santiago
b1653b25e4 Insert sql bindings into Azure Functions (#1224)
* getting table name from a script

* add InsertSqlInputBindingOperation

* cleanup

* move azure functions stuff out of dacfx service

* cleanup

* add tests

* add another test

* cleanup

* add comments and connection string setting

* addressing comments

* change name to use add instead of insert
2021-08-04 13:02:52 -07:00
Aasim Khan
a7703e63a4 Fixing the logic to retireve rule metadata in sql assessments (#1223) 2021-07-21 17:40:04 -07:00
Christopher Suh
d0f9af0a3e Enable Multiple Assessments (#1219)
* wip

* wip

* modified assessments to handle multiple DBs

* pr comment change

* cleanup

* cleanup

* cleanup
2021-07-21 11:20:16 -07:00
Aasim Khan
f25dd5d2a4 Adding server metadata to SQL Migration Assessment API (#1222)
* WIP

* Adding server metdata to assessment call

* Fixed spacing

* Sorted imports
Added copyright header
Changes some class names
Fixed description

* Fixed assessment result and removing unused imports

* Adding assessment result
2021-07-19 12:38:10 -07:00
Alex Ma
c731744298 Fix for deleting text columns (#928)
* Added handling for deleting problematic rows

* minor formatting changes

* Null checks and executereader implemented

* minor formatting

* Fix for column deletion for text

* minor space format

* more format changes

* Removal of top 200 and change of text comparison

* space fix

* minor commit

* Added new tests for single clause

* simplified regex

* spacing fix

* some polish for RowEditBaseTests

* space fix

* loc update (#914)

* loc update

* loc updates

* Warning for multiple delete (#931)

* Fix for multiple delete bug

* minor space removal

* removed catch error in RowDelete

* small optimizations

* space adding

* WIP on creating test

* Some cleanup

* removed spaces

* Fix for verifytext

* Added check for command format correctness.

* tidying up

* added working test for command exception

* simplification of TestDbDataReader getint

* Corrections made

* spacing and naming issues

* minor space

* one more space issue

* Revert "Support ActiveDirectoryPassword authentication (#899)" (#915)

This reverts commit b786a14c03.

* revert changes to connectionService

* fix for asserts

* fix clauses

Co-authored-by: khoiph1 <khoiph@microsoft.com>
Co-authored-by: Amir Omidi <amir@aaomidi.com>
2021-07-16 14:11:32 -07:00
Christopher Suh
0032cc684b Update Assessment Nuget Package (#1221)
* update nuget package

* point to new assessment nuget version

* cleanup
2021-07-15 15:28:34 -07:00
Aasim Khan
539e47b40f Adding cpu count and ram size to server info (#1220)
* adding network file validator contract

* Adding additional properties to serverInfo

* Renaming to serversysinfo

* fixing var name

* Changed to smo to get the properties

* Fixing casting error

* renaming to sysinfo

* Removing unused sql scripts

* Throwing an error and renaming classes

* Changing Physicalmemory prop name from kb to mb

* pushing prop name change

* fixing comment
2021-07-13 12:57:53 -07:00
Aasim Khan
9877af54b9 Updating to dotnet 5.0 (#1218)
* adding network file validator contract

* updating to dotnet 5

* reverting change in pipeline

* updating target framework to 5.0

* updating srgen and using target framework var

* reverting srgen back to 3.1

* Adding dotnet 3.1 to build

* Fixing task def

* removing global json

* updating other 3.1 refs to 5.0

* removing netcore folder from build.cake

* Moving and renaming dotnet 3.1 task
2021-06-25 13:53:01 -07:00
Christopher Suh
ae9ec03018 Update Assessment Nuget to Enable Logging (#1215)
* wip

* updated nuget package

* removed unused nuget

* updated assessment nuget to add logging

* added logs filepath'

* updated assessment nuget

* updated nuget
2021-06-15 10:49:20 -07:00
Alex Ma
993b094db9 Localization added to sqlservicetools (#1216)
* added other languages to ServiceLayer

* fixed travis and appveyor yaml, added other languages for localization

* added spanish and german strings to credentialslocalization, also WIP for coreservices test

* added WIP localization test for CoreServices

* Removed unit test for coreservices, need to work on those later.

* restored travis and appveyor

* added kusto string resource localization test

* added localization test and locale change for SqlToolsCredentials

* added locale command options to ResourceProvider

* revert resourceprovider test

* Localized SqlTools.Credentials

* added hosting localization

* replaced new with translation to be consistent with main service layer

* reverted external changes as it is unnecessary

* Translated ManagedBatchParser

* test culture value

* test culture change

* temporarily comment out service layer command options

* returned sr.cs

* temporarily remove bad tests

* restored tests and allowed for SR culture to change for dependencies (for future testing)

* localization for resourceprovider components added.

* Set LocaleSetter to public and also removed InternalsVisible for Kusto, Credentials and ResourceProvider

* removed unnecessary changes

* Removed CredentialsCommandOptions

* renamed pt-BR to pt-br

* Rename sr.pt-BR.xlf.template to sr.pt-br.xlf.template

* Rename src/Microsoft.SqlTools.ServiceLayer/Localization/LCL/pt-BR/sr.resx.lcl to src/Microsoft.SqlTools.ServiceLayer/Localization/LCL/pt-br/sr.resx.lcl

* Rename sr.pt-BR.xlf to sr.pt-br.xlf

* Rename sr.pt-BR.resx to sr.pt-br.resx

* Rename sr.pt-BR.resx to sr.pt-br.resx

* Rename sr.pt-BR.xlf to sr.pt-br.xlf

* Rename sr.pt-BR.resx to sr.pt-br.resx

* Rename sr.pt-BR.xlf to sr.pt-br.xlf

* Rename sr.pt-BR.resx to sr.pt-br.resx

* Rename sr.pt-BR.xlf to sr.pt-br.xlf

* Rename sr.pt-BR.resx to sr.pt-br.resx

* Rename sr.pt-BR.xlf to sr.pt-br.xlf

* Rename sr.pt-BR.xlf to sr.pt-br.xlf

* Rename sr.pt-BR.resx to sr.pt-br.resx

* Rename sr.pt-BR.xlf to sr.pt-br.xlf

* Rename sr.pt-BR.resx to sr.pt-br.resx

* restored newlines

* Update sr.pt-br.xlf.template

Removed newline

* removed newline

* fixing newlines for consistency

* removed unnecessary newline
2021-06-10 15:50:53 -07:00
Sai Avishkar Sreerama
37b2b26edf Filtering Schema Compare error from warnings (#1212)
* Filtering Schema Compare error from warnings

* SchemaCompare added comparison result error message validations to existing tests

* Extra semi-colon noticed and removed from the code

* Added new test case to validate warning message exclusions from SC result

* SC test asserions comment added

* Edge case scenario fixed and tests are 100% passed
2021-05-21 11:25:25 +05:30
Charles Gagnon
64a6b6a85c Fix intellisense parsing for Azure and MI connections (#1211)
* Fix intellisense parsing for Azure connections

* formatting

* Refactor to use compat level

* update logic

* Update log message

* spelling
2021-05-13 14:39:19 -07:00
Sai Avishkar Sreerama
6785940f1d SchemaCompare Unknown errors display fix with DacFx errors (#1188)
* SchemaCompare Unknown errors display fix with DacFx errors
2021-05-14 00:08:04 +05:30
Christopher Suh
21527637dc Update Assessment nuget (#1209)
* wip

* updated nuget package

* removed unused nuget
2021-05-11 15:26:13 -07:00
Alan Ren
27cb8f2f08 use new thread to handle requests (#1207) 2021-05-06 17:20:56 -07:00
Karl Burtram
63aa6758e8 Fix OE with dbpool connection (#1197)
* Fix OE with dbpool connection

* Remove extra whitespace

* Remove hard-coded number
2021-05-05 14:24:45 -07:00
Aasim Khan
add0724c21 Adding network share validation in sql migration. (#1203)
* adding network file validator contract

* Adding UNC path validation

* Using helper methods for sanity checks

* Fixed the validation variable type

* Fixing if condition
2021-05-04 15:16:31 -07:00
Aasim Khan
3ad2b2312a Adding windows account validation api for sql migration extensions. (#1202)
* Adding validate file share api

* Making message endpoint camel case

* Adding validation for windows username
2021-05-03 23:51:45 -07:00
Aasim Khan
10c24aaeb3 Fixing a notebook history bug in SQL Agent (#1199)
* Added a leading 0 to notebook history runtimes

* Fixing comment

* Fix for getting run date and time for notebook jobs in a proper format - Try2

* Reverting back to previous query
2021-04-28 16:52:24 -07:00
Charles Gagnon
dc6555a823 Escape file URIs (#1189)
* Escape file URIs

* Fix test

* Add tests
2021-04-16 15:33:11 -07:00
Karl Burtram
6fe715d2d8 Do not update the DB name when connecting to DB pool (#1186)
* Do not update the DB name when connecting to DB pool

* Fix typo in the connection service
2021-04-15 14:48:02 -07:00
Christopher Suh
6bafed10eb added rule id (#1190) 2021-04-15 12:02:32 -07:00
Christopher Suh
2badd8e728 Fix Sql Auth for Migration Assessments (#1182)
* pass connection string to dma engine

* cleanup

* remove optional parameter

* modified query
2021-03-26 15:59:07 -07:00
Aasim Khan
5a8cfab8fa Sending assessment errors to ads (#1180) 2021-03-22 09:14:02 -07:00
Christopher Suh
0a1ee88a12 Bumped Migration Assessment Version (#1179)
* bump migration assessment nuget

* upgraded migration version
2021-03-19 22:46:51 -07:00
Christopher Suh
0f4767aa6c Added Server Name (#1176)
* added DatabaseName field

* added servername
2021-03-16 18:40:14 -04:00
Christopher Suh
8fb6474cf0 added DatabaseName field (#1166) 2021-02-23 21:32:02 -05:00
Alan Ren
f75be77138 add visualization option support (#1160)
* add visualization option support

* add comments
2021-02-11 15:40:29 -08:00
Charles Gagnon
326488b1f7 Update resx with latest changes (#1159) 2021-02-03 14:34:38 -08:00
Karl Burtram
9fc5dfa647 Add thirdpartynotices.txt file to package (#1152)
* Add thirdpartynotices.txt file to package

* Update Notice.txt file per feedback
2021-01-29 11:46:58 -08:00
khoiph1
eb0b774f39 updated localized files (#1150) 2021-01-21 15:19:17 -08:00
csigs
6d7be6c019 LEGO: check in for main to temporary branch. (#1149) 2021-01-20 21:33:52 -08:00
Leila Lali
01d0f03262 Added service for model management for machine learning extension (#1138)
* Added service for model management for ml extension
2021-01-19 11:33:55 -08:00
Charles Gagnon
822ffb2908 Remove invalid SET option for SqlOnDemand (#1147) 2021-01-11 09:08:50 -08:00
khoiph1
72fa41ca15 new loc files (#1136) 2021-01-06 10:44:36 -08:00
Charles Gagnon
5c7211e82a Include singleline comments outside batch for nb convert (#1139)
* Include singleline comments outside batch for nb convert

* Remove extra space
2020-12-14 15:16:07 -08:00
Alex Ma
fefcab1c04 Added new String Resource Tool to fix issue (#1129) 2020-12-01 11:49:31 -08:00
Benjin Dubishar
0954502033 Renamed file (#1127) 2020-11-25 15:01:15 -08:00
Benjin Dubishar
25c542319e Splitting out default DacFx options for Publish and Schema Compare (#1126)
* Splitting out schema comp and publish defaults

* Added test

* Correcting comments, changing scope

* Moving DeploymentOptions to DacFx folder due to dependency hierarchy between DacFx and SchemaCompare
2020-11-25 14:44:34 -08:00