* Add null checks when converting notebooks to SQL, and SQL to notebooks.
* Remove unnecessary newlines and spaces from multi-line comments.
* Use the current environment's newline characters when converting cell text to a SQL query.
* Add additional unit tests for notebook conversion.
* Decrement NextRowId if reverting addition of a row that is not committed yet.
* added test and message
* added fixed and extensive tests
* added assert messages
* added dotnet version
* remove code coverage arg
* check failing test
* correct arg placement
* try commenting issue test
* add back code coverage
* ignore test instead of commenting it out
* dont need version
* Adding missing Deploy options
* SQL DB Project database genScript/Publish working but tests
* Test cases fixed for the changes for DacFx and SC services
* Refactored the model name and tested the changes with ADS extensions.
* updated DeploymentOptionProperty model and corresponding updates.
* Adding DisplayNames to the deploymentOptionProperty to maintain names in STS for all extensions.
* MapTabe intialization in constructor
* Updated comment with more meaning
* Porperty strong type update with actual type
* Creating model with generic type getting using Activator.CreateInstance
* Rebase to main and resolved merge conflicts
* Xml comments added and code updated
* Deployment options update
* Deployoptions typo and comments updates a
* updated deployment options comments
* removed unnecessary using statement
* code refactor
* Revert "Revert "Adding new Dac Deployment Options and getting descriptions from DacFx API (#1357)" (#1493)"
This reverts commit 2b48331115.
* removing duplicated default empty string value
* Adding missing Deploy options
* SQL DB Project database genScript/Publish working but tests
* Test cases fixed for the changes for DacFx and SC services
* Refactored the model name and tested the changes with ADS extensions.
* updated DeploymentOptionProperty model and corresponding updates.
* Adding DisplayNames to the deploymentOptionProperty to maintain names in STS for all extensions.
* MapTabe intialization in constructor
* Updated comment with more meaning
* Porperty strong type update with actual type
* Creating model with generic type getting using Activator.CreateInstance
* Rebase to main and resolved merge conflicts
* Xml comments added and code updated
* Deployment options update
* Deployoptions typo and comments updates a
* updated deployment options comments
* removed unnecessary using statement
* code refactor
* Removes unnecessary using statement to fix build error
* Stops continuing the release if build.cmd task fails
* Revert "Stops continuing the release if build.cmd task fails"
This reverts commit 64c055cdfa7a5275a9144192e0740d124a92ec9a.
* Enabled backup to and restore from URL
* Created RPC, but when process tries to load Microsoft.Azure.Storage.Blob.dll, it crashes
* Added create shared access token
* Code refactor
* Minor changes
* Changed RPC path
* Moved createSas RPC to the newly created BlobService, fixed PR comments
* Added sas expiration date parameter to the RPC
* Added copyright headers
* Removed ConnectionInstance property from BlobService
* Removed unhelpful comment
* Removed unused using statements
* Changed copy/paste comments
* Disposable objects fix
* Small formatting fix
* Changed backup to/restore from url supported device types
* Added backup to url integration test
* Created restore integration test. Test are now getting azure blob params from env variables instead of file.
* Culture invariant epiration date param, fixed comment, and typo
* Updated headers
* PR comments fix
* Changed supported device type logic
* string localization fix
* String formatting fix
* build failure fix
* Typo
* Updated supported restore device types
* Minimal changes to make headers appear on empty result sets
* Columns for everyone!
* Updating tests - some don't pass yet
* Adding some more tests to verify the changes for column/row selection
* null default columns
* Updates to comments as per PR comments
* Adds new graph comparison request handler to the Execution Plan Service.
* Code review changes
* Renames execution plan compare params, result, and request classes.
* Renames ShowPlan directories along with corresponding namespaces
* Renames ShowPlanGraphUtils to ExecutionPlanGraphUtils
* Revert "Renames ShowPlanGraphUtils to ExecutionPlanGraphUtils"
This reverts commit 5dc2696ae906598447eed7360a3f342218432b83.
* Reverts show plan tests name change.
* Renames show plan test XML files.
* Renames ported directory to ShowPlan and updates namespace accordingly
* Initial check in for SQL migration SKU recommendation feature (#1362)
Co-authored-by: Raymond Truong <ratruong@microsoft.com>
* Integration test for Get SKU Recommendation. (#1377)
* Integration test for Get SKU Recommendation.
* Addressing comments -
1) Moving sample files to data folder.
2) Changed Assert for Positive Justification. Ideally for MI we are expecting ~6 justifications but this might change so sticking with 'recommendation should have atleast one positive justification'.
* Implement start/stop perf data collection (#1369)
* Add SqlInstanceRequirements to SKU recommendation output (#1378)
* test for data collection start and stop (#1395)
* improve error handling, add RefreshPerfDataCollection (#1393)
* WIP - refresh data collection
* Capture messages before logging
* Update Microsoft.SqlServer.Migration.Assessment NuGet version (#1402)
* Update NuGet version to 1.0.20220208.23, update assessment metadata
* Update SKU recommendation metadata
* Include preview SKUs
* Clear message/error queue after refreshing
* Clean up
* Add 'IsCollecting' to RefreshPerfDataCollection (#1405)
Co-authored-by: Neetu Singh <23.neetu@gmail.com>
* Adding recommendations
* Adding raw graph type in execution plan graph contracts
* Fixing function name and concising string formatting
* Converting localized string to a function
* Using better names in contract props
Formatting names in a better way
* Getting rid of unnecessary getter, setters and private props
* Fixing localized strings, comments and imports
* Fixing some contracts
* Fixing csproj formatting
* Fixing var names
* Fixing xml comments
* Parsing nested properties in show plan nodes.
* Creating a base class for ExecutionGraphProp
Adding a simple test to see if the nested props are parsed correctly.
* Fixing doc comment
* simplifying class name
