Commit Graph

60 Commits

Author SHA1 Message Date
Cory Rivera
c29fb03b6e Remove redundant usage of object URNs in database handler (#2245) 2023-09-20 17:17:54 -07:00
Cheena Malhotra
1b886c4380 Azure Active Directory (Azure AD) is becoming Microsoft Entra ID (#2237) 2023-09-12 13:40:35 -07:00
Barbara Valdez
d0b6c0890a Server properties fixes (#2225)
* get the backup compression value directly from server

* get max memory values directly from server and fix conditions

* format document
2023-09-11 12:50:49 -07:00
Sai Avishkar Sreerama
6873b42a6b queryStore WaitStatistics options should be a dropdown #24372 (#2228) 2023-09-11 12:56:31 -05:00
Barbara Valdez
7741202293 get the backup compression value directly from server (#2223) 2023-09-10 23:57:43 -07:00
Sai Avishkar Sreerama
a053457ba1 Enable QueryStore tab to the database properties (#2200)
* initial commit

* adding prototypefile and server conditions

* Saving query store options completed, todo:tests

* adding LOC stings  according to the LOC version of the ms doc

* removing common constants

* merge conflict fix

* fixing null reference exception

* Adjusting the null reference exception property value in prototype.cs

* removing unused directive

* test fix that checks wrong value

* Purge query store data changes

* adding comment and uncommented the line
2023-09-07 16:35:44 -05:00
Barbara Valdez
d1373dce69 Add advanced tab (#2203) 2023-09-01 16:54:02 -07:00
Cory Rivera
ed74cfbc67 Only delete database backup and restore history after the database has been successfully dropped (#2202) 2023-09-01 11:22:17 -07:00
Barbara Valdez
3ba514c652 Add database settings tab (#2201) 2023-08-31 14:25:57 -07:00
Barbara Valdez
5f17826359 Add security tab (#2187) 2023-08-31 09:52:58 -07:00
Cory Rivera
724d533090 Simplify connection cleanup and clear pools to prevent lingering connections (#2199) 2023-08-30 14:38:24 -07:00
Sai Avishkar Sreerama
c73ab55055 Enabling FILEGROUPS tab experience to the Database Properties (#2182)
* sending dsc values to ADS

* modifying dsc method with unsupportable property IsValuedefault

* getting the options and added a bool flag to maintian checkbox for secondary to save

* sending data to ads

* Ready for PR with minimal changes of loading UI as expected, TODO:saving logic

* Excluding maxdop and resumable options from primary value conversion for 1/0's

* Adding Id to the info, as we cannot depend on names, as names can be altered in future

* saving successfully, todo-diff servers, script (secondary - primary compare and dont update),test, send null for unsupported

* adding nullable dsc for unsupported servers

* fixing script generation for some properties that are not touched. the generated script is unharmed but unnecessary here

* adding test conditions for database scoped configurations

* adding switch case method to get the values

* Removing Loc string for the TSQL options

* removing unnecessary using statement

* sending required data, verify autogrowth...

* using fullTextIndexing to open the files tab for sql server and not to other servers

* Adding test case and fixing createDatabase issue

* sending files as objecinfo

* Update src/Microsoft.SqlTools.ServiceLayer/Admin/Database/DatabasePrototype130.cs

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* comment update

* preparing filegroup and filetype options

* sending required all fields

* saving file code changes, need more to work

* Saving file is completed, todo:edit  & remove

* Logic to remove the file

* add,edit,save working

* cleaning merge conflicts accidentally added code

* Adding tests to validates Files by adding, removing, updating files

* adding comments

* all working including tests, except fileStream size question

* code review comments updates

* memoryoptimized filegroups should be part of filestream group

* Initial commit

* failing tests fix

* Modify tests by create database using SqlTestDb

* Modify tests by create database using SqlTestDb

* Update src/Microsoft.SqlTools.ServiceLayer/ObjectManagement/ObjectTypes/Database/DatabaseHandler.cs

Co-authored-by: Cory Rivera <corivera@microsoft.com>

* preparing filegroup data to model

* fixing test

* commenting remove file testing as failing pipeline but passing locally

* saving filegroups

* using enum for type

* trying to fix the test in server, removed the complaining file from test

* all working but saving needs condition for filestream types

* removing fulltext param and test fix

* saving filegroups completed, need tests

* fixing the path..

* adding test for Filegroups

* test fix

* fixing filegroups as filestream is not enabled on test server

* missing conflict resolving

* cleaning unused method

* Code review updates for both filegroups and files logic

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
2023-08-30 14:00:56 -05:00
Sai Avishkar Sreerama
07c8069cfa Enabling Files Tab to the database properties (#2169)
* sending dsc values to ADS

* modifying dsc method with unsupportable property IsValuedefault

* getting the options and added a bool flag to maintian checkbox for secondary to save

* sending data to ads

* Ready for PR with minimal changes of loading UI as expected, TODO:saving logic

* Excluding maxdop and resumable options from primary value conversion for 1/0's

* Adding Id to the info, as we cannot depend on names, as names can be altered in future

* saving successfully, todo-diff servers, script (secondary - primary compare and dont update),test, send null for unsupported

* adding nullable dsc for unsupported servers

* fixing script generation for some properties that are not touched. the generated script is unharmed but unnecessary here

* adding test conditions for database scoped configurations

* adding switch case method to get the values

* Removing Loc string for the TSQL options

* removing unnecessary using statement

* sending required data, verify autogrowth...

* using fullTextIndexing to open the files tab for sql server and not to other servers

* Adding test case and fixing createDatabase issue

* sending files as objecinfo

* Update src/Microsoft.SqlTools.ServiceLayer/Admin/Database/DatabasePrototype130.cs

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* comment update

* preparing filegroup and filetype options

* sending required all fields

* saving file code changes, need more to work

* Saving file is completed, todo:edit  & remove

* Logic to remove the file

* add,edit,save working

* cleaning merge conflicts accidentally added code

* Adding tests to validates Files by adding, removing, updating files

* adding comments

* all working including tests, except fileStream size question

* code review comments updates

* memoryoptimized filegroups should be part of filestream group

* failing tests fix

* Modify tests by create database using SqlTestDb

* Update src/Microsoft.SqlTools.ServiceLayer/ObjectManagement/ObjectTypes/Database/DatabaseHandler.cs

Co-authored-by: Cory Rivera <corivera@microsoft.com>

* fixing test

* commenting remove file testing as failing pipeline but passing locally

* using enum for type

* trying to fix the test in server, removed the complaining file from test

* removing fulltext param and test fix

* fixing the path..

* test fix

* missing conflict resolving

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
2023-08-29 11:24:31 -05:00
Cory Rivera
52773bc26d Add Attach Database functionality to Object Management Service (#2193) 2023-08-28 12:24:02 -07:00
Barbara Valdez
58923bc75e Enable Script option for Server Properties (#2184) 2023-08-22 18:47:45 -07:00
Cory Rivera
6497f5d72d Fix typo in ExecutionHandler class name (#2185) 2023-08-22 16:43:35 -07:00
Barbara Valdez
16c7e32356 Add processors tab (#2166) 2023-08-21 13:24:48 -07:00
Aasim Khan
73c2a75fba Creating a new Sql Core project that stores OE classes. (#2165)
* init

* More fixes

* moving filters from contracts to core OE classes

* Fixing some tests

* More fixes and added doc comments

* Fixing tests

* Quick refactoring

* more cleanups

* cleanup

* Adding stateless OE

* Adding null checks

* Making group by schema independent of settings

* Fixing tests

* Removing node info from core oe code

* Fixing tests and moving OE code to its own project

* moving oe to own project

* Removing changes to Kusto

* Removing azure access token from service layer

* Fixing project description and title

* Fixing file name typo

* Removing unused  strings from service layer

* Fixing localized strings in tests
Adding comments to stateless OE

* Fixing stuff

* Update src/Microsoft.SqlTools.SqlCore/Microsoft.SqlTools.SqlCore.csproj

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Fixing project nesting

* Fixing more stuff and removing OE class

* Cleanup

* Code cleanup

* fixing oe service provider

* Fixing test name

* Remove using

* Update src/Microsoft.SqlTools.SqlCore/ObjectExplorer/SmoModel/SmoQueryContext.cs

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Fixing syntax error

* Adding project to locproject

* Fixing stuff

* Fixing errors

* sorting usings

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-08-16 22:11:35 -07:00
Sai Avishkar Sreerama
e4db70fb39 Enabling Database scoped configurations tab to DB Properties (#2147)
* sending dsc values to ADS

* modifying dsc method with unsupportable property IsValuedefault

* getting the options and added a bool flag to maintian checkbox for secondary to save

* sending data to ads

* Ready for PR with minimal changes of loading UI as expected, TODO:saving logic

* Excluding maxdop and resumable options from primary value conversion for 1/0's

* Adding Id to the info, as we cannot depend on names, as names can be altered in future

* saving successfully, todo-diff servers, script (secondary - primary compare and dont update),test, send null for unsupported

* adding nullable dsc for unsupported servers

* fixing script generation for some properties that are not touched. the generated script is unharmed but unnecessary here

* adding test conditions for database scoped configurations

* adding switch case method to get the values

* Removing Loc string for the TSQL options

* removing unnecessary using statement

* Adding test case and fixing createDatabase issue

* Update src/Microsoft.SqlTools.ServiceLayer/Admin/Database/DatabasePrototype130.cs

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* comment update

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-08-15 11:58:35 -05:00
Cory Rivera
7c0da6b6b1 Add extra delete database functionality to DatabaseHandler (#2168)
* Also fixed connections not being properly closed in Detach operations
* Fixed errors being thrown in InitializeObjectView because certain db property fields are not supported against Azure
2023-08-11 13:06:35 -07:00
Cory Rivera
46fa477717 Provide default indexes for database option values instead of reordering options lists (#2156)
* Also re-add <default> to owners list for new database dialog
2023-07-27 16:11:49 -07:00
Sai Avishkar Sreerama
1d05cdb131 Fix for Database prototype file is not log file error, as this code is for create database (#2144) 2023-07-12 22:19:04 -05:00
Sai Avishkar Sreerama
ddea088a18 Removing Ledger saving logic (#2142) 2023-07-12 15:22:54 -05:00
Cory Rivera
88ec8713d0 Only set Restrict Access if a non-null value is provided (#2140) 2023-07-11 17:11:58 -07:00
Barbara Valdez
e14828e0d4 Send min and max values for server properties (#2130) 2023-07-07 13:03:25 -07:00
Cheena Malhotra
03a99e48dc Close connection explicitly on rename (#2129) 2023-07-06 22:19:17 -07:00
Barbara Valdez
4c4d6584b3 Update memory settings and implement ServerPrototype (#2126) 2023-07-06 17:25:45 -07:00
Sai Avishkar Sreerama
11f632aaa9 Sai/db properties options tab (#2121)
* Sending values to ADS, including the arrays, need refactor and tests

* adjusting dd options as per ssms

* sending back the updated options properties to smo

* saving changes

* pulling correct database name changes

* Refactoring

* saving is working fine

* Added genral tab section options for the option tab

* modifying userAccess and pageVerify props types

* fix for database name being master for always for existing database

* Managed Instance save error fixed

* added new assertions to the test case

* server engine edition conditions handling from ADS side

* Adding unsupported options approach to the properties, so that these nullable options can be excluded from UI

* modifying the props name

* modified empty string to null

* Test case update
2023-07-06 13:48:11 -04:00
Barbara Valdez
c2d53a3215 Get server general properties (#2117)
* add server handler

* get server general properties
2023-06-28 16:39:37 -07:00
Charles Gagnon
9034b397ac Error on CS8600 (#2112)
* Error on CS8600

* couple more
2023-06-26 08:52:51 -07:00
Cory Rivera
9d0d4b0cae Enable Detach Database in database handler (#2110) 2023-06-22 17:28:41 -07:00
Sai Avishkar Sreerama
5c7dae40e6 Enabling database properties general tab with real time values from SMO (#2093)
* initial commit with all required db handler and props, also getting the data from ADS

* database properties view updated

* Delete Microsoft.SqlTools.ServiceLayer.sln

This file should be ignored

* Removed unwanted file

* Using DatabaseHandler for properties as one handler per object

* removed unused and unnecessary changes

* minimal updates

* moving type conversion to UI side, properties with original types.

* conversion number fixed

* Adding Localized strings

* using existing objectUrn logic to get the smo object

* Adding Integration tests for database properties verification

* refactoring

* updating test
2023-06-21 19:41:18 -05:00
Hai Cao
c21fde884f filter out db roles for user in sql db master (#2101) 2023-06-13 17:08:30 -07:00
Cory Rivera
808172bc20 Retrieve Azure SLO details in Database Handler (#2094) 2023-06-12 11:44:17 -07:00
Cory Rivera
0ad169781e Replace <default> values in Owner and Collation fields for Create Database dialog (#2086) 2023-06-02 16:19:00 -07:00
Hai Cao
37469dcbbd Fix schema level search and refactor search code for user management (#2084) 2023-06-02 10:59:32 -07:00
Cory Rivera
0a5a7b4cc5 Address remaining comments for Object Management Database Handler (#2081) 2023-06-01 11:02:59 -07:00
Cory Rivera
d5cfc52ca7 Add object management handler for creating a database (#2071) 2023-05-31 12:55:12 -07:00
Hai Cao
eff103efba use singular form for securable display name (#2077) 2023-05-30 15:50:22 -07:00
Hai Cao
cb6dfeb68d Fix db role member (#2068) 2023-05-16 09:21:37 -07:00
Hai Cao
24a323b37d Fix effective permission column field (#2061)
* fix effective permission

* Revert "fix effective permission"

This reverts commit 5a97f108c640c7c2bfd22fe21852e880115ee7c9.

* remove column info for may
2023-05-12 14:38:16 -07:00
Hai Cao
0e7ed07a30 Fix schema handling in search result of User Management (#2057)
* fix schema filed in search result

* fix search for securable
2023-05-11 19:08:06 -07:00
Hai Cao
f655c6d660 Fix a few securable search/permission issue related to Azure (#2056) 2023-05-11 13:15:08 -07:00
Hai Cao
d525e88672 Add securable search and permission setting to User Management (#2052) 2023-05-10 18:20:06 -07:00
Cory Rivera
ddb3ec2bdb Add DatabaseHandler to enable Delete Database operations (#2041) 2023-05-04 15:39:50 -07:00
Karl Burtram
5954bdc65c Query logins on system database for Azure connections (#2038)
* Query logins on system database for Azure connections

* Fix name of connection variable
2023-05-02 12:46:18 -07:00
Hai Cao
8d48ff735b Remove extra connection in app role and db role (#2037) 2023-05-01 18:04:07 -07:00
Alan Ren
5dbed25c40 change user type implementation (#2036)
* change user type implementation

* fix build errors
2023-05-01 10:27:00 -07:00
Cheena Malhotra
f66a203c01 Fix application names to respect connection's appname property (#2034) 2023-04-28 13:39:33 -07:00
Hai Cao
35aa8d42de [User Management] Implement handlers for app role, db role and server role (#2030)
* contracts

* more contracts

* wire up

* add server role and rename data classes

* finish app role

* finish db role

* build

* finish server role

* register

* docs and dispose

* build

* fix issues

* fix null ref issue

* fix schema not being set issue

* fix password for app role

---------

Co-authored-by: Alan Ren <alanren@microsoft.com>
2023-04-28 07:56:15 -07:00