Commit Graph

710 Commits

Author SHA1 Message Date
Raymond Truong
004a0b2178 [SQL Migration] SKU recommendation fixes + improvements (#1602)
* Fix null logger resulting in undefined error being surfaced to user

* WIP - implement elastic recommendation model

* WIP - implement elastic recommendation model

* Clean up

* Remove unnecessary content files after updating NuGet version

* Refactor

* Clean up
2022-08-16 09:49:12 -07:00
Jordan Hays
007e852f1a Add modifiable sort priority to OE nodes (#1627)
* modifiable sort priority, dropped ledger folders sorted to the bottom

* reorganizing dropped table and view objects in OE integration test

* update to Int32
2022-08-11 10:46:14 -07:00
Jordan Hays
87ea866df0 Dropped Ledger Views folder (#1626)
* adding dropped ledger views to the OE hierarchy with ledger view naming and icons

* updating tests
2022-08-10 14:01:28 -07:00
Jordan Hays
485786f49e Dropped Ledger Tables Folder (#1625)
* support and testing for Dropped Ledger Table folder

* appending DroppedLedgerTables nodetype

* fixing unit tests

* undoing string.Empty
2022-08-09 14:17:51 -07:00
Raymond Truong
091f2c942e [SQL Migration] Update assessment NuGet version, removing the need to check in content files into STS (#1617)
* Update NuGet version and remove metadata

* Remove Content Include from csproj

* Remove unnecessary PrivateAssets tag

* Use official NuGet build

* Remove reference in IntegrationTests
2022-08-08 11:17:38 -07:00
Sai Avishkar Sreerama
1342a8a085 Object Types are getting from DacFx ObjectTypes (#1574)
* Include Object Types are getting from DacFx

* All tests are passing now with excludObjectType casting

* Test fix with new ExccvludeObjectType change

* Added test case for the include objects types

* Updated  name to objectTypesDictionary and objectType getName from Display attribute

* code Review updates

* Removing Exclude word logic here as the options were updated on DacFx

* updating the null check

* DacFx vBump

* code updates according to review comments
2022-08-05 15:28:39 -05:00
Jordan Hays
d78ff94b31 Ledger Objects Representation in Object Explorer (#1615)
* support for ledger objects in OE

* generated sr files

* update versionKey to sql 2022 in test env config

* more 2019 to 2022 updates

* add sql2022 instead of replacing

* missed filter on table

* add logging

* more logging

* adding Script160Compat options for sql2022

Co-authored-by: Alan Ren <alanren@microsoft.com>
2022-08-05 10:53:17 -07:00
Barbara Valdez
dc3deecbad Improvements to GenerateTSqlModel request and tests (#1611) 2022-08-01 13:50:13 -07:00
Charles Gagnon
fd00114a0e Catch Request/Event handler errors at dispatcher level (#1610)
* Catch Request/Event handler errors at dispatcher level

* Fix tests

* Use Exception overload of SendError

* Fix tests
2022-07-29 17:31:36 -07:00
Jordan Hays
3294a52ad9 Or Filtering on Object Explorer Nodes (#1608)
support for a more robust filtering system in the Object Explorer xml, allowing for or-ing filter properties together for use in URN querying for objects

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2022-07-29 15:35:37 -07:00
Barbara Valdez
11dd29d8a0 Add create model request (#1603)
* add create model request
2022-07-29 12:04:16 -07:00
Vladimir Chernov
2ae0d99900 SqlAssessment update to 1.1.9 (#1593)
* Sql Assessment version update to 1.1.9

* Unit test fix

* integration test fix
2022-07-19 15:19:39 -07:00
Charles Gagnon
70f7b16129 Test cleanup (#1588)
* Test cleanup

* fix compile

* Fix tests
2022-07-19 09:59:28 -07:00
Charles Gagnon
15689b3c7c Add 2019 and 2022 to SqlServerType enum (#1583)
* Add 2019 and 2022 to SqlServerType enum

* Add note

* Add tests

* Fix template generation
2022-07-18 16:35:17 -07:00
Charles Gagnon
82118f6431 Add code coverage reporting (#1585)
* Add code coverage

* fix and add publishTestResults

* Use PublishTestResults

* Add coverlet.msbuild

* Generate report

* Update coverage report location

* Add one more
2022-07-18 15:31:47 -07:00
Cory Rivera
c3b5831c89 Add dotnet tool build steps to SQL Tools & Kusto csproj files. (#1573) 2022-07-12 16:18:11 -07:00
Sai Avishkar Sreerama
5663ddba68 OptionsMapTable preparing from DacFx description,value,displayname at… (#1550)
* OptionsMapTable preparing from DacFx description,value,displayname attributes

* Review Comments addressed for options map table changes

* OptionsMapTable final changes

* Code review comments updated code changes

* Test fix: Adding missing change while splitting the PR

* DacFx vBump

* Reverted to displayName and code updates

* final:prop name changed, references updated, tests fixed, comments addressed

* Code review comments updated for name,exception etc

* updates method names

* property name changes to BooleanOptionsDictionary and comment updates

* Removed the unused properties, null cases handeled, hardcoded values are replaced
2022-07-07 16:56:16 -05:00
Cory Rivera
671310880b Clean up notebook export code (#1565)
* Add null checks when converting notebooks to SQL, and SQL to notebooks.

* Remove unnecessary newlines and spaces from multi-line comments.

* Use the current environment's newline characters when converting cell text to a SQL query.

* Add additional unit tests for notebook conversion.
2022-07-01 15:28:05 -07:00
Alex Ma
deae354f31 Fix for rowId not decrementing if reverting an create row (#1560)
* Decrement NextRowId if reverting addition of a row that is not committed yet.

* added test and message

* added fixed and extensive tests

* added assert messages
2022-06-27 14:47:46 -07:00
Lewis Sanchez
b24202a762 Updating Newtonsoft package to version 13.0.1 (#1559)
* Forcing newtonsoft to version 13.0.1

* Updates addin Newtonsoft.Json package version to 13.0.1

* Update Newtonsoft.Json package version to 13.0.1
2022-06-27 11:01:49 -07:00
Charles Gagnon
dd11be3d38 Consolidate to net6.0 (#1547)
* Add SqlClient event listener

* comments

* ensure not disposed early

* initial

* net6.0

* undo
2022-06-21 08:53:23 -07:00
Hai Cao
e190581094 Disable failing integration test (#1540) 2022-06-15 15:46:48 -07:00
Alan Ren
17b6073c87 include additional data for error object (#1539)
* include additional data for error

* fix tests
2022-06-10 20:40:22 -07:00
Alex Ma
5e3d24bbfa Remove code coverage from STS (#1537)
* WIP removal of code coverage

* more coverage removed

* more fixes

* fix tests
2022-06-10 13:53:43 -07:00
Charles Gagnon
294873613a Add Operations to GetAzureFunctions request (#1527)
* Add Operations to GetAzureFunctions request

* add comment

* comments
2022-06-06 12:59:59 -07:00
Aditya Bist
78a3f748c9 Fix integration tests (#1528)
* added dotnet version

* remove code coverage arg

* check failing test

* correct arg placement

* try commenting issue test

* add back code coverage

* ignore test instead of commenting it out

* dont need version
2022-06-03 10:42:28 -07:00
Sai Avishkar Sreerama
989137ddb7 DacFx default options test validation fixes (#1509) 2022-05-31 14:03:44 -05:00
Charles Gagnon
076ed9644b Add route to GetAzureFunctions request + cleanup (#1521)
* Add route to GetAzureFunctions request + cleanup

* update comments

* comments

* Add comment
2022-05-31 10:22:20 -07:00
Karl Burtram
5fdad0edc8 Add connection retry logic to integration tests (#1523)
* Add retry to live connection

* Disable migration test

* Tune the retry logic

* Disable SQLCMD test
2022-05-27 15:31:33 -07:00
Karl Burtram
e86b0bc87f Fix some integration tests (#1516)
* Fix integration test cases

* More test fixes

* Dacfx test fix

* Make master default test db is none specified
2022-05-26 13:08:53 -07:00
Sai Avishkar Sreerama
62d3cdc99a Revert "Revert "Adding new Dac Deployment Options and getting descriptions fr…" (#1507)
* Adding missing Deploy options

* SQL DB Project database genScript/Publish working but tests

* Test cases fixed for the changes for DacFx and SC services

* Refactored the model name and tested the changes with ADS extensions.

* updated DeploymentOptionProperty model and corresponding updates.

* Adding DisplayNames to the deploymentOptionProperty to maintain names in STS for all extensions.

* MapTabe intialization in constructor

* Updated comment with more meaning

* Porperty strong type update with actual type

* Creating model with generic type getting using Activator.CreateInstance

* Rebase to main and resolved merge conflicts

* Xml comments added and code updated

* Deployment options update

* Deployoptions typo and comments updates a

* updated deployment options comments

* removed unnecessary using statement

* code refactor

* Revert "Revert "Adding new Dac Deployment Options and getting descriptions from DacFx API (#1357)" (#1493)"

This reverts commit 2b48331115.

* removing duplicated default empty string value
2022-05-23 16:19:15 -05:00
Charles Gagnon
7787a6af7b Fix Backup/Restore parameters defaulting to wrong DeviceType (#1490) 2022-05-12 13:34:49 -07:00
Udeesha Gautam
2b48331115 Revert "Adding new Dac Deployment Options and getting descriptions from DacFx API (#1357)" (#1493)
This reverts commit a3a66137b8.
2022-05-12 13:30:04 -07:00
Charles Gagnon
3af029315b Fix bindings tests (#1488) 2022-05-10 11:09:45 -07:00
Sai Avishkar Sreerama
a3a66137b8 Adding new Dac Deployment Options and getting descriptions from DacFx API (#1357)
* Adding missing Deploy options

* SQL DB Project database genScript/Publish working but tests

* Test cases fixed for the changes for DacFx and SC services

* Refactored the model name and tested the changes with ADS extensions.

* updated DeploymentOptionProperty model and corresponding updates.

* Adding DisplayNames to the deploymentOptionProperty to maintain names in STS for all extensions.

* MapTabe intialization in constructor

* Updated comment with more meaning

* Porperty strong type update with actual type

* Creating model with generic type getting using Activator.CreateInstance

* Rebase to main and resolved merge conflicts

* Xml comments added and code updated

* Deployment options update

* Deployoptions typo and comments updates a

* updated deployment options comments

* removed unnecessary using statement

* code refactor
2022-05-10 22:59:26 +05:30
Charles Gagnon
70be8f5ef5 Don't add parentheses to ANSI Scalar functions (#1487)
* Don't add parentheses to ANSI Scalar functions

* fix test
2022-05-09 18:57:14 -07:00
Charles Gagnon
2540068998 Fix VerifyAllSqlObjects test (#1485)
* Fix VerifyAllSqlObjects test

* comment
2022-05-06 23:13:11 -07:00
Hai Cao
24910c5b5c [Table Designer] api change for insert and move col (#1477)
* make api change for insert and move col
* bump DacFx
2022-05-06 15:00:34 -07:00
Lewis Sanchez
224c5c742c Removes unnecessary using statement to fix build error (#1479)
* Removes unnecessary using statement to fix build error

* Stops continuing the release if build.cmd task fails

* Revert "Stops continuing the release if build.cmd task fails"

This reverts commit 64c055cdfa7a5275a9144192e0740d124a92ec9a.
2022-04-26 17:22:15 -07:00
Nemanja Milovančević
881c335cdf Backup/Restore Managed Instance (#1428)
* Enabled backup to and restore from URL

* Created RPC, but when process tries to load Microsoft.Azure.Storage.Blob.dll, it crashes

* Added create shared access token

* Code refactor

* Minor changes

* Changed RPC path

* Moved createSas RPC to the newly created BlobService, fixed PR comments

* Added sas expiration date parameter to the RPC

* Added copyright headers

* Removed ConnectionInstance property from BlobService

* Removed unhelpful comment

* Removed unused using statements

* Changed copy/paste comments

* Disposable objects fix

* Small formatting fix

* Changed backup to/restore from url supported device types

* Added backup to url integration test

* Created restore integration test. Test are now getting azure blob params from env variables instead of file.

* Culture invariant epiration date param, fixed comment, and typo

* Updated headers

* PR comments fix

* Changed supported device type logic

* string localization fix

* String formatting fix

* build failure fix

* Typo

* Updated supported restore device types
2022-04-20 14:01:13 -07:00
dependabot[bot]
7f7e87b5cf Bump minimist from 1.2.5 to 1.2.6 in /test/CodeCoverage (#1464)
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-12 21:51:47 -07:00
Aasim Khan
1ce3647565 Making star expansion test cross plat (#1455)
* Making star expansion cross plat

* Fixing test

* Fixing next  line
2022-04-08 15:20:07 -07:00
Aasim Khan
cc63d866d7 Fixing integration tests for sts (#1453)
* Fixing test pipeline

* pwd

* fixing script

* fixing cwd

* switch to bash

* Cleaning up script and yml

* Fixing script comment

* Fixing the comments

* Adding issue in the comment

* Adding automatic password generator

* Removing unncesary use statement

* Fixing key

* Printing var

* Printing settings

* Printing var

* Fixed var

* Fixed

* Reverting some changes

* Changing fetch variable to upper case

* Fixing password logic

* Debug

* debug2

* debug

* Making passwords secret

* Fixing string null check

* removed dirs

* fixing var name

* Fixing var

* Printing  vars to see if the enviornment is setup correctly

* Printing versionkey

* removing prints

* Adding 2019 Instance key and updating template

* fixing env variable

* Fixing comment
2022-04-08 15:19:49 -07:00
Alan Ren
3452c43a51 handle hierarchyid correctly (#1450) 2022-03-31 15:18:15 -07:00
Benjamin Russell
2ace786d95 Export headers in an empty result set (#1434)
* Minimal changes to make headers appear on empty result sets

* Columns for everyone!

* Updating tests - some don't pass yet

* Adding some more tests to verify the changes for column/row selection

* null default columns

* Updates to comments as per PR comments
2022-03-31 09:10:32 -07:00
Lewis Sanchez
8215d88dcf Adds new graph comparison request handler to the Execution Plan Service. (#1438)
* Adds new graph comparison request handler to the Execution Plan Service.

* Code review changes

* Renames execution plan compare params, result, and request classes.
2022-03-22 14:52:42 -07:00
Lewis Sanchez
f7b37091ca Renames ShowPlan directories along with corresponding namespaces (#1435)
* Renames ShowPlan directories along with corresponding namespaces

* Renames ShowPlanGraphUtils to ExecutionPlanGraphUtils

* Revert "Renames ShowPlanGraphUtils to ExecutionPlanGraphUtils"

This reverts commit 5dc2696ae906598447eed7360a3f342218432b83.

* Reverts show plan tests name change.

* Renames show plan test XML files.

* Renames ported directory to ShowPlan and updates namespace accordingly
2022-03-21 16:25:44 -07:00
Alan Ren
b495ea7475 handle UDT type (#1424) 2022-03-11 18:10:08 -08:00
Charles Gagnon
40c5d48c5e Fail build on unneeded usings (#1417) 2022-03-04 16:38:01 -08:00
Charles Gagnon
c248400a6c Add linting for copyright and unused usings (#1416)
* Add linting for copyright and unused usings

* Add one more + comment

* Enforce in build and fix errors

* Fix build
2022-03-04 15:17:29 -08:00