Commit Graph

63 Commits

Author SHA1 Message Date
Alex Ma
4ae9534ac8 Added retry policy for sleeping serverless error for SqlConnections (#2155) 2023-08-16 13:17:40 -07:00
Charles Gagnon
9034b397ac Error on CS8600 (#2112)
* Error on CS8600

* couple more
2023-06-26 08:52:51 -07:00
Cheena Malhotra
648d7dbd3c Address warnings and (some) nullables (#2013) 2023-04-18 20:57:13 -07:00
Cheena Malhotra
74dd15c868 Address error IDE0270 after MsBuild update (#1865) 2023-02-16 16:15:30 -08:00
Karl Burtram
f288bee294 Make nullable warnings a per file opt-in (#1842)
* Make nullable warnings a per file opt-in

* Remove unneeded compiler directives

* Remove compiler directive for User Data
2023-02-03 18:10:07 -08:00
Hai Cao
f86ebae9b8 Re-enable parallel message processing (#1741)
* add flag to handler

* cleanup

* concurrency control

* add flag for handler setters

* update service flags

* fix event handlers

* more handlers

* make sure behavior is unchanged if flag is off

* cleanup

* add test case for parallel processing

* comments

* stop dispatcher in test

* add log for request lifespan

* cleanup and add comments

* correctly release semaphore

* remove deleted file from merge

* use await for semaphore release

* move handler invocation to await and adjust test

* cleanup exception handling and wrapper

* space

* loose assertion condition to make test stable
2022-12-11 00:05:33 -08:00
Alan Ren
26945bed8d fix notebook job not working issue (#1758) 2022-11-09 20:31:02 -08:00
Cheena Malhotra
006ac60923 Upgrade solution to .NET 6.0.9 (Build with .NET SDK v6.0.401) (#1692) 2022-09-16 11:27:52 -07:00
Karl Burtram
3885c8f680 Revert async dispatcher change 08c74be (#1655)
* Revert 08c74be51f async message handling

* Fix merge error in SetEventHandler
2022-08-29 10:44:26 -07:00
Charles Gagnon
fd00114a0e Catch Request/Event handler errors at dispatcher level (#1610)
* Catch Request/Event handler errors at dispatcher level

* Fix tests

* Use Exception overload of SendError

* Fix tests
2022-07-29 17:31:36 -07:00
Alan Ren
08c74be51f make the message processing truely async (#1596) 2022-07-21 16:58:03 -07:00
Benjamin Russell
97a106c575 Removing a lot of redundant async/await wrappers (#1486)
* Removing a lot of redundant async/await wrappers

* Removing kusto changes
2022-06-05 08:26:21 -07:00
Charles Gagnon
a4ef58212b Fix Agent actions for docker servers (#1489) 2022-05-10 11:09:57 -07:00
Charles Gagnon
40c5d48c5e Fail build on unneeded usings (#1417) 2022-03-04 16:38:01 -08:00
Justin M
0c95a511d0 Fixed Azure Pipeline build warnings (#1254)
* Fixed Azure Pipeline build warnings

* Removed variable declaration in SmoScriptableOperationWithFullDbAccess catch block.
2021-10-04 13:30:43 -07:00
Aasim Khan
10c24aaeb3 Fixing a notebook history bug in SQL Agent (#1199)
* Added a leading 0 to notebook history runtimes

* Fixing comment

* Fix for getting run date and time for notebook jobs in a proper format - Try2

* Reverting back to previous query
2021-04-28 16:52:24 -07:00
abist
9ea076e51d fix correct run status for steps 2020-03-06 14:15:36 -08:00
Aditya Bist
7c5b7541cd fix message for agent jobs (#922) 2020-02-25 11:42:53 -08:00
Karl Burtram
427f0c11e8 Bump SMO and SqlClient to pickup Microsoft.Data.SqlClient fixes (#894)
* Revert "Revert to SMO with older SQLClient driver (#889)"

This reverts commit b763abae47.

* Bump SMO and SqlClient
2019-11-22 17:17:21 -08:00
Karl Burtram
b763abae47 Revert to SMO with older SQLClient driver (#889)
* Revert "Update SMO (#875)"

This reverts commit 96593d66e3.

* Revert "Switch Tools Service to new SMO and Microsoft.Data.SqlClient driver (#865)"

This reverts commit 9d140b53f3.

* Bump SMO to 160.1910315.0-preview
2019-11-04 13:00:45 -08:00
David Shiflet
9d140b53f3 Switch Tools Service to new SMO and Microsoft.Data.SqlClient driver (#865)
* switch to ambient props and targets files

* build against Microsoft.Data.SqlClient

* build tests

* fix test bug

* temporarily add SMO nuget to the repo

* update to released Microsoft.Data package
2019-09-17 17:51:19 -04:00
Aasim Khan
c6631cf67c Feat/notebookendpoints (#862)
* Added endpoint for fetching all notebook jobs

* Refractored NotebookJobInfo to AgentNotebookInfo to make it more consistent with the rest of the codebase

* Added Notebook History endpoint in contracts.

* Added Create, Update, Delete notebook endpoints. Also added separate fetch template, materialized notebook endpoints. This will make the Notebook Request and Notebook History responses lighter.

* AgentNotebookInfo is now derived from AgentJobInfo

* added fetch noteook history endpoint

* Added fetching materialized notebook endpoint

* Added code for cleaning up the directory

* Added create notebook api

* Added Update and delete notebook job

* Fixed notebook history API

* Added last run info to the script and template folder

* Added execute database feature for notebook Jobs

* SQL commands are now using sqlparameters to prevent
any injection attacks

* Changed rundate and runtime to string to preserve
leading zeros

* integration test for agentnotebooks api

* Made some changes mentioned in PR

* Refactored the code, removed enpoint logic from the notebook handler and
wrote test cases

* changes select statements, fixed a bug in the test job cleanup
and fixed other stuff mentioned in the PR.

* added notebook_error column in notebook history select statement

* Added get template notebook endpoint

* Added renaming and pinning notebook runs

* made tables names caps to handle servers with case sensitive queries

* made some changes to the enpoint points paths

* Added delete materialized notebooks endpoints

* Fixed a bug in delete, rename and pin apis where
requests from multiple clients with materializedID = 0
could have resulted in multiple rows getting created
on notebooks.nb_materialized table.

* fixed a merge conflict

* Made some changes mentioned in the PR

* modified a query to handle space sensitive databases

* Made some changes mentioned in the PR

* fixed a small query bug
2019-09-06 16:54:37 -07:00
Aasim Khan
8a12802fb9 Added delete materialized run endpoints (#858)
* Added endpoint for fetching all notebook jobs

* Refractored NotebookJobInfo to AgentNotebookInfo to make it more consistent with the rest of the codebase

* Added Notebook History endpoint in contracts.

* Added Create, Update, Delete notebook endpoints. Also added separate fetch template, materialized notebook endpoints. This will make the Notebook Request and Notebook History responses lighter.

* AgentNotebookInfo is now derived from AgentJobInfo

* added fetch noteook history endpoint

* Added fetching materialized notebook endpoint

* Added code for cleaning up the directory

* Added create notebook api

* Added Update and delete notebook job

* Fixed notebook history API

* Added last run info to the script and template folder

* Added execute database feature for notebook Jobs

* SQL commands are now using sqlparameters to prevent
any injection attacks

* Changed rundate and runtime to string to preserve
leading zeros

* integration test for agentnotebooks api

* Made some changes mentioned in PR

* Refactored the code, removed enpoint logic from the notebook handler and
wrote test cases

* changes select statements, fixed a bug in the test job cleanup
and fixed other stuff mentioned in the PR.

* added notebook_error column in notebook history select statement

* Added get template notebook endpoint

* Added renaming and pinning notebook runs

* made tables names caps to handle servers with case sensitive queries

* made some changes to the enpoint points paths

* Added delete materialized notebooks endpoints

* Fixed a bug in delete, rename and pin apis where
requests from multiple clients with materializedID = 0
could have resulted in multiple rows getting created
on notebooks.nb_materialized table.

* fixed a merge conflict

* Made some changes mentioned in the PR
2019-09-04 10:34:28 -07:00
Aasim Khan
55c82fbcc4 Added renaming and pinning agent notebook runs (#855)
* Added endpoint for fetching all notebook jobs

* Refractored NotebookJobInfo to AgentNotebookInfo to make it more consistent with the rest of the codebase

* Added Notebook History endpoint in contracts.

* Added Create, Update, Delete notebook endpoints. Also added separate fetch template, materialized notebook endpoints. This will make the Notebook Request and Notebook History responses lighter.

* AgentNotebookInfo is now derived from AgentJobInfo

* added fetch noteook history endpoint

* Added fetching materialized notebook endpoint

* Added code for cleaning up the directory

* Added create notebook api

* Added Update and delete notebook job

* Fixed notebook history API

* Added last run info to the script and template folder

* Added execute database feature for notebook Jobs

* SQL commands are now using sqlparameters to prevent
any injection attacks

* Changed rundate and runtime to string to preserve
leading zeros

* integration test for agentnotebooks api

* Made some changes mentioned in PR

* Refactored the code, removed enpoint logic from the notebook handler and
wrote test cases

* changes select statements, fixed a bug in the test job cleanup
and fixed other stuff mentioned in the PR.

* added notebook_error column in notebook history select statement

* Added get template notebook endpoint

* Added renaming and pinning notebook runs

* made tables names caps to handle servers with case sensitive queries

* made some changes to the enpointpoint paths
2019-08-28 18:21:33 -07:00
Aasim Khan
487235b1e9 Added endpoint for fetching all notebook jobs (#834)
* Added endpoint for fetching all notebook jobs

* Refractored NotebookJobInfo to AgentNotebookInfo to make it more consistent with the rest of the codebase

* Added Notebook History endpoint in contracts.

* Added Create, Update, Delete notebook endpoints. Also added separate fetch template, materialized notebook endpoints. This will make the Notebook Request and Notebook History responses lighter.

* AgentNotebookInfo is now derived from AgentJobInfo

* added fetch noteook history endpoint

* Added fetching materialized notebook endpoint

* Added code for cleaning up the directory

* Added create notebook api

* Added Update and delete notebook job

* Fixed notebook history API

* Added last run info to the script and template folder

* Added execute database feature for notebook Jobs

* SQL commands are now using sqlparameters to prevent
any injection attacks

* Changed rundate and runtime to string to preserve
leading zeros

* integration test for agentnotebooks api

* Made some changes mentioned in PR

* Refactored the code, removed enpoint logic from the notebook handler and
wrote test cases

* changes select statements, fixed a bug in the test job cleanup
and fixed other stuff mentioned in the PR.

* added notebook_error column in notebook history select statement

* Added get template notebook endpoint
2019-08-22 12:37:19 -07:00
Aditya Bist
fc50913f14 chagned strings to enums and can edit step completion actions (#827) 2019-06-20 00:30:37 -07:00
Aditya Bist
5583cc182f get more info for proxies (#815) 2019-05-21 11:49:14 -07:00
Karl Burtram
151a2de625 Query execution settings support (#812)
* WIP

* WIP 3

* WIP 3

* Additional query settings updates

* Add settings tets

* Address code review feeback

* Updates from testing
2019-05-16 15:21:17 -07:00
Aditya Bist
c0ec9272b3 match agent behavior to ssms (#781) 2019-03-29 13:39:42 -07:00
Aditya Bist
9158d86e66 Agent - edit owner changes (#791)
* dont send logins any more

* removed mistakenly added script
2019-03-29 13:38:57 -07:00
Aditya Bist
a08e4058a2 Agent/improvements (#779)
* job step type and error message details change

* added newline for both environments

* checked for inner exceptions

* sorted imports

* added ability to change job owner
2019-03-21 11:31:15 -07:00
Aditya Bist
a08666af0f Added more options to job changes and elaborated error messages (#775)
* job step type and error message details change

* added newline for both environments

* checked for inner exceptions

* sorted imports
2019-03-07 11:42:20 -08:00
Aditya Bist
046563318a added ability to start at step (#758) 2018-12-06 17:34:48 -08:00
Aditya Bist
2f1097028f Fixed update agent step (#748)
* fixed update step

* fix new step from edit job

* allowed to reorder steps in edit job
2018-11-29 10:47:57 -08:00
Matt Irvine
7f28f249de Add support for Azure Active Directory connections (#727) 2018-11-13 11:50:30 -08:00
Aditya Bist
4f148a583b Agent/improvements (#720)
* add steps and schedules to edit job

* added alerts to edit data logic

* fixed c# style
2018-10-31 16:40:17 -07:00
Aditya Bist
0efed221ee Agent/improve steps (#710)
* added stepInfo for editing jobs/steps

* added schedules to history requests

* added alerts and schedules to history

* formatting

* code review comments

* removed smo import

* changed and optimized histories, steps, alerts and operators
2018-10-16 13:24:32 -07:00
Aditya Bist
6f69f7e303 Agent: Edit Job backend (#700)
* added stepInfo for editing jobs/steps

* added schedules to history requests

* added alerts and schedules to history

* formatting

* code review comments

* removed smo import
2018-10-04 13:52:08 -07:00
Karl Burtram
a6721bfae5 Fix null ref creating Agent Job with no description (#659) 2018-07-17 18:03:59 -07:00
Karl Burtram
b8c31e1138 Fix Agent Job rename (#657) 2018-07-16 13:18:47 -07:00
Aditya Bist
c0e5225187 added handler to fetch credentials (#656)
* added handler to fetch credentials

* added credentials to security service rather than agent service
2018-07-13 21:43:59 -07:00
Karl Burtram
626ce35440 Add Description property to Agent Job request (#655)
* Add Description property to Agent Job request

* Fix whitespace
2018-07-13 09:17:33 -07:00
Karl Burtram
4ac0ae87ee Additional edit alert updates (#652) 2018-07-09 10:48:26 -07:00
Karl Burtram
5d267303ae Fix a couple bugs with Alert update (#651)
* Alert bugs WIP

* Alert updates

* Convert tabs to spaces
2018-07-06 08:57:07 -07:00
Karl Burtram
21cccd7eaa Fix a couple bugs in proxy and alert handlers (#650) 2018-07-05 10:29:33 -07:00
Karl Burtram
d86a1ce1d3 Add Name field to AlertInfo (#649) 2018-06-30 11:16:54 -07:00
Karl Burtram
704b25f082 Add Get Alerts and Get Operators handlers (#648)
* Stage changes

* stage changes 2

* WIP 3

* Add Get Alerts and Get Operators handlers

* Add Get Proxy request handler
2018-06-28 21:12:10 -07:00
Karl Burtram
3f8ddc6c5f Remove unused code (#647) 2018-06-27 17:13:20 -07:00
Karl Burtram
c6906c3b66 Add Get Schedules request handler (#646) 2018-06-27 08:25:19 -07:00
Aditya Bist
b71f4fec27 Feature/new step (#645)
* added support for t-sql parse

* added syntax parse to language service instead

* fixed misleading error

* code review comments

* fixed run state logic
2018-06-26 19:11:18 -07:00