Commit Graph

256 Commits

Author SHA1 Message Date
Charles Gagnon
dd11be3d38 Consolidate to net6.0 (#1547)
* Add SqlClient event listener

* comments

* ensure not disposed early

* initial

* net6.0

* undo
2022-06-21 08:53:23 -07:00
Hai Cao
e190581094 Disable failing integration test (#1540) 2022-06-15 15:46:48 -07:00
Alan Ren
17b6073c87 include additional data for error object (#1539)
* include additional data for error

* fix tests
2022-06-10 20:40:22 -07:00
Alex Ma
5e3d24bbfa Remove code coverage from STS (#1537)
* WIP removal of code coverage

* more coverage removed

* more fixes

* fix tests
2022-06-10 13:53:43 -07:00
Charles Gagnon
294873613a Add Operations to GetAzureFunctions request (#1527)
* Add Operations to GetAzureFunctions request

* add comment

* comments
2022-06-06 12:59:59 -07:00
Aditya Bist
78a3f748c9 Fix integration tests (#1528)
* added dotnet version

* remove code coverage arg

* check failing test

* correct arg placement

* try commenting issue test

* add back code coverage

* ignore test instead of commenting it out

* dont need version
2022-06-03 10:42:28 -07:00
Sai Avishkar Sreerama
989137ddb7 DacFx default options test validation fixes (#1509) 2022-05-31 14:03:44 -05:00
Charles Gagnon
076ed9644b Add route to GetAzureFunctions request + cleanup (#1521)
* Add route to GetAzureFunctions request + cleanup

* update comments

* comments

* Add comment
2022-05-31 10:22:20 -07:00
Karl Burtram
5fdad0edc8 Add connection retry logic to integration tests (#1523)
* Add retry to live connection

* Disable migration test

* Tune the retry logic

* Disable SQLCMD test
2022-05-27 15:31:33 -07:00
Karl Burtram
e86b0bc87f Fix some integration tests (#1516)
* Fix integration test cases

* More test fixes

* Dacfx test fix

* Make master default test db is none specified
2022-05-26 13:08:53 -07:00
Sai Avishkar Sreerama
62d3cdc99a Revert "Revert "Adding new Dac Deployment Options and getting descriptions fr…" (#1507)
* Adding missing Deploy options

* SQL DB Project database genScript/Publish working but tests

* Test cases fixed for the changes for DacFx and SC services

* Refactored the model name and tested the changes with ADS extensions.

* updated DeploymentOptionProperty model and corresponding updates.

* Adding DisplayNames to the deploymentOptionProperty to maintain names in STS for all extensions.

* MapTabe intialization in constructor

* Updated comment with more meaning

* Porperty strong type update with actual type

* Creating model with generic type getting using Activator.CreateInstance

* Rebase to main and resolved merge conflicts

* Xml comments added and code updated

* Deployment options update

* Deployoptions typo and comments updates a

* updated deployment options comments

* removed unnecessary using statement

* code refactor

* Revert "Revert "Adding new Dac Deployment Options and getting descriptions from DacFx API (#1357)" (#1493)"

This reverts commit 2b48331115.

* removing duplicated default empty string value
2022-05-23 16:19:15 -05:00
Charles Gagnon
7787a6af7b Fix Backup/Restore parameters defaulting to wrong DeviceType (#1490) 2022-05-12 13:34:49 -07:00
Udeesha Gautam
2b48331115 Revert "Adding new Dac Deployment Options and getting descriptions from DacFx API (#1357)" (#1493)
This reverts commit a3a66137b8.
2022-05-12 13:30:04 -07:00
Charles Gagnon
3af029315b Fix bindings tests (#1488) 2022-05-10 11:09:45 -07:00
Sai Avishkar Sreerama
a3a66137b8 Adding new Dac Deployment Options and getting descriptions from DacFx API (#1357)
* Adding missing Deploy options

* SQL DB Project database genScript/Publish working but tests

* Test cases fixed for the changes for DacFx and SC services

* Refactored the model name and tested the changes with ADS extensions.

* updated DeploymentOptionProperty model and corresponding updates.

* Adding DisplayNames to the deploymentOptionProperty to maintain names in STS for all extensions.

* MapTabe intialization in constructor

* Updated comment with more meaning

* Porperty strong type update with actual type

* Creating model with generic type getting using Activator.CreateInstance

* Rebase to main and resolved merge conflicts

* Xml comments added and code updated

* Deployment options update

* Deployoptions typo and comments updates a

* updated deployment options comments

* removed unnecessary using statement

* code refactor
2022-05-10 22:59:26 +05:30
Charles Gagnon
2540068998 Fix VerifyAllSqlObjects test (#1485)
* Fix VerifyAllSqlObjects test

* comment
2022-05-06 23:13:11 -07:00
Lewis Sanchez
224c5c742c Removes unnecessary using statement to fix build error (#1479)
* Removes unnecessary using statement to fix build error

* Stops continuing the release if build.cmd task fails

* Revert "Stops continuing the release if build.cmd task fails"

This reverts commit 64c055cdfa7a5275a9144192e0740d124a92ec9a.
2022-04-26 17:22:15 -07:00
Nemanja Milovančević
881c335cdf Backup/Restore Managed Instance (#1428)
* Enabled backup to and restore from URL

* Created RPC, but when process tries to load Microsoft.Azure.Storage.Blob.dll, it crashes

* Added create shared access token

* Code refactor

* Minor changes

* Changed RPC path

* Moved createSas RPC to the newly created BlobService, fixed PR comments

* Added sas expiration date parameter to the RPC

* Added copyright headers

* Removed ConnectionInstance property from BlobService

* Removed unhelpful comment

* Removed unused using statements

* Changed copy/paste comments

* Disposable objects fix

* Small formatting fix

* Changed backup to/restore from url supported device types

* Added backup to url integration test

* Created restore integration test. Test are now getting azure blob params from env variables instead of file.

* Culture invariant epiration date param, fixed comment, and typo

* Updated headers

* PR comments fix

* Changed supported device type logic

* string localization fix

* String formatting fix

* build failure fix

* Typo

* Updated supported restore device types
2022-04-20 14:01:13 -07:00
Aasim Khan
1ce3647565 Making star expansion test cross plat (#1455)
* Making star expansion cross plat

* Fixing test

* Fixing next  line
2022-04-08 15:20:07 -07:00
Alan Ren
3452c43a51 handle hierarchyid correctly (#1450) 2022-03-31 15:18:15 -07:00
Alan Ren
b495ea7475 handle UDT type (#1424) 2022-03-11 18:10:08 -08:00
Charles Gagnon
40c5d48c5e Fail build on unneeded usings (#1417) 2022-03-04 16:38:01 -08:00
Charles Gagnon
c248400a6c Add linting for copyright and unused usings (#1416)
* Add linting for copyright and unused usings

* Add one more + comment

* Enforce in build and fix errors

* Fix build
2022-03-04 15:17:29 -08:00
Vasu Bhog
8120858ad2 Modify Get Connection String Request to use connection details (#1394)
* connection string accepts connectionInfo

* get connection string from disconnected scenarios
2022-02-10 20:48:39 -08:00
Raymond Truong
1693843ab0 [Feature] SKU recommendations in SQL migration extension (#1399)
* Initial check in for SQL migration SKU recommendation feature (#1362)

Co-authored-by: Raymond Truong <ratruong@microsoft.com>

* Integration test for Get SKU Recommendation. (#1377)

* Integration test for Get SKU Recommendation.

* Addressing comments -
1) Moving sample files to data folder.
2) Changed Assert for Positive Justification. Ideally for MI we are expecting ~6 justifications but this might change so sticking with 'recommendation should have atleast one positive justification'.

* Implement start/stop perf data collection (#1369)

* Add SqlInstanceRequirements to SKU recommendation output (#1378)

* test for data collection start and stop (#1395)

* improve error handling, add RefreshPerfDataCollection  (#1393)

* WIP - refresh data collection

* Capture messages before logging

* Update Microsoft.SqlServer.Migration.Assessment NuGet version (#1402)

* Update NuGet version to 1.0.20220208.23, update assessment metadata

* Update SKU recommendation metadata

* Include preview SKUs

* Clear message/error queue after refreshing

* Clean up

* Add 'IsCollecting' to RefreshPerfDataCollection (#1405)

Co-authored-by: Neetu Singh <23.neetu@gmail.com>
2022-02-10 19:02:27 -08:00
Vasu Bhog
8e5a23f755 Optional application name parameter for connection string (#1380)
* optional application name parameter for connection string
2022-02-03 16:00:08 -08:00
Alan Ren
995e9baeab fix decimal datatype handling (#1352)
* Revert "Revert query execution changes (#1341)"

This reverts commit cb290cdbb5.

* fix decimal and money

* timestamp

* fix code and tests

* add sql variant test
2022-01-04 13:56:12 -08:00
Karl Burtram
cb290cdbb5 Revert query execution changes (#1341)
* Revert "handle sql variable type (#1333)"

This reverts commit 51c801eb33.

* Revert "handle large decimal (#1326)"

This reverts commit fd5b8af0c0.
2021-12-15 11:15:11 -08:00
Alan Ren
fd5b8af0c0 handle large decimal (#1326) 2021-12-02 09:45:45 -08:00
Benjin Dubishar
a74b55c6a8 Applying Changes to SQL Database Projects and Using Projects in Comparison (#1296)
* passing initial testing

* update local project from database

* update local project

* update project from database

* update project from database

* update project from database

* update project from database

* update project from database

* update project from database

* update project from database

* update project from database

* update project from database

* update project from database

* Bump .net version

* PR feedback

* Adding temporary compat shim

* reverting some formatting changes; fixing strings

* PR feedback

Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
2021-11-12 12:51:35 -08:00
Lucy Zhang
aa902b78d8 Check if Azure Function method is async before adding output binding (#1297)
* check async before adding output binding

* nit
2021-11-11 15:48:44 -08:00
Lucy Zhang
8487703c21 Add generic reference if needed for Sql Input Binding (#1294)
* add generic reference if needed

* only check input binding for now
2021-11-11 10:54:42 -08:00
Benjin Dubishar
8234dcf215 Revert "Applying Changes to SQL Database Projects and Using Projects in Comparison (#1282)" (#1284)
This reverts commit 6acda6e1e6.

committedcda6e1e6ed5ff4fddb65b954951ff987fa01c06acda6e1e6ed5ff4fddb65b954951ff987fa01c0:
2021-11-05 17:25:09 -07:00
Benjin Dubishar
6acda6e1e6 Applying Changes to SQL Database Projects and Using Projects in Comparison (#1282)
* passing initial testing

* update local project from database

* update local project

* update project from database

* update project from database

* update project from database

* update project from database

* update project from database

* update project from database

* update project from database

* update project from database

* update project from database

* update project from database

* Bump .net version

* PR feedback

Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
2021-11-04 18:36:59 -07:00
Aasim Khan
e246bc5325 Adding star expression expansion (#1270) 2021-10-27 16:59:05 -07:00
Kim Santiago
0f0df25119 Add error for sql bindings when .net 5 (#1259)
* add error for sql bindings when .net 5

* add test

* cleanup linq stuff and move out common code
2021-10-07 16:13:53 -07:00
Kim Santiago
c20af4f777 Get Azure functions operation (#1228)
* add GetAzureFunctions

* add tests

* cleanup

* check for quotes

* address other comments

* add logging and let error result get sent

* rename file
2021-08-18 17:05:27 -07:00
Kim Santiago
b1653b25e4 Insert sql bindings into Azure Functions (#1224)
* getting table name from a script

* add InsertSqlInputBindingOperation

* cleanup

* move azure functions stuff out of dacfx service

* cleanup

* add tests

* add another test

* cleanup

* add comments and connection string setting

* addressing comments

* change name to use add instead of insert
2021-08-04 13:02:52 -07:00
Sai Avishkar Sreerama
37b2b26edf Filtering Schema Compare error from warnings (#1212)
* Filtering Schema Compare error from warnings

* SchemaCompare added comparison result error message validations to existing tests

* Extra semi-colon noticed and removed from the code

* Added new test case to validate warning message exclusions from SC result

* SC test asserions comment added

* Edge case scenario fixed and tests are 100% passed
2021-05-21 11:25:25 +05:30
Kim Santiago
e123c24210 fix failing schema compare options tests" (#1204) 2021-05-05 13:31:45 -07:00
Leila Lali
01d0f03262 Added service for model management for machine learning extension (#1138)
* Added service for model management for ml extension
2021-01-19 11:33:55 -08:00
Udeesha Gautam
86a4e3f514 Add build fix changes (#1143)
adding a missing namespace that was causing a build failure in test code
2020-12-31 12:23:01 -08:00
Benjin Dubishar
25c542319e Splitting out default DacFx options for Publish and Schema Compare (#1126)
* Splitting out schema comp and publish defaults

* Added test

* Correcting comments, changing scope

* Moving DeploymentOptions to DacFx folder due to dependency hierarchy between DacFx and SchemaCompare
2020-11-25 14:44:34 -08:00
Aleksei Guzev
11960fd904 Fix handling some SQL Assessment warnings (#1114)
* Some new SQL Assessment warnings may have Check property set to null. Handle the warnings with no exception.
* Make names of SQL Assessment test methods more informative.
2020-11-04 22:13:46 +03:00
Benjin Dubishar
65c4fc01aa Adding External Streaming Job I/O validation to DacFxService (#1106)
* checkpoint

* Not having cake, nor eating it

* Working

* Swapping external dll for nupkg

* Extracting statement out of full TSQL

* Improving error message

* Fixing filename capitalization

* Reverting csproj changes

* Adding updated sr.cs file

* VS lost tracking on strings file?

* PR feedback

* resx additions

* More updated string files

* Swapped nuget for dll

* Revert "Swapped nuget for dll"

This reverts commit 6013f3fadf58ebc7e3590a46811d9fd9fc3eaa4a.

* Bumped netcore version to pull in support for extern aliasing nugets
2020-11-02 12:03:14 -08:00
Karl Burtram
b9e1618260 Revert "Rollback migration changes" (#1099)
* Revert "Revert "Initial migration service changes for assessment support (#1093)" (#1098)"

This reverts commit e96c0064ad.

* Move SQL Tools Service last in Main project list
2020-10-16 16:29:22 -07:00
Charles Gagnon
e96c0064ad Revert "Initial migration service changes for assessment support (#1093)" (#1098)
This reverts commit 1a0388c8cb.
2020-10-16 13:35:59 -07:00
Karl Burtram
1a0388c8cb Initial migration service changes for assessment support (#1093)
* Migration service WIP 1

* Assessment DLLs

* WIP

* WIP 2

* Add migration nuget package

* WIP2

* Fix up assessment handler

* WIP

* Fix build scripts

* WIP

* Update Assessment references

* Fix metadata copy to work with publish
2020-10-13 11:02:29 -07:00
Aleksei Guzev
07700560a6 Fix script generated for SQL Assessment results (#1058)
* INSERT VALUES has the limit of 1000 rows. Replace with derived table.
* Remove NOT NULL restriction from the generated table.
* Fix line endings in SQL Assessment source files.
2020-08-28 20:17:54 +03:00
Justin M
61ada47820 Fixed integration tests in Microsoft.SqlTools.ServiceLayer.IntegrationTests by removing reference to Microsoft.Kusto.ServiceLayer/Microsoft.Kusto.ServiceLayer.csproj within the IntregrationTest project. (#1051) 2020-08-18 11:36:13 -07:00