Commit Graph

704 Commits

Author SHA1 Message Date
AlexFsmn
41d0ef1814 Fixed correct value types when saving columns to a json file (#691) 2018-09-25 14:24:39 -07:00
ranasaria
09652cccd1 Enhanced Logging for sqltoolsservice (#695)
This change modifies the logging framework within sqltoolservice.
Moves away from custom Logger object to start using .Net tracing framework. It supports for the static Trace and TraceSource way of logging. For all new code it is recommend that we log the log messages using the existing static Logger class, while the code changes will continue to route the older Trace.Write* calls from the process to same log listeners (and thus the log targets) as used by the Logger class. Thus tracing in SMO code that uses Trace.Write* methods gets routed to the same file as the messages from rest of SQLTools Service code.
Make changes to start using .Net Frameworks codebase for all logging to unify our logging story.
Allows parameter to set tracingLevel filters that controls what kinds of message make it to the log file.
Allows a parameter to set a specific log file name so if these gets set by external code (the UI code using the tools service for example) then the external code is aware of the current log file in use.
Adding unittests to test out the existing and improved logging capabilities.


Sequences of checkins in development branch:
* Saving v1 of logging to prepare for code review. Minor cleanup and some end to end testing still remains
* Removing local launchSettings.json files
* added support for lazy listener to sqltoolsloglistener and removed incorrect changes to comments across files in previous checkin
* Converting time to local time when writing entries to the log
* move the hosting.v2 to new .net based logging code
* removing *.dgml files and addding them to .gitignore
* fixing typo of defaultTraceSource
* Addressing pull request feedback
* Adding a test to verify logging from SMO codebase
* propogating changes to v1 sqltools.hosting commandoptions.cs to the v2 version
* Fixing comments on start and stop callstack methods and whitespaces
* Commenting a test that got uncommented by mistake
* addding .gitattributes file as .sql file was observed to be misconstrued as a binary file
2018-09-24 23:55:59 -07:00
AlexFsmn
d8c088e0f6 Fixed correct max column labels for varbinary, nvarchar and varchar (#692) 2018-09-18 14:34:00 -07:00
Mustafa Sadedil
98018c5292 Save as XML feature added (#684)
Similar approach used like Save as JSON or Save as CSV.
2018-09-10 12:11:51 -07:00
Karl Burtram
066be2f46f Revert "Switch to the unified SMO NuGet" (#686)
* Revert "fixed perf tests and added more scenarios (#683)"

This reverts commit aa2b30f486.

* Revert "Switch to the unified SMO NuGet so all binaries are strong named and signed. (#682)"

This reverts commit 69961992bb.
2018-09-04 11:01:44 -07:00
David Shiflet
69961992bb Switch to the unified SMO NuGet so all binaries are strong named and signed. (#682) 2018-08-20 08:27:52 -04:00
Anthony Dresser
3c0a282333 Serialize Connection String (#680)
* add string serialization

* add unadded file

* changed code to be testable, added test

* moved test to correct location

* change to send undefined rather than error if the serialization fails

* update request name
2018-08-16 13:10:14 -07:00
Alan Ren
df3c312984 Fix for https://github.com/Microsoft/sqlopsstudio/issues/1317 (#681)
* Fix for https://github.com/Microsoft/sqlopsstudio/issues/1317

* formatting the code
2018-08-14 14:00:46 -07:00
Alan Ren
fb157520d9 fix for https://github.com/Microsoft/sqlopsstudio/issues/2066 (#677) 2018-08-10 16:28:01 -07:00
David Shiflet
5cdab53da8 Upgrade SMO packages to fix issue with scripting tables (#678)
* Upgrade SMO packages to fix issue with scripting tables when Script Dependencies is true on the script options.

* use linux style import with case matching file name
2018-08-09 08:11:18 -04:00
Karl Burtram
4ac02eab01 Add back XEventDBScopedEnum to fix Profiler in Azure (#674) 2018-08-03 03:16:09 -04:00
Madeline MacDonald
4b9807f0cf Add ability to create sessions from templates, and list existing sessions (#671)
* Initial changes to connect to existing sessions

* Creating new profiler sessions

* Some session template changes

* Fixing errors

* Cleaning up comments, string constants, and formatting

* Removing commented code
2018-08-02 12:50:26 -07:00
Karl Burtram
290b242015 Add back missing XEventEnum dependency (#672) 2018-08-01 20:35:10 -04:00
Karl Burtram
38cf5414ce Add IncludePassword parameter to Get Connection String request (#670)
* Add IncludePassword flag to get connection string method

* Override connection application name

* Fix typo

* Fix test break

* Use ****** as password placeholder
2018-08-01 15:16:01 -04:00
Sebastian Pfliegel
84f62a3e85 Added more options to SaveResultsAsCsvRequestParams (#669)
Fixes Microsoft/sqlopsstudio#203
Options:
LineSeperator
TextIdentifier
Encoding
2018-08-01 15:15:11 -04:00
David Shiflet
0b4228a7d9 Update Sql Management Objects to latest version (#666) 2018-07-27 17:25:16 -04:00
Aditya Bist
f293a54af7 Multiple batch execution time (#664)
* fixed bug where execution time was wrong for multiple batches

* fixed bug where multiple execution would show wrong execution time

* simplified logic
2018-07-25 16:45:26 -07:00
Karl Burtram
7c96ceb501 Get Connection String request handler (#665) 2018-07-25 15:03:00 -04:00
Karl Burtram
a6721bfae5 Fix null ref creating Agent Job with no description (#659) 2018-07-17 18:03:59 -07:00
Madeline MacDonald
ec9d51ede1 Improving profiler error messages (#658)
* Improving error messages

* Fixing stopping error message

* Cleaning up repeat error messages

* Changing error names
2018-07-16 18:22:12 -07:00
Karl Burtram
b8c31e1138 Fix Agent Job rename (#657) 2018-07-16 13:18:47 -07:00
Aditya Bist
c0e5225187 added handler to fetch credentials (#656)
* added handler to fetch credentials

* added credentials to security service rather than agent service
2018-07-13 21:43:59 -07:00
Karl Burtram
626ce35440 Add Description property to Agent Job request (#655)
* Add Description property to Agent Job request

* Fix whitespace
2018-07-13 09:17:33 -07:00
Chirag Rupani
77a08b4bdd Added support for specifying delimiter while exporting query results as CSV (#653) 2018-07-12 10:39:23 -07:00
Kevin Cunnane
ebaec9c319 Fix GUID parse error breaking some on-prem connections (#654)
* Fix GUID parse error breaking on-prem connections
- Fixes https://github.com/Microsoft/sqlopsstudio/issues/1896
- Verified this is only used in retry logic on Azure, so the fact it's failing on-prem isn't relevant. It's still unclear why in some cases the session ID is non-null but not a GUID.

* Added back logging if parse of the GUID fails
2018-07-11 09:27:41 -07:00
Karl Burtram
4ac0ae87ee Additional edit alert updates (#652) 2018-07-09 10:48:26 -07:00
Karl Burtram
5d267303ae Fix a couple bugs with Alert update (#651)
* Alert bugs WIP

* Alert updates

* Convert tabs to spaces
2018-07-06 08:57:07 -07:00
Karl Burtram
21cccd7eaa Fix a couple bugs in proxy and alert handlers (#650) 2018-07-05 10:29:33 -07:00
Karl Burtram
d86a1ce1d3 Add Name field to AlertInfo (#649) 2018-06-30 11:16:54 -07:00
Karl Burtram
704b25f082 Add Get Alerts and Get Operators handlers (#648)
* Stage changes

* stage changes 2

* WIP 3

* Add Get Alerts and Get Operators handlers

* Add Get Proxy request handler
2018-06-28 21:12:10 -07:00
Karl Burtram
3f8ddc6c5f Remove unused code (#647) 2018-06-27 17:13:20 -07:00
Karl Burtram
c6906c3b66 Add Get Schedules request handler (#646) 2018-06-27 08:25:19 -07:00
Aditya Bist
b71f4fec27 Feature/new step (#645)
* added support for t-sql parse

* added syntax parse to language service instead

* fixed misleading error

* code review comments

* fixed run state logic
2018-06-26 19:11:18 -07:00
Aditya Bist
7c7395fce0 Added support for T-SQL parse (#642)
* added support for t-sql parse

* added syntax parse to language service instead

* fixed misleading error

* code review comments
2018-06-26 14:19:05 -07:00
Karl Burtram
539d579a9b Add Agent Job Defaults request handler (#644)
* Add Agent Job Defaults request handler

* Fix a couple bugs
2018-06-26 13:57:47 -07:00
Madeline MacDonald
cc2ca4cad3 Support profiling on Azure instances (#643)
* Support profiling Azure instances

* Spacing fixes

* Localizing error message for azure DB profiling
2018-06-26 10:55:30 -07:00
Madeline MacDonald
838a7e4fab Profiler notifications (#640)
* Initial changes for adding lost event notifications

* Handling polling errors by notifying listeners

* Restructuring lost events & testing

* Minor fixes to tests

* Add back in filtering

* Changing how lost events are found

* Cleaning up tests
2018-06-18 17:43:22 -07:00
Matt Irvine
f244d307e2 Work around edit data trailing comment bug (#641)
* Work around edit data trailing comment bug

* Use Environment.NewLine
2018-06-18 20:39:25 -04:00
Leila Lali
7322854c7b fixed the bug with view triggers in object explorer (#639) 2018-06-18 11:36:24 -07:00
Karl Burtram
29fb715ad5 Add initial schedule request handlers (#638) 2018-06-18 10:18:23 -07:00
Karl Burtram
d2cc376b87 Agent Proxy and Credential request handlers (#637)
* Agent Proxy account WIP

* Fixup Credential create\update\delete handlers

* Use current user for test credential

* Cleanup and delete code

* Convert tabs to spaces
2018-06-14 11:55:38 -07:00
Madeline MacDonald
f53e532225 Adding pausing functionality for the profiler (#634)
* Dropping profiler session on stop request

* Changes to IXEventSession to simplify dropping sessions

* Stop sessions instead of dropping, disable flaky tests

* Initial framework for profiler pause requests

* Restructuring profiler session monitoring

* Fixes to session monitor

* Testing for pause functionality

* Fixing comments from PR

* Changes to testing

* Commenting out flaky test

* Deleting leftover testing code
2018-06-13 17:55:01 -07:00
Karl Burtram
aff0f1afae Drop job step and Create\Update alert handlers (#636)
* Add Delete Job Step implementation

* Update create\update agent alert handlers to use execution handler

* Cleanup create/update/delete operator request handlers
2018-06-13 17:49:11 -07:00
Karl Burtram
8dda34c95a Add Agent Job and Job Step request handlers (#635)
* Stage changes

* Fix update job request handler

* WIP

* Additional agent handler updates

* Setup agent job step create test

* Fix Step update handler
2018-06-13 10:02:25 -07:00
Karl Burtram
7c1f78a678 Update Agent contracts to match SQL Ops definitons (#633)
* WIP 2

* Update contracts to match SQL Ops definitons
2018-06-11 16:32:46 -07:00
Karl Burtram
372ca0cbe8 Agent configuration support classes (WIP) (#632)
* Additional SQL Agent config classes (WIP)

* Fix build breaks

* Clean up job step code

* Add VS Code build files

* Move changes to other machine

* More of the action execution classes

* More execution processing refactors

* More refactoring

* Disable tests for WIP merge

* Fix break on Release config

* Stage changes to other machine.
2018-06-07 12:08:24 -07:00
Madeline MacDonald
35b19320d4 Stopping sessions when handling stop requests (#627)
* Dropping profiler session on stop request

* Changes to IXEventSession to simplify dropping sessions

* Stop sessions instead of dropping, disable flaky tests
2018-06-05 13:48:55 -07:00
Karl Burtram
4f214f43e9 SQL Agent configuration for Operators, Alerts and Proxies (WIP) (#621)
* Initial non-refactored SQL Agent alert classes (WIP)

* Move agent classes into subdirectories

* Refactor the agent config code a bit more

* Add more implementation for handlers

* Add more code to the create alert handler

* Clean up agent alert class

* Clean up alert methods a bit

* Initial Operator contracts

* Additonal SQL Agent config changes

* More Proxy config cleanup

* Cleanup AgentProxy class

* Additional cleanups

* Run SRGen

* Add security service to create credential objects
2018-05-30 08:58:02 -07:00
Madeline MacDonald
f5efe18e1b Updating profiler old event filtering and unit tests (#624) 2018-05-29 17:08:59 -07:00
Madeline MacDonald
c87b369426 Changing polling on startup to avoid profiler freezing (#620) 2018-05-24 18:00:12 -07:00