mirror of
https://github.com/ckaczor/sqltoolsservice.git
synced 2026-01-14 09:59:48 -05:00
The main goal of this feature is to enable a command that will 1) Generate a parameterized command for each edit that is in the session 2) Execute that command against the server 3) Update the cached results of the table/view that's being edited with the committed changes (including computed/identity columns) There's some secret sauce in here where I cheated around worrying about gaps in the updated results. This was accomplished by implementing an IComparable for row edit objects that ensures deletes are the *last* actions to occur and that they occur from the bottom of the list up (highest row ID to lowest). Thus, all other actions that are dependent on the row ID are performed first, then the largest row ID is deleted, then next largest, etc. Nevertheless, by the end of a commit the associated ResultSet is still the source of truth. It is expected that the results grid will need updating once changes are committed. Also worth noting, although this pull request supports a "many edits, one commit" approach, it will work just fine for a "one edit, one commit" approach. * WIP * Adding basic commit support. Deletions work! * Nailing down the commit logic, insert commits work! * Updates work! * Fixing bug in DbColumnWrapper IsReadOnly setting * Comments * ResultSet unit tests, fixing issue with seeking in mock writers * Unit tests for RowCreate commands * Unit tests for RowDelete * RowUpdate unit tests * Session and edit base tests * Fixing broken unit tests * Moving constants to constants file * Addressing code review feedback * Fixes from merge issues, string consts * Removing ad-hoc code * fixing as per @abist requests * Fixing a couple more issues
104 lines
4.0 KiB
C#
104 lines
4.0 KiB
C#
//
|
|
// Copyright (c) Microsoft. All rights reserved.
|
|
// Licensed under the MIT license. See LICENSE file in the project root for full license information.
|
|
//
|
|
|
|
using System.Collections.Generic;
|
|
using System.Data.Common;
|
|
using System.Linq;
|
|
using System.Threading;
|
|
using Microsoft.SqlTools.ServiceLayer.EditData;
|
|
using Microsoft.SqlTools.ServiceLayer.EditData.UpdateManagement;
|
|
using Microsoft.SqlTools.ServiceLayer.QueryExecution;
|
|
using Microsoft.SqlTools.ServiceLayer.QueryExecution.Contracts;
|
|
using Microsoft.SqlTools.ServiceLayer.Test.Common;
|
|
using Microsoft.SqlTools.ServiceLayer.UnitTests.Utility;
|
|
using Microsoft.SqlTools.Utility;
|
|
using Moq;
|
|
|
|
namespace Microsoft.SqlTools.ServiceLayer.UnitTests.EditData
|
|
{
|
|
public class Common
|
|
{
|
|
public const string OwnerUri = "testFile";
|
|
|
|
public static IEditTableMetadata GetMetadata(DbColumn[] columns, bool allKeys = true, bool isMemoryOptimized = false)
|
|
{
|
|
// Create a Column Metadata Provider
|
|
var columnMetas = columns.Select((c, i) =>
|
|
new EditColumnWrapper
|
|
{
|
|
DbColumn = new DbColumnWrapper(c),
|
|
EscapedName = c.ColumnName,
|
|
Ordinal = i,
|
|
IsKey = c.IsIdentity.HasTrue()
|
|
}).ToArray();
|
|
|
|
// Create a table metadata provider
|
|
var tableMetaMock = new Mock<IEditTableMetadata>();
|
|
if (allKeys)
|
|
{
|
|
// All columns should be returned as "keys"
|
|
tableMetaMock.Setup(m => m.KeyColumns).Returns(columnMetas);
|
|
}
|
|
else
|
|
{
|
|
// All identity columns should be returned as keys
|
|
tableMetaMock.Setup(m => m.KeyColumns).Returns(columnMetas.Where(c => c.DbColumn.IsIdentity.HasTrue()));
|
|
}
|
|
tableMetaMock.Setup(m => m.Columns).Returns(columnMetas);
|
|
tableMetaMock.Setup(m => m.IsMemoryOptimized).Returns(isMemoryOptimized);
|
|
tableMetaMock.Setup(m => m.EscapedMultipartName).Returns("tbl");
|
|
|
|
return tableMetaMock.Object;
|
|
}
|
|
|
|
public static DbColumn[] GetColumns(bool includeIdentity)
|
|
{
|
|
List<DbColumn> columns = new List<DbColumn>();
|
|
|
|
if (includeIdentity)
|
|
{
|
|
columns.Add(new TestDbColumn("id", true));
|
|
}
|
|
|
|
for (int i = 0; i < 3; i++)
|
|
{
|
|
columns.Add(new TestDbColumn($"col{i}"));
|
|
}
|
|
return columns.ToArray();
|
|
}
|
|
|
|
public static ResultSet GetResultSet(DbColumn[] columns, bool includeIdentity, int rowCount = 1)
|
|
{
|
|
IEnumerable<object[]> rows = includeIdentity
|
|
? Enumerable.Repeat(new object[] { "id", "1", "2", "3" }, rowCount)
|
|
: Enumerable.Repeat(new object[] { "1", "2", "3" }, rowCount);
|
|
var testResultSet = new TestResultSet(columns, rows);
|
|
var reader = new TestDbDataReader(new[] { testResultSet });
|
|
var resultSet = new ResultSet(0, 0, MemoryFileSystem.GetFileStreamFactory());
|
|
resultSet.ReadResultToEnd(reader, CancellationToken.None).Wait();
|
|
return resultSet;
|
|
}
|
|
|
|
public static DbDataReader GetNewRowDataReader(DbColumn[] columns, bool includeIdentity)
|
|
{
|
|
object[][] rows = includeIdentity
|
|
? new[] {new object[] {"id", "q", "q", "q"}}
|
|
: new[] {new object[] {"q", "q", "q"}};
|
|
var testResultSet = new TestResultSet(columns, rows);
|
|
return new TestDbDataReader(new [] {testResultSet});
|
|
}
|
|
|
|
public static void AddCells(RowEditBase rc, bool includeIdentity)
|
|
{
|
|
// Skip the first column since if identity, since identity columns can't be updated
|
|
int start = includeIdentity ? 1 : 0;
|
|
for (int i = start; i < rc.AssociatedResultSet.Columns.Length; i++)
|
|
{
|
|
rc.SetCell(i, "123");
|
|
}
|
|
}
|
|
}
|
|
}
|