mirror of
https://github.com/ckaczor/sqltoolsservice.git
synced 2026-01-14 09:59:48 -05:00
The main goal of this feature is to enable a command that will 1) Generate a parameterized command for each edit that is in the session 2) Execute that command against the server 3) Update the cached results of the table/view that's being edited with the committed changes (including computed/identity columns) There's some secret sauce in here where I cheated around worrying about gaps in the updated results. This was accomplished by implementing an IComparable for row edit objects that ensures deletes are the *last* actions to occur and that they occur from the bottom of the list up (highest row ID to lowest). Thus, all other actions that are dependent on the row ID are performed first, then the largest row ID is deleted, then next largest, etc. Nevertheless, by the end of a commit the associated ResultSet is still the source of truth. It is expected that the results grid will need updating once changes are committed. Also worth noting, although this pull request supports a "many edits, one commit" approach, it will work just fine for a "one edit, one commit" approach. * WIP * Adding basic commit support. Deletions work! * Nailing down the commit logic, insert commits work! * Updates work! * Fixing bug in DbColumnWrapper IsReadOnly setting * Comments * ResultSet unit tests, fixing issue with seeking in mock writers * Unit tests for RowCreate commands * Unit tests for RowDelete * RowUpdate unit tests * Session and edit base tests * Fixing broken unit tests * Moving constants to constants file * Addressing code review feedback * Fixes from merge issues, string consts * Removing ad-hoc code * fixing as per @abist requests * Fixing a couple more issues
118 lines
5.0 KiB
C#
118 lines
5.0 KiB
C#
//
|
|
// Copyright (c) Microsoft. All rights reserved.
|
|
// Licensed under the MIT license. See LICENSE file in the project root for full license information.
|
|
//
|
|
|
|
using System.Threading.Tasks;
|
|
using Microsoft.SqlTools.ServiceLayer.QueryExecution;
|
|
using Microsoft.SqlTools.ServiceLayer.QueryExecution.Contracts;
|
|
using Microsoft.SqlTools.ServiceLayer.QueryExecution.Contracts.ExecuteRequests;
|
|
using Microsoft.SqlTools.ServiceLayer.QueryExecution.DataStorage;
|
|
using Microsoft.SqlTools.ServiceLayer.SqlContext;
|
|
using Microsoft.SqlTools.ServiceLayer.UnitTests.Utility;
|
|
using Microsoft.SqlTools.ServiceLayer.Test.Common;
|
|
using Microsoft.SqlTools.ServiceLayer.Workspace;
|
|
using Moq;
|
|
using Xunit;
|
|
|
|
namespace Microsoft.SqlTools.ServiceLayer.UnitTests.QueryExecution
|
|
{
|
|
public class DisposeTests
|
|
{
|
|
[Fact]
|
|
public void DisposeResultSet()
|
|
{
|
|
// Setup: Mock file stream factory, mock db reader
|
|
var mockFileStreamFactory = new Mock<IFileStreamFactory>();
|
|
|
|
// If: I setup a single resultset and then dispose it
|
|
ResultSet rs = new ResultSet(Common.Ordinal, Common.Ordinal, mockFileStreamFactory.Object);
|
|
rs.Dispose();
|
|
|
|
// Then: The file that was created should have been deleted
|
|
mockFileStreamFactory.Verify(fsf => fsf.DisposeFile(It.IsAny<string>()), Times.Once);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task DisposeExecutedQuery()
|
|
{
|
|
// If:
|
|
// ... I request a query (doesn't matter what kind)
|
|
var workspaceService = Common.GetPrimedWorkspaceService(Constants.StandardQuery);
|
|
var queryService = Common.GetPrimedExecutionService(null, true, false, workspaceService);
|
|
var executeParams = new ExecuteDocumentSelectionParams {QuerySelection = null, OwnerUri = Constants.OwnerUri};
|
|
var executeRequest = RequestContextMocks.Create<ExecuteRequestResult>(null);
|
|
await queryService.HandleExecuteRequest(executeParams, executeRequest.Object);
|
|
await queryService.ActiveQueries[Constants.OwnerUri].ExecutionTask;
|
|
|
|
// ... And then I dispose of the query
|
|
var disposeParams = new QueryDisposeParams {OwnerUri = Constants.OwnerUri};
|
|
var disposeRequest = new EventFlowValidator<QueryDisposeResult>()
|
|
.AddStandardQueryDisposeValidator()
|
|
.Complete();
|
|
await queryService.HandleDisposeRequest(disposeParams, disposeRequest.Object);
|
|
|
|
// Then:
|
|
// ... And the active queries should be empty
|
|
disposeRequest.Validate();
|
|
Assert.Empty(queryService.ActiveQueries);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task QueryDisposeMissingQuery()
|
|
{
|
|
// If:
|
|
// ... I attempt to dispose a query that doesn't exist
|
|
var workspaceService = new Mock<WorkspaceService<SqlToolsSettings>>();
|
|
var queryService = Common.GetPrimedExecutionService(null, false, false, workspaceService.Object);
|
|
var disposeParams = new QueryDisposeParams {OwnerUri = Constants.OwnerUri};
|
|
|
|
var disposeRequest = new EventFlowValidator<QueryDisposeResult>()
|
|
.AddErrorValidation<string>(Assert.NotEmpty)
|
|
.Complete();
|
|
await queryService.HandleDisposeRequest(disposeParams, disposeRequest.Object);
|
|
|
|
// Then: I should have received an error
|
|
disposeRequest.Validate();
|
|
}
|
|
|
|
[Fact]
|
|
public async Task ServiceDispose()
|
|
{
|
|
// Setup:
|
|
// ... We need a query service
|
|
var workspaceService = Common.GetPrimedWorkspaceService(Constants.StandardQuery);
|
|
var queryService = Common.GetPrimedExecutionService(null, true, false, workspaceService);
|
|
|
|
// If:
|
|
// ... I execute some bogus query
|
|
var queryParams = new ExecuteDocumentSelectionParams { QuerySelection = Common.WholeDocument, OwnerUri = Constants.OwnerUri };
|
|
var requestContext = RequestContextMocks.Create<ExecuteRequestResult>(null);
|
|
await queryService.HandleExecuteRequest(queryParams, requestContext.Object);
|
|
await queryService.ActiveQueries[Constants.OwnerUri].ExecutionTask;
|
|
|
|
// ... And it sticks around as an active query
|
|
Assert.Equal(1, queryService.ActiveQueries.Count);
|
|
|
|
// ... The query execution service is disposed, like when the service is shutdown
|
|
queryService.Dispose();
|
|
|
|
// Then:
|
|
// ... There should no longer be an active query
|
|
Assert.Empty(queryService.ActiveQueries);
|
|
}
|
|
}
|
|
|
|
public static class QueryDisposeEventFlowValidatorExtensions
|
|
{
|
|
public static EventFlowValidator<QueryDisposeResult> AddStandardQueryDisposeValidator(
|
|
this EventFlowValidator<QueryDisposeResult> evf)
|
|
{
|
|
// We just need to make sure that the result is not null
|
|
evf.AddResultValidation(Assert.NotNull);
|
|
|
|
return evf;
|
|
}
|
|
}
|
|
}
|