mirror of
https://github.com/ckaczor/sqltoolsservice.git
synced 2026-01-15 17:23:32 -05:00
This is a very large change. I'll try to outline what's going on.
1. This adds the **EditDataService** which manages editing **Sessions**.
1. Each session has a **ResultSet** (from the QueryExecutionService) which has the rows of the table and basic metadata about the columns
2. Each session also has an **IEditTableMetadata** implementation which is derived from SMO metadata which provides more in-depth and trustworthy data about the table than SqlClient alone can.
3. Each session holds a list of **RowEditBase** abstract class implementations
1. **RowUpdate** - Update cells in a row (generates `UPDATE` statement)
2. **RowDelete** - Delete an entire row (generates `DELETE` statement)
3. **RowCreate** - Add a new row (generates `INSERT INTO` statement)
4. Row edits have a collection of **CellUpdates** that hold updates for individual cells (except for RowDelete)
1. Cell updates are generated from text
5. RowEditBase offers some baseline functionality
1. Generation of `WHERE` clauses (which can be parameterized)
2. Validation of whether a column can be updated
2. New API Actions
1. edit/initialize - Queries for the contents of a table/view, builds SMO metadata, sets up a session
2. edit/createRow - Adds a new RowCreate to the Session
3. edit/deleteRow - Adds a new RowDelete to the Session
4. edit/updateCell - Adds a CellUpdate to a RowCreate or RowUpdate in the Session
5. edit/revertRow - Removes a RowCreate, RowDelete, or RowUpdate from the Session
6. edit/script - Generates a script for the changes in the Session and stores to disk
7. edit/dispose - Removes a Session and releases the query
3. Smaller updates (unit test mock improvements, tweaks to query execution service)
**There are more updates planned -- this is just to get eyeballs on the main body of code**
* Initial stubs for edit data service
* Stubbing out update management code
* Adding rudimentary dispose request
* More stubbing out of update row code
* Adding complete edit command contracts, stubbing out request handlers
* Adding basic implementation of get script
* More in progress work to implement base of row edits
* More in progress work to implement base of row edits
* Adding string => object conversion logic and various cleanup
* Adding a formatter for using values in scripts
* Splitting IMessageSender into IEventSender and IRequestSender
* Adding inter-service method for executing queries
* Adding inter-service method for disposing of a query
* Changing edit contract to include the object to edit
* Fully fleshing out edit session initialization
* Generation of delete scripts is working
* Adding scripter for update statements
* Adding scripting functionality for INSERT statements
* Insert, Update, and Delete all working with SMO metadata
* Polishing for SqlScriptFormatter
* Unit tests and reworked byte[] conversion
* Replacing the awful and inflexible Dictionary<string, string>[][] with a much better test data set class
* Fixing syntax error in generated UPDATE statements
* Adding unit tests for RowCreate
* Adding tests for the row edit base class
* Adding row delete tests
* Adding RowUpdate tests, validation for number of key columns
* Adding tests for the unit class
* Adding get script tests for the session
* Service integration tests, except initialization tests
* Service integration tests, except initialization tests
* Adding messages to sr.strings
* Adding messages to sr.strings
* Fixing broken unit tests
* Adding factory pattern for SMO metadata provider
* Copyright and other comments
* Addressing first round of comments
* Refactoring EditDataService to have a single method for handling
session-dependent operations
* Refactoring Edit Data contracts to inherit from a Session and Row
operation params base class
* Copyright additions
* Small tweak to strings
* Updated unit tests to test the refactors
* More revisions as per pull request comments
198 lines
8.1 KiB
C#
198 lines
8.1 KiB
C#
//
|
|
// Copyright (c) Microsoft. All rights reserved.
|
|
// Licensed under the MIT license. See LICENSE file in the project root for full license information.
|
|
//
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Data.Common;
|
|
using System.Data.SqlClient;
|
|
using System.Linq;
|
|
using Microsoft.SqlTools.ServiceLayer.EditData.Contracts;
|
|
using Microsoft.SqlTools.ServiceLayer.QueryExecution;
|
|
using Microsoft.SqlTools.ServiceLayer.QueryExecution.Contracts;
|
|
using Microsoft.SqlTools.ServiceLayer.Utility;
|
|
|
|
namespace Microsoft.SqlTools.ServiceLayer.EditData.UpdateManagement
|
|
{
|
|
/// <summary>
|
|
/// Base class for row edit operations. Provides basic information and helper functionality
|
|
/// that all RowEdit implementations can use. Defines functionality that must be implemented
|
|
/// in all child classes.
|
|
/// </summary>
|
|
public abstract class RowEditBase
|
|
{
|
|
/// <summary>
|
|
/// Internal parameterless constructor, required for mocking
|
|
/// </summary>
|
|
protected internal RowEditBase() { }
|
|
|
|
/// <summary>
|
|
/// Base constructor for a row edit. Stores the state that should be available to all row
|
|
/// edit implementations.
|
|
/// </summary>
|
|
/// <param name="rowId">The internal ID of the row that is being edited</param>
|
|
/// <param name="associatedResultSet">The result set that will be updated</param>
|
|
/// <param name="associatedMetadata">Metadata provider for the object to edit</param>
|
|
protected RowEditBase(long rowId, ResultSet associatedResultSet, IEditTableMetadata associatedMetadata)
|
|
{
|
|
RowId = rowId;
|
|
AssociatedResultSet = associatedResultSet;
|
|
AssociatedObjectMetadata = associatedMetadata;
|
|
}
|
|
|
|
#region Properties
|
|
|
|
/// <summary>
|
|
/// The internal ID of the row to which this edit applies, relative to the result set
|
|
/// </summary>
|
|
public long RowId { get; }
|
|
|
|
/// <summary>
|
|
/// The result set that is associated with this row edit
|
|
/// </summary>
|
|
public ResultSet AssociatedResultSet { get; }
|
|
|
|
/// <summary>
|
|
/// The metadata for the table this edit is associated to
|
|
/// </summary>
|
|
public IEditTableMetadata AssociatedObjectMetadata { get; }
|
|
|
|
#endregion
|
|
|
|
/// <summary>
|
|
/// Converts the row edit into a SQL statement
|
|
/// </summary>
|
|
/// <returns>A SQL statement</returns>
|
|
public abstract string GetScript();
|
|
|
|
/// <summary>
|
|
/// Changes the value a cell in the row.
|
|
/// </summary>
|
|
/// <param name="columnId">Ordinal of the column in the row to update</param>
|
|
/// <param name="newValue">The new value for the cell</param>
|
|
/// <returns>The value of the cell after applying validation logic</returns>
|
|
public abstract EditUpdateCellResult SetCell(int columnId, string newValue);
|
|
|
|
/// <summary>
|
|
/// Performs validation of column ID and if column can be updated.
|
|
/// </summary>
|
|
/// <exception cref="ArgumentOutOfRangeException">
|
|
/// If <paramref name="columnId"/> is less than 0 or greater than the number of columns
|
|
/// in the row
|
|
/// </exception>
|
|
/// <exception cref="InvalidOperationException">If the column is not updatable</exception>
|
|
/// <param name="columnId">Ordinal of the column to update</param>
|
|
protected void ValidateColumnIsUpdatable(int columnId)
|
|
{
|
|
// Sanity check that the column ID is within the range of columns
|
|
if (columnId >= AssociatedResultSet.Columns.Length || columnId < 0)
|
|
{
|
|
throw new ArgumentOutOfRangeException(nameof(columnId), SR.EditDataColumnIdOutOfRange);
|
|
}
|
|
|
|
DbColumnWrapper column = AssociatedResultSet.Columns[columnId];
|
|
if (!column.IsUpdatable)
|
|
{
|
|
throw new InvalidOperationException(SR.EditDataColumnCannotBeEdited);
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Generates a WHERE clause that uses the key columns of the table to uniquely identity
|
|
/// the row that will be updated.
|
|
/// </summary>
|
|
/// <param name="parameterize">
|
|
/// Whether or not to generate a parameterized where clause. If <c>true</c> verbatim values
|
|
/// will be replaced with paremeters (like @Param12). The parameters must be added to the
|
|
/// SqlCommand used to execute the commit.
|
|
/// </param>
|
|
/// <returns>A <see cref="WhereClause"/> object</returns>
|
|
protected WhereClause GetWhereClause(bool parameterize)
|
|
{
|
|
WhereClause output = new WhereClause();
|
|
|
|
if (!AssociatedObjectMetadata.KeyColumns.Any())
|
|
{
|
|
throw new InvalidOperationException(SR.EditDataColumnNoKeyColumns);
|
|
}
|
|
|
|
IList<DbCellValue> row = AssociatedResultSet.GetRow(RowId);
|
|
foreach (EditColumnWrapper col in AssociatedObjectMetadata.KeyColumns)
|
|
{
|
|
// Put together a clause for the value of the cell
|
|
DbCellValue cellData = row[col.Ordinal];
|
|
string cellDataClause;
|
|
if (cellData.IsNull)
|
|
{
|
|
cellDataClause = "IS NULL";
|
|
}
|
|
else
|
|
{
|
|
if (cellData.RawObject is byte[] ||
|
|
col.DbColumn.DataTypeName.Equals("TEXT", StringComparison.OrdinalIgnoreCase) ||
|
|
col.DbColumn.DataTypeName.Equals("NTEXT", StringComparison.OrdinalIgnoreCase))
|
|
{
|
|
// Special cases for byte[] and TEXT/NTEXT types
|
|
cellDataClause = "IS NOT NULL";
|
|
}
|
|
else
|
|
{
|
|
// General case is to just use the value from the cell
|
|
if (parameterize)
|
|
{
|
|
// Add a parameter and parameterized clause component
|
|
// NOTE: We include the row ID to make sure the parameter is unique if
|
|
// we execute multiple row edits at once.
|
|
string paramName = $"@Param{RowId}{col.Ordinal}";
|
|
cellDataClause = $"= {paramName}";
|
|
output.Parameters.Add(new SqlParameter(paramName, col.DbColumn.SqlDbType));
|
|
}
|
|
else
|
|
{
|
|
// Add the clause component with the formatted value
|
|
cellDataClause = $"= {SqlScriptFormatter.FormatValue(cellData, col.DbColumn)}";
|
|
}
|
|
}
|
|
}
|
|
|
|
string completeComponent = $"({col.EscapedName} {cellDataClause})";
|
|
output.ClauseComponents.Add(completeComponent);
|
|
}
|
|
|
|
return output;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Represents a WHERE clause that can be used for identifying a row in a table.
|
|
/// </summary>
|
|
protected class WhereClause
|
|
{
|
|
/// <summary>
|
|
/// Constructs and initializes a new where clause
|
|
/// </summary>
|
|
public WhereClause()
|
|
{
|
|
Parameters = new List<DbParameter>();
|
|
ClauseComponents = new List<string>();
|
|
}
|
|
|
|
/// <summary>
|
|
/// SqlParameters used in a parameterized query. If this object was generated without
|
|
/// parameterization, this will be an empty list
|
|
/// </summary>
|
|
public List<DbParameter> Parameters { get; }
|
|
|
|
/// <summary>
|
|
/// Strings that make up the WHERE clause, such as <c>"([col1] = 'something')"</c>
|
|
/// </summary>
|
|
public List<string> ClauseComponents { get; }
|
|
|
|
/// <summary>
|
|
/// Total text of the WHERE clause that joins all the components with AND
|
|
/// </summary>
|
|
public string CommandText => $"WHERE {string.Join(" AND ", ClauseComponents)}";
|
|
}
|
|
}
|
|
}
|