mirror of
https://github.com/ckaczor/sqltoolsservice.git
synced 2026-01-14 09:59:48 -05:00
This change ensures that when calling `requestContext.SendError` you are only able to supply parameters that match the language service beta protocol expected Error object. In other words, you have to provide an error message and optionally and error code. # **BREAKING API CHANGES** This will break displaying errors in Microsoft/vscode-mssql. I will be making changes to properly handle the error object shortly. * Adding contract for returning Error objects as per LanguageService "protocol" * Fixes throughout codebase to send only error message in error cases Cleanup of CredentialServiceTest unit test class Adding standard error handling for event flow validator * Adding optional data field as per protocol spec https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md * Adding optional validation for error objects
291 lines
11 KiB
C#
291 lines
11 KiB
C#
//
|
|
// Copyright (c) Microsoft. All rights reserved.
|
|
// Licensed under the MIT license. See LICENSE file in the project root for full license information.
|
|
//
|
|
|
|
using System;
|
|
using System.Linq;
|
|
using System.Threading.Tasks;
|
|
using Microsoft.SqlTools.ServiceLayer.EditData;
|
|
using Microsoft.SqlTools.ServiceLayer.EditData.Contracts;
|
|
using Microsoft.SqlTools.ServiceLayer.EditData.UpdateManagement;
|
|
using Microsoft.SqlTools.ServiceLayer.QueryExecution;
|
|
using Microsoft.SqlTools.ServiceLayer.QueryExecution.Contracts;
|
|
using Microsoft.SqlTools.ServiceLayer.Test.Common;
|
|
using Microsoft.SqlTools.ServiceLayer.UnitTests.Utility;
|
|
using Moq;
|
|
using Xunit;
|
|
|
|
namespace Microsoft.SqlTools.ServiceLayer.UnitTests.EditData
|
|
{
|
|
public class ServiceIntegrationTests
|
|
{
|
|
#region EditSession Operation Helper Tests
|
|
|
|
[Theory]
|
|
[InlineData(null)]
|
|
[InlineData("")]
|
|
[InlineData(" \t\n\r")]
|
|
[InlineData("Does not exist")]
|
|
public async Task NullOrMissingSessionId(string sessionId)
|
|
{
|
|
// Setup:
|
|
// ... Create a edit data service
|
|
var eds = new EditDataService(null, null, null);
|
|
|
|
// ... Create a session params that returns the provided session ID
|
|
var mockParams = new EditCreateRowParams {OwnerUri = sessionId};
|
|
|
|
// If: I ask to perform an action that requires a session
|
|
// Then: I should get an error from it
|
|
var efv = new EventFlowValidator<EditDisposeResult>()
|
|
.AddStandardErrorValidation()
|
|
.Complete();
|
|
await eds.HandleSessionRequest(mockParams, efv.Object, session => null);
|
|
efv.Validate();
|
|
}
|
|
|
|
[Fact]
|
|
public async Task OperationThrows()
|
|
{
|
|
// Setup:
|
|
// ... Create an edit data service with a session
|
|
var eds = new EditDataService(null, null, null);
|
|
eds.ActiveSessions[Common.OwnerUri] = await GetDefaultSession();
|
|
|
|
// ... Create a session param that returns the common owner uri
|
|
var mockParams = new EditCreateRowParams { OwnerUri = Common.OwnerUri };
|
|
|
|
// If: I ask to perform an action that requires a session
|
|
// Then: I should get an error from it
|
|
var efv = new EventFlowValidator<EditDisposeResult>()
|
|
.AddStandardErrorValidation()
|
|
.Complete();
|
|
await eds.HandleSessionRequest(mockParams, efv.Object, s => { throw new Exception(); });
|
|
efv.Validate();
|
|
}
|
|
|
|
|
|
|
|
#endregion
|
|
|
|
#region Dispose Tests
|
|
|
|
[Theory]
|
|
[InlineData(null)]
|
|
[InlineData("")]
|
|
[InlineData(" \t\n\r")]
|
|
[InlineData("Does not exist")]
|
|
public async Task DisposeNullOrMissingSessionId(string sessionId)
|
|
{
|
|
// Setup: Create a edit data service
|
|
var eds = new EditDataService(null, null, null);
|
|
|
|
// If: I ask to perform an action that requires a session
|
|
// Then: I should get an error from it
|
|
var efv = new EventFlowValidator<EditDisposeResult>()
|
|
.AddStandardErrorValidation()
|
|
.Complete();
|
|
await eds.HandleDisposeRequest(new EditDisposeParams {OwnerUri = sessionId}, efv.Object);
|
|
efv.Validate();
|
|
}
|
|
|
|
[Fact]
|
|
public async Task DisposeSuccess()
|
|
{
|
|
// Setup: Create an edit data service with a session
|
|
var eds = new EditDataService(null, null, null);
|
|
eds.ActiveSessions[Common.OwnerUri] = await GetDefaultSession();
|
|
|
|
// If: I ask to dispose of an existing session
|
|
var efv = new EventFlowValidator<EditDisposeResult>()
|
|
.AddResultValidation(Assert.NotNull)
|
|
.Complete();
|
|
await eds.HandleDisposeRequest(new EditDisposeParams {OwnerUri = Common.OwnerUri}, efv.Object);
|
|
|
|
// Then:
|
|
// ... It should have completed successfully
|
|
efv.Validate();
|
|
|
|
// ... And the session should have been removed from the active session list
|
|
Assert.Empty(eds.ActiveSessions);
|
|
}
|
|
|
|
#endregion
|
|
|
|
[Fact]
|
|
public async Task DeleteSuccess()
|
|
{
|
|
// Setup: Create an edit data service with a session
|
|
var eds = new EditDataService(null, null, null);
|
|
eds.ActiveSessions[Constants.OwnerUri] = await GetDefaultSession();
|
|
|
|
// If: I validly ask to delete a row
|
|
var efv = new EventFlowValidator<EditDeleteRowResult>()
|
|
.AddResultValidation(Assert.NotNull)
|
|
.Complete();
|
|
await eds.HandleDeleteRowRequest(new EditDeleteRowParams {OwnerUri = Constants.OwnerUri, RowId = 0}, efv.Object);
|
|
|
|
// Then:
|
|
// ... It should be successful
|
|
efv.Validate();
|
|
|
|
// ... There should be a delete in the session
|
|
EditSession s = eds.ActiveSessions[Constants.OwnerUri];
|
|
Assert.True(s.EditCache.Any(e => e.Value is RowDelete));
|
|
}
|
|
|
|
[Fact]
|
|
public async Task CreateSucceeds()
|
|
{
|
|
// Setup: Create an edit data service with a session
|
|
var eds = new EditDataService(null, null, null);
|
|
eds.ActiveSessions[Constants.OwnerUri] = await GetDefaultSession();
|
|
|
|
// If: I ask to create a row from a non existant session
|
|
var efv = new EventFlowValidator<EditCreateRowResult>()
|
|
.AddResultValidation(ecrr => { Assert.True(ecrr.NewRowId > 0); })
|
|
.Complete();
|
|
await eds.HandleCreateRowRequest(new EditCreateRowParams { OwnerUri = Constants.OwnerUri }, efv.Object);
|
|
|
|
// Then:
|
|
// ... It should have been successful
|
|
efv.Validate();
|
|
|
|
// ... There should be a create in the session
|
|
EditSession s = eds.ActiveSessions[Constants.OwnerUri];
|
|
Assert.True(s.EditCache.Any(e => e.Value is RowCreate));
|
|
}
|
|
|
|
[Fact]
|
|
public async Task RevertSucceeds()
|
|
{
|
|
// Setup: Create an edit data service with a session that has an pending edit
|
|
var eds = new EditDataService(null, null, null);
|
|
var session = await GetDefaultSession();
|
|
session.EditCache[0] = new Mock<RowEditBase>().Object;
|
|
eds.ActiveSessions[Constants.OwnerUri] = session;
|
|
|
|
// If: I ask to revert a row that has a pending edit
|
|
var efv = new EventFlowValidator<EditRevertRowResult>()
|
|
.AddResultValidation(Assert.NotNull)
|
|
.Complete();
|
|
await eds.HandleRevertRowRequest(new EditRevertRowParams { OwnerUri = Constants.OwnerUri, RowId = 0}, efv.Object);
|
|
|
|
// Then:
|
|
// ... It should have succeeded
|
|
efv.Validate();
|
|
|
|
// ... The edit cache should be empty again
|
|
EditSession s = eds.ActiveSessions[Constants.OwnerUri];
|
|
Assert.Empty(s.EditCache);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task UpdateSuccess()
|
|
{
|
|
// Setup: Create an edit data service with a session
|
|
var eds = new EditDataService(null, null, null);
|
|
var session = await GetDefaultSession();
|
|
eds.ActiveSessions[Constants.OwnerUri] = session;
|
|
var edit = new Mock<RowEditBase>();
|
|
edit.Setup(e => e.SetCell(It.IsAny<int>(), It.IsAny<string>())).Returns(new EditUpdateCellResult
|
|
{
|
|
IsRowDirty = true,
|
|
Cell = new EditCell(new DbCellValue(), true)
|
|
});
|
|
session.EditCache[0] = edit.Object;
|
|
|
|
// If: I validly ask to update a cell
|
|
var efv = new EventFlowValidator<EditUpdateCellResult>()
|
|
.AddResultValidation(eucr =>
|
|
{
|
|
Assert.NotNull(eucr);
|
|
Assert.NotNull(eucr.Cell);
|
|
Assert.True(eucr.IsRowDirty);
|
|
})
|
|
.Complete();
|
|
await eds.HandleUpdateCellRequest(new EditUpdateCellParams { OwnerUri = Constants.OwnerUri, RowId = 0}, efv.Object);
|
|
|
|
// Then:
|
|
// ... It should be successful
|
|
efv.Validate();
|
|
|
|
// ... Set cell should have been called once
|
|
edit.Verify(e => e.SetCell(It.IsAny<int>(), It.IsAny<string>()), Times.Once);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task GetRowsSuccess()
|
|
{
|
|
// Setup: Create an edit data service with a session
|
|
// Setup: Create an edit data service with a session
|
|
var eds = new EditDataService(null, null, null);
|
|
var session = await GetDefaultSession();
|
|
eds.ActiveSessions[Constants.OwnerUri] = session;
|
|
|
|
// If: I validly ask for rows
|
|
var efv = new EventFlowValidator<EditSubsetResult>()
|
|
.AddResultValidation(esr =>
|
|
{
|
|
Assert.NotNull(esr);
|
|
Assert.NotEmpty(esr.Subset);
|
|
Assert.NotEqual(0, esr.RowCount);
|
|
})
|
|
.Complete();
|
|
await eds.HandleSubsetRequest(new EditSubsetParams
|
|
{
|
|
OwnerUri = Constants.OwnerUri,
|
|
RowCount = 10,
|
|
RowStartIndex = 0
|
|
}, efv.Object);
|
|
|
|
// Then:
|
|
// ... It should be successful
|
|
efv.Validate();
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(null, "table", "table")] // Null owner URI
|
|
[InlineData(Common.OwnerUri, null, "table")] // Null object name
|
|
[InlineData(Common.OwnerUri, "table", null)] // Null object type
|
|
public async Task InitializeNullParams(string ownerUri, string objName, string objType)
|
|
{
|
|
// Setup: Create an edit data service without a session
|
|
var eds = new EditDataService(null, null, null);
|
|
|
|
// If:
|
|
// ... I have init params with a null parameter
|
|
var initParams = new EditInitializeParams
|
|
{
|
|
ObjectName = objName,
|
|
OwnerUri = ownerUri,
|
|
ObjectType = objType
|
|
};
|
|
|
|
// ... And I initialize an edit session with that
|
|
var efv = new EventFlowValidator<EditInitializeResult>()
|
|
.AddStandardErrorValidation()
|
|
.Complete();
|
|
await eds.HandleInitializeRequest(initParams, efv.Object);
|
|
|
|
// Then:
|
|
// ... An error event should have been raised
|
|
efv.Validate();
|
|
|
|
// ... There should not be a session
|
|
Assert.Empty(eds.ActiveSessions);
|
|
}
|
|
|
|
private static async Task<EditSession> GetDefaultSession()
|
|
{
|
|
// ... Create a session with a proper query and metadata
|
|
Query q = QueryExecution.Common.GetBasicExecutedQuery();
|
|
ResultSet rs = q.Batches[0].ResultSets[0];
|
|
EditTableMetadata etm = Common.GetStandardMetadata(rs.Columns);
|
|
EditSession s = await Common.GetCustomSession(q, etm);
|
|
return s;
|
|
}
|
|
}
|
|
}
|