mirror of
https://github.com/ckaczor/sqltoolsservice.git
synced 2026-01-14 01:25:40 -05:00
db1e4ae351
This is another large code review. I want to make a few more changes, but since these changes will stand on their own, I'll hold back on making this change set any larger than it already is. Changes in this request: To address Microsoft/vscode-mssql#326, instead of doing taskkill on the service layer when WaitForExit is executed, we now make an educated guess at which service layer was spawned when the test starts and do a Process.Kill on it when we shut down the test. All the perf tests have been moved into a new project. This was done to keep them easily separated from code coverage test runs. At the same time the perf tests were separated into separate classes for logical categorization. This process will likely be repeated on the stress tests. The tests can still easily be ran from Visual Studio Test Explorer To address Microsoft/vscode-mssql#349, a new SelfCleaningFile class was created to allow for easy cleanup of temporary files generated for integration tests via using blocks. Due to some of the refactoring done while moving the perf tests to a new project, the TestBase class had to be switched to more of a helper class style. As such, all tests that use inherit from TestBase now create a TestBase object on start via a using block. This also simplifies the cleanup at the end of the test. * Solution for hanging code coverage runs Code coverage runs would hang in certain scenarios if a test failed before the service process could be spawned. The taskkill command would fail to find the service process. The test would then wait for opencover to exit, but it would not since the service process it had spawned would still be running, causing the test run to hang indefinitely. Solution was to capture the service process after it launched and explicitly kill it when shutting down the test driver. * Setting the test name in the propery in the class and removign the parameter from each method * New project for perf tests * Reworking integration tests to cleanup temp files * Changes as per @llali review comments * Adding copyright notices * Renaming TestBase => TestHelper * Renaming SelfCleaningFile => SelfCleaningTempFile * Removing code that sets TestName property * Fixing compilation error due to removed code
328 lines
14 KiB
C#
328 lines
14 KiB
C#
//
|
|
// Copyright (c) Microsoft. All rights reserved.
|
|
// Licensed under the MIT license. See LICENSE file in the project root for full license information.
|
|
//
|
|
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
using System.Threading;
|
|
using System.Threading.Tasks;
|
|
using Microsoft.SqlTools.ServiceLayer.QueryExecution.Contracts;
|
|
using Microsoft.SqlTools.ServiceLayer.TestDriver.Utility;
|
|
using Microsoft.SqlTools.ServiceLayer.Workspace.Contracts;
|
|
using Xunit;
|
|
|
|
namespace Microsoft.SqlTools.ServiceLayer.TestDriver.Tests
|
|
{
|
|
public class QueryExecutionTests
|
|
{
|
|
[Fact]
|
|
public async Task TestQueryCancelReliability()
|
|
{
|
|
const string query = "SELECT * FROM sys.objects a CROSS JOIN sys.objects b CROSS JOIN sys.objects c";
|
|
|
|
using (SelfCleaningTempFile queryTempFile = new SelfCleaningTempFile())
|
|
using (TestHelper testHelper = new TestHelper())
|
|
{
|
|
await testHelper.Connect(queryTempFile.FilePath, ConnectionTestUtils.AzureTestServerConnection);
|
|
|
|
// Run and cancel 100 queries
|
|
for (int i = 0; i < 100; i++)
|
|
{
|
|
var queryTask = testHelper.RunQuery(queryTempFile.FilePath, query);
|
|
|
|
var cancelResult = await testHelper.CancelQuery(queryTempFile.FilePath);
|
|
Assert.NotNull(cancelResult);
|
|
Assert.True(string.IsNullOrEmpty(cancelResult.Messages));
|
|
|
|
await queryTask;
|
|
}
|
|
|
|
await testHelper.Disconnect(queryTempFile.FilePath);
|
|
}
|
|
}
|
|
|
|
[Fact]
|
|
public async Task TestQueryDoesNotBlockOtherRequests()
|
|
{
|
|
const string query = "SELECT * FROM sys.objects a CROSS JOIN sys.objects b CROSS JOIN sys.objects c";
|
|
|
|
using (SelfCleaningTempFile queryTempFile = new SelfCleaningTempFile())
|
|
using (TestHelper testHelper = new TestHelper())
|
|
{
|
|
await testHelper.Connect(queryTempFile.FilePath, ConnectionTestUtils.AzureTestServerConnection);
|
|
|
|
// Start a long-running query
|
|
var queryTask = testHelper.RunQuery(queryTempFile.FilePath, query, 60000);
|
|
|
|
// Interact with the service. None of these requests should time out while waiting for the query to finish
|
|
for (int i = 0; i < 10; i++)
|
|
{
|
|
using (SelfCleaningTempFile queryFile2 = new SelfCleaningTempFile())
|
|
{
|
|
await testHelper.Connect(queryFile2.FilePath, ConnectionTestUtils.AzureTestServerConnection);
|
|
Assert.NotNull(await testHelper.RequestCompletion(queryFile2.FilePath, "SELECT * FROM sys.objects", 0, 10));
|
|
await testHelper.Disconnect(queryFile2.FilePath);
|
|
}
|
|
}
|
|
|
|
await testHelper.CancelQuery(queryTempFile.FilePath);
|
|
await testHelper.Disconnect(queryTempFile.FilePath);
|
|
}
|
|
}
|
|
|
|
[Fact]
|
|
public async Task TestParallelQueryExecution()
|
|
{
|
|
const int queryCount = 10;
|
|
const string query = "SELECT * FROM sys.objects";
|
|
|
|
using (TestHelper testHelper = new TestHelper())
|
|
{
|
|
// Create n connections
|
|
SelfCleaningTempFile[] ownerUris = new SelfCleaningTempFile[queryCount];
|
|
for (int i = 0; i < queryCount; i++)
|
|
{
|
|
ownerUris[i] = new SelfCleaningTempFile();
|
|
Assert.NotNull(await testHelper.Connect(ownerUris[i].FilePath, ConnectionTestUtils.AzureTestServerConnection));
|
|
}
|
|
|
|
// Run n queries at once
|
|
var queryTasks = new Task<QueryExecuteCompleteParams>[queryCount];
|
|
for (int i = 0; i < queryCount; i++)
|
|
{
|
|
queryTasks[i] = testHelper.RunQuery(ownerUris[i].FilePath, query);
|
|
}
|
|
await Task.WhenAll(queryTasks);
|
|
|
|
// Verify that they all completed with results and Disconnect
|
|
for (int i = 0; i < queryCount; i++)
|
|
{
|
|
Assert.NotNull(queryTasks[i].Result);
|
|
Assert.NotNull(queryTasks[i].Result.BatchSummaries);
|
|
await testHelper.Disconnect(ownerUris[i].FilePath);
|
|
ownerUris[i].Dispose();
|
|
}
|
|
}
|
|
}
|
|
|
|
[Fact]
|
|
public async Task TestSaveResultsDoesNotBlockOtherRequests()
|
|
{
|
|
const string query = "SELECT * FROM sys.objects";
|
|
|
|
using (SelfCleaningTempFile queryTempFile = new SelfCleaningTempFile())
|
|
using (TestHelper testHelper = new TestHelper())
|
|
{
|
|
await testHelper.Connect(queryTempFile.FilePath, ConnectionTestUtils.AzureTestServerConnection);
|
|
|
|
// Execute a query
|
|
await testHelper.RunQuery(queryTempFile.FilePath, query);
|
|
|
|
// Spawn several tasks to save results
|
|
var saveTasks = new Task<SaveResultRequestResult>[100];
|
|
for (int i = 0; i < 100; i++)
|
|
{
|
|
if (i % 2 == 0)
|
|
{
|
|
saveTasks[i] = testHelper.SaveAsCsv(queryTempFile.FilePath, System.IO.Path.GetTempFileName(), 0, 0);
|
|
}
|
|
else
|
|
{
|
|
saveTasks[i] = testHelper.SaveAsJson(queryTempFile.FilePath, System.IO.Path.GetTempFileName(), 0, 0);
|
|
}
|
|
}
|
|
|
|
// Interact with the service. None of these requests should time out while waiting for the save results tasks to finish
|
|
for (int i = 0; i < 10; i++)
|
|
{
|
|
using(SelfCleaningTempFile queryFile2 = new SelfCleaningTempFile())
|
|
{
|
|
await testHelper.Connect(queryFile2.FilePath, ConnectionTestUtils.AzureTestServerConnection);
|
|
Assert.NotNull(await testHelper.RequestCompletion(queryFile2.FilePath, "SELECT * FROM sys.objects", 0, 10));
|
|
await testHelper.Disconnect(queryFile2.FilePath);
|
|
}
|
|
}
|
|
|
|
await Task.WhenAll(saveTasks);
|
|
|
|
await testHelper.Disconnect(queryTempFile.FilePath);
|
|
}
|
|
}
|
|
|
|
[Fact]
|
|
public async Task TestQueryingSubsetDoesNotBlockOtherRequests()
|
|
{
|
|
const string query = "SELECT * FROM sys.objects";
|
|
|
|
using (SelfCleaningTempFile queryTempFile = new SelfCleaningTempFile())
|
|
using (TestHelper testHelper = new TestHelper())
|
|
{
|
|
await testHelper.Connect(queryTempFile.FilePath, ConnectionTestUtils.AzureTestServerConnection);
|
|
|
|
// Execute a query
|
|
await testHelper.RunQuery(queryTempFile.FilePath, query);
|
|
|
|
// Spawn several tasks for subset requests
|
|
var subsetTasks = new Task<QueryExecuteSubsetResult>[100];
|
|
for (int i = 0; i < 100; i++)
|
|
{
|
|
subsetTasks[i] = testHelper.ExecuteSubset(queryTempFile.FilePath, 0, 0, 0, 100);
|
|
}
|
|
|
|
// Interact with the service. None of these requests should time out while waiting for the subset tasks to finish
|
|
for (int i = 0; i < 10; i++)
|
|
{
|
|
using (SelfCleaningTempFile queryFile2 = new SelfCleaningTempFile())
|
|
{
|
|
await testHelper.Connect(queryFile2.FilePath, ConnectionTestUtils.AzureTestServerConnection);
|
|
Assert.NotNull(await testHelper.RequestCompletion(queryFile2.FilePath, "SELECT * FROM sys.objects", 0, 10));
|
|
await testHelper.Disconnect(queryFile2.FilePath);
|
|
}
|
|
}
|
|
|
|
await Task.WhenAll(subsetTasks);
|
|
|
|
await testHelper.Disconnect(queryTempFile.FilePath);
|
|
}
|
|
}
|
|
|
|
[Fact]
|
|
public async Task TestCancelQueryWhileOtherOperationsAreInProgress()
|
|
{
|
|
const string query = "SELECT * FROM sys.objects a CROSS JOIN sys.objects b";
|
|
|
|
using (SelfCleaningTempFile queryTempFile = new SelfCleaningTempFile())
|
|
using (TestHelper testHelper = new TestHelper())
|
|
{
|
|
List<Task> tasks = new List<Task>();
|
|
|
|
await testHelper.Connect(queryTempFile.FilePath, ConnectionTestUtils.AzureTestServerConnection);
|
|
|
|
// Execute a long-running query
|
|
var queryTask = testHelper.RunQuery(queryTempFile.FilePath, query, 60000);
|
|
|
|
// Queue up some tasks that interact with the service
|
|
for (int i = 0; i < 10; i++)
|
|
{
|
|
using (SelfCleaningTempFile queryFile2 = new SelfCleaningTempFile())
|
|
{
|
|
tasks.Add(Task.Run(async () =>
|
|
{
|
|
await testHelper.Connect(queryFile2.FilePath, ConnectionTestUtils.AzureTestServerConnection);
|
|
await testHelper.RequestCompletion(queryFile2.FilePath, "SELECT * FROM sys.objects", 0, 10);
|
|
await testHelper.RunQuery(queryFile2.FilePath, "SELECT * FROM sys.objects");
|
|
await testHelper.Disconnect(queryFile2.FilePath);
|
|
}));
|
|
}
|
|
}
|
|
|
|
// Cancel the long-running query
|
|
await testHelper.CancelQuery(queryTempFile.FilePath);
|
|
|
|
await testHelper.Disconnect(queryTempFile.FilePath);
|
|
}
|
|
}
|
|
|
|
[Fact]
|
|
public async Task ExecuteBasicQueryTest()
|
|
{
|
|
const string query = "SELECT * FROM sys.all_columns c";
|
|
|
|
using (SelfCleaningTempFile queryTempFile = new SelfCleaningTempFile())
|
|
using (TestHelper testHelper = new TestHelper())
|
|
{
|
|
bool connected = await testHelper.Connect(queryTempFile.FilePath, ConnectionTestUtils.LocalhostConnection);
|
|
Assert.True(connected, "Connection is successful");
|
|
|
|
Thread.Sleep(500);
|
|
|
|
DidOpenTextDocumentNotification openParams = new DidOpenTextDocumentNotification()
|
|
{
|
|
TextDocument = new TextDocumentItem()
|
|
{
|
|
Uri = queryTempFile.FilePath,
|
|
LanguageId = "enu",
|
|
Version = 1,
|
|
Text = query
|
|
}
|
|
};
|
|
|
|
await testHelper.RequestOpenDocumentNotification(openParams);
|
|
|
|
var queryResult = await testHelper.RunQuery(queryTempFile.FilePath, query, 10000);
|
|
|
|
Assert.NotNull(queryResult);
|
|
Assert.NotNull(queryResult.BatchSummaries);
|
|
|
|
foreach (var batchSummary in queryResult.BatchSummaries)
|
|
{
|
|
foreach (var resultSetSummary in batchSummary.ResultSetSummaries)
|
|
{
|
|
Assert.True(resultSetSummary.RowCount > 0);
|
|
}
|
|
}
|
|
|
|
var subsetRequest = new QueryExecuteSubsetParams()
|
|
{
|
|
OwnerUri = queryTempFile.FilePath,
|
|
BatchIndex = 0,
|
|
ResultSetIndex = 0,
|
|
RowsStartIndex = 0,
|
|
RowsCount = 100,
|
|
};
|
|
|
|
var querySubset = await testHelper.RequestQueryExecuteSubset(subsetRequest);
|
|
Assert.NotNull(querySubset);
|
|
Assert.True(querySubset.ResultSubset.RowCount == 100);
|
|
|
|
await testHelper.Disconnect(queryTempFile.FilePath);
|
|
}
|
|
}
|
|
|
|
[Fact]
|
|
public async Task TestQueryingAfterCompletionRequests()
|
|
{
|
|
const string query = "SELECT * FROM sys.objects";
|
|
|
|
using (SelfCleaningTempFile queryTempFile = new SelfCleaningTempFile())
|
|
using (TestHelper testHelper = new TestHelper())
|
|
{
|
|
List<Task> tasks = new List<Task>();
|
|
|
|
await testHelper.Connect(queryTempFile.FilePath, ConnectionTestUtils.AzureTestServerConnection);
|
|
|
|
Enumerable.Range(0, 10).ToList().ForEach(arg => tasks.Add(testHelper.RequestCompletion(queryTempFile.FilePath, query, 0, 10)));
|
|
var queryTask = testHelper.RunQuery(queryTempFile.FilePath, query);
|
|
tasks.Add(queryTask);
|
|
await Task.WhenAll(tasks);
|
|
|
|
Assert.NotNull(queryTask.Result);
|
|
Assert.NotNull(queryTask.Result.BatchSummaries);
|
|
|
|
await testHelper.Connect(queryTempFile.FilePath, ConnectionTestUtils.DataToolsTelemetryAzureConnection);
|
|
tasks.Clear();
|
|
Enumerable.Range(0, 10).ToList().ForEach(arg => tasks.Add(testHelper.RequestCompletion(queryTempFile.FilePath, query, 0, 10)));
|
|
queryTask = testHelper.RunQuery(queryTempFile.FilePath, query);
|
|
tasks.Add(queryTask);
|
|
await Task.WhenAll(tasks);
|
|
|
|
Assert.NotNull(queryTask.Result);
|
|
Assert.NotNull(queryTask.Result.BatchSummaries);
|
|
|
|
await testHelper.Connect(queryTempFile.FilePath, ConnectionTestUtils.SqlDataToolsAzureConnection);
|
|
tasks.Clear();
|
|
Enumerable.Range(0, 10).ToList().ForEach(arg => tasks.Add(testHelper.RequestCompletion(queryTempFile.FilePath, query, 0, 10)));
|
|
queryTask = testHelper.RunQuery(queryTempFile.FilePath, query);
|
|
tasks.Add(queryTask);
|
|
await Task.WhenAll(tasks);
|
|
|
|
Assert.NotNull(queryTask.Result);
|
|
Assert.NotNull(queryTask.Result.BatchSummaries);
|
|
|
|
await testHelper.Disconnect(queryTempFile.FilePath);
|
|
}
|
|
}
|
|
}
|
|
}
|