mirror of
https://github.com/ckaczor/sqltoolsservice.git
synced 2026-01-14 01:25:40 -05:00
This is a very large change. I'll try to outline what's going on.
1. This adds the **EditDataService** which manages editing **Sessions**.
1. Each session has a **ResultSet** (from the QueryExecutionService) which has the rows of the table and basic metadata about the columns
2. Each session also has an **IEditTableMetadata** implementation which is derived from SMO metadata which provides more in-depth and trustworthy data about the table than SqlClient alone can.
3. Each session holds a list of **RowEditBase** abstract class implementations
1. **RowUpdate** - Update cells in a row (generates `UPDATE` statement)
2. **RowDelete** - Delete an entire row (generates `DELETE` statement)
3. **RowCreate** - Add a new row (generates `INSERT INTO` statement)
4. Row edits have a collection of **CellUpdates** that hold updates for individual cells (except for RowDelete)
1. Cell updates are generated from text
5. RowEditBase offers some baseline functionality
1. Generation of `WHERE` clauses (which can be parameterized)
2. Validation of whether a column can be updated
2. New API Actions
1. edit/initialize - Queries for the contents of a table/view, builds SMO metadata, sets up a session
2. edit/createRow - Adds a new RowCreate to the Session
3. edit/deleteRow - Adds a new RowDelete to the Session
4. edit/updateCell - Adds a CellUpdate to a RowCreate or RowUpdate in the Session
5. edit/revertRow - Removes a RowCreate, RowDelete, or RowUpdate from the Session
6. edit/script - Generates a script for the changes in the Session and stores to disk
7. edit/dispose - Removes a Session and releases the query
3. Smaller updates (unit test mock improvements, tweaks to query execution service)
**There are more updates planned -- this is just to get eyeballs on the main body of code**
* Initial stubs for edit data service
* Stubbing out update management code
* Adding rudimentary dispose request
* More stubbing out of update row code
* Adding complete edit command contracts, stubbing out request handlers
* Adding basic implementation of get script
* More in progress work to implement base of row edits
* More in progress work to implement base of row edits
* Adding string => object conversion logic and various cleanup
* Adding a formatter for using values in scripts
* Splitting IMessageSender into IEventSender and IRequestSender
* Adding inter-service method for executing queries
* Adding inter-service method for disposing of a query
* Changing edit contract to include the object to edit
* Fully fleshing out edit session initialization
* Generation of delete scripts is working
* Adding scripter for update statements
* Adding scripting functionality for INSERT statements
* Insert, Update, and Delete all working with SMO metadata
* Polishing for SqlScriptFormatter
* Unit tests and reworked byte[] conversion
* Replacing the awful and inflexible Dictionary<string, string>[][] with a much better test data set class
* Fixing syntax error in generated UPDATE statements
* Adding unit tests for RowCreate
* Adding tests for the row edit base class
* Adding row delete tests
* Adding RowUpdate tests, validation for number of key columns
* Adding tests for the unit class
* Adding get script tests for the session
* Service integration tests, except initialization tests
* Service integration tests, except initialization tests
* Adding messages to sr.strings
* Adding messages to sr.strings
* Fixing broken unit tests
* Adding factory pattern for SMO metadata provider
* Copyright and other comments
* Addressing first round of comments
* Refactoring EditDataService to have a single method for handling
session-dependent operations
* Refactoring Edit Data contracts to inherit from a Session and Row
operation params base class
* Copyright additions
* Small tweak to strings
* Updated unit tests to test the refactors
* More revisions as per pull request comments
184 lines
7.5 KiB
C#
184 lines
7.5 KiB
C#
//
|
|
// Copyright (c) Microsoft. All rights reserved.
|
|
// Licensed under the MIT license. See LICENSE file in the project root for full license information.
|
|
//
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Data.Common;
|
|
using System.Linq;
|
|
using System.Text.RegularExpressions;
|
|
using System.Threading;
|
|
using Microsoft.SqlTools.ServiceLayer.EditData;
|
|
using Microsoft.SqlTools.ServiceLayer.EditData.Contracts;
|
|
using Microsoft.SqlTools.ServiceLayer.EditData.UpdateManagement;
|
|
using Microsoft.SqlTools.ServiceLayer.QueryExecution;
|
|
using Microsoft.SqlTools.ServiceLayer.Test.Utility;
|
|
using Xunit;
|
|
|
|
namespace Microsoft.SqlTools.ServiceLayer.Test.EditData
|
|
{
|
|
public class RowEditBaseTests
|
|
{
|
|
[Theory]
|
|
[InlineData(-1)] // Negative index
|
|
[InlineData(100)] // Index larger than number of columns
|
|
public void ValidateUpdatableColumnOutOfRange(int columnId)
|
|
{
|
|
// Setup: Create a result set
|
|
ResultSet rs = GetResultSet(
|
|
new DbColumn[] { new TestDbColumn("id", true), new TestDbColumn("col1")},
|
|
new object[] { "id", "1" });
|
|
|
|
// If: I validate a column ID that is out of range
|
|
// Then: It should throw
|
|
RowEditTester tester = new RowEditTester(rs, null);
|
|
Assert.Throws<ArgumentOutOfRangeException>(() => tester.ValidateColumn(columnId));
|
|
}
|
|
|
|
[Fact]
|
|
public void ValidateUpdatableColumnNotUpdatable()
|
|
{
|
|
// Setup: Create a result set with an identity column
|
|
ResultSet rs = GetResultSet(
|
|
new DbColumn[] { new TestDbColumn("id", true), new TestDbColumn("col1") },
|
|
new object[] { "id", "1" });
|
|
|
|
// If: I validate a column ID that is not updatable
|
|
// Then: It should throw
|
|
RowEditTester tester = new RowEditTester(rs, null);
|
|
Assert.Throws<InvalidOperationException>(() => tester.ValidateColumn(0));
|
|
}
|
|
|
|
[Theory]
|
|
[MemberData(nameof(GetWhereClauseIsNotNullData))]
|
|
public void GetWhereClauseSimple(DbColumn col, object val, string nullClause)
|
|
{
|
|
// Setup: Create a result set and metadata provider with a single column
|
|
var cols = new[] {col};
|
|
ResultSet rs = GetResultSet(cols, new[] {val});
|
|
IEditTableMetadata etm = Common.GetMetadata(cols);
|
|
|
|
RowEditTester rt = new RowEditTester(rs, etm);
|
|
rt.ValidateWhereClauseSingleKey(nullClause);
|
|
}
|
|
|
|
public static IEnumerable<object> GetWhereClauseIsNotNullData
|
|
{
|
|
get
|
|
{
|
|
yield return new object[] {new TestDbColumn("col"), DBNull.Value, "IS NULL"};
|
|
yield return new object[] {new TestDbColumn("col", "VARBINARY", typeof(byte[])), new byte[5], "IS NOT NULL"};
|
|
yield return new object[] {new TestDbColumn("col", "TEXT", typeof(string)), "abc", "IS NOT NULL"};
|
|
yield return new object[] {new TestDbColumn("col", "NTEXT", typeof(string)), "abc", "IS NOT NULL"};
|
|
}
|
|
}
|
|
|
|
[Fact]
|
|
public void GetWhereClauseMultipleKeyColumns()
|
|
{
|
|
// Setup: Create a result set and metadata provider with multiple key columns
|
|
DbColumn[] cols = {new TestDbColumn("col1"), new TestDbColumn("col2")};
|
|
ResultSet rs = GetResultSet(cols, new object[] {"abc", "def"});
|
|
IEditTableMetadata etm = Common.GetMetadata(cols);
|
|
|
|
RowEditTester rt = new RowEditTester(rs, etm);
|
|
rt.ValidateWhereClauseMultipleKeys();
|
|
}
|
|
|
|
[Fact]
|
|
public void GetWhereClauseNoKeyColumns()
|
|
{
|
|
// Setup: Create a result set and metadata provider with no key columns
|
|
DbColumn[] cols = {new TestDbColumn("col1"), new TestDbColumn("col2")};
|
|
ResultSet rs = GetResultSet(cols, new object[] {"abc", "def"});
|
|
IEditTableMetadata etm = Common.GetMetadata(new DbColumn[] {});
|
|
|
|
RowEditTester rt = new RowEditTester(rs, etm);
|
|
rt.ValidateWhereClauseNoKeys();
|
|
}
|
|
|
|
private static ResultSet GetResultSet(DbColumn[] columns, object[] row)
|
|
{
|
|
object[][] rows = {row};
|
|
var testResultSet = new TestResultSet(columns, rows);
|
|
var testReader = new TestDbDataReader(new [] {testResultSet});
|
|
var resultSet = new ResultSet(testReader, 0,0, QueryExecution.Common.GetFileStreamFactory(new Dictionary<string, byte[]>()));
|
|
resultSet.ReadResultToEnd(CancellationToken.None).Wait();
|
|
return resultSet;
|
|
}
|
|
|
|
private class RowEditTester : RowEditBase
|
|
{
|
|
public RowEditTester(ResultSet rs, IEditTableMetadata meta) : base(0, rs, meta) { }
|
|
|
|
public void ValidateColumn(int columnId)
|
|
{
|
|
ValidateColumnIsUpdatable(columnId);
|
|
}
|
|
|
|
// ReSharper disable once UnusedParameter.Local
|
|
public void ValidateWhereClauseSingleKey(string nullValue)
|
|
{
|
|
// If: I generate a where clause with one is null column value
|
|
WhereClause wc = GetWhereClause(false);
|
|
|
|
// Then:
|
|
// ... There should only be one component
|
|
Assert.Equal(1, wc.ClauseComponents.Count);
|
|
|
|
// ... Parameterization should be empty
|
|
Assert.Empty(wc.Parameters);
|
|
|
|
// ... The component should contain the name of the column and be null
|
|
Assert.Equal(
|
|
$"({AssociatedObjectMetadata.Columns.First().EscapedName} {nullValue})",
|
|
wc.ClauseComponents[0]);
|
|
|
|
// ... The complete clause should contain a single WHERE
|
|
Assert.Equal($"WHERE {wc.ClauseComponents[0]}", wc.CommandText);
|
|
}
|
|
|
|
public void ValidateWhereClauseMultipleKeys()
|
|
{
|
|
// If: I generate a where clause with multiple key columns
|
|
WhereClause wc = GetWhereClause(false);
|
|
|
|
// Then:
|
|
// ... There should two components
|
|
var keys = AssociatedObjectMetadata.KeyColumns.ToArray();
|
|
Assert.Equal(keys.Length, wc.ClauseComponents.Count);
|
|
|
|
// ... Parameterization should be empty
|
|
Assert.Empty(wc.Parameters);
|
|
|
|
// ... The components should contain the name of the column and the value
|
|
Regex r = new Regex(@"\([0-9a-z]+ = .+\)");
|
|
Assert.All(wc.ClauseComponents, s => Assert.True(r.IsMatch(s)));
|
|
|
|
// ... The complete clause should contain multiple cause components joined
|
|
// with and
|
|
Assert.True(wc.CommandText.StartsWith("WHERE "));
|
|
Assert.True(wc.CommandText.EndsWith(string.Join(" AND ", wc.ClauseComponents)));
|
|
}
|
|
|
|
public void ValidateWhereClauseNoKeys()
|
|
{
|
|
// If: I generate a where clause from metadata that doesn't have keys
|
|
// Then: An exception should be thrown
|
|
Assert.Throws<InvalidOperationException>(() => GetWhereClause(false));
|
|
}
|
|
|
|
public override string GetScript()
|
|
{
|
|
throw new NotImplementedException();
|
|
}
|
|
|
|
public override EditUpdateCellResult SetCell(int columnId, string newValue)
|
|
{
|
|
throw new NotImplementedException();
|
|
}
|
|
}
|
|
}
|
|
}
|