From 1a244c629643366c11f5e50975e33b0c81a8648e Mon Sep 17 00:00:00 2001 From: Eric Amodio Date: Wed, 1 Mar 2017 01:14:15 -0500 Subject: [PATCH] Fixes pinned editor issues --- src/quickPicks/quickPicks.ts | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/quickPicks/quickPicks.ts b/src/quickPicks/quickPicks.ts index 315adca..59e809e 100644 --- a/src/quickPicks/quickPicks.ts +++ b/src/quickPicks/quickPicks.ts @@ -10,7 +10,7 @@ export function getQuickPickIgnoreFocusOut() { export async function openEditor(uri: Uri, pinned: boolean = false) { try { - if (pinned) return await commands.executeCommand(BuiltInCommands.Open, uri); + if (!pinned) return await commands.executeCommand(BuiltInCommands.Open, uri); const document = await workspace.openTextDocument(uri); return window.showTextDocument(document, (window.activeTextEditor && window.activeTextEditor.viewColumn) || 1, true); @@ -41,16 +41,12 @@ export class OpenFileCommandQuickPickItem extends CommandQuickPickItem { super(item, undefined, undefined); } - async execute(): Promise<{}> { - return this.preview(); + async execute(pinned: boolean = false): Promise<{}> { + return this.open(pinned); } - async open(): Promise { - return openEditor(this.uri); - } - - async preview(): Promise<{}> { - return openEditor(this.uri, true); + async open(pinned: boolean = false): Promise { + return openEditor(this.uri, pinned); } } @@ -62,7 +58,7 @@ export class OpenFilesCommandQuickPickItem extends CommandQuickPickItem { async execute(): Promise<{}> { for (const uri of this.uris) { - openEditor(uri); + openEditor(uri, true); } return undefined; }